Patches item #3035455, was opened at 2010-07-27 11:10 Message generated for change (Settings changed) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3035455...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: bugfix

Status: Closed Resolution: Accepted

Priority: 5 Private: No Submitted By: Vladimir Gorsunov () Assigned to: Nobody/Anonymous (nobody) Summary: Correct error messages for ALSA device setup

Initial Comment: -

----------------------------------------------------------------------

Comment By: IOhannes m zmlnig (zmoelnig) Date: 2010-08-04 02:15

Message: currently when initializing alsa, all errors will be logged as "(input)", regardless of whether they are input or output errors. the patch seems to fix this by printing "(output)" where output is concerned and "(input)" where input is concerned.

it doesn't do anything else. i would include it.

vladimir: if you want patches to be included you should be more verbose than "this fixes a bug"; people need to invest time to review the patch and it's a bit frustrating to stare at diffs only to find out that the original poster was not happy with the indentation.

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-07-27 12:18

Message: can you give more information on the problem this patch is addressing?

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3035455...