Hey,
Since the svnnotify script includes direct links to the changed code, and more, would anyone object if the commit emails no longer include the diff?
I think I initially objected to this, now I have seen the error of my ways. :D
.hc
----------------------------------------------------------------------------
Mistrust authority - promote decentralization. - the hacker ethic
On Fri, 23 Jan 2009, Hans-Christoph Steiner wrote:
Since the svnnotify script includes direct links to the changed code, and more, would anyone object if the commit emails no longer include the diff? I think I initially objected to this, now I have seen the error of my ways. :D
So, what's the error of your ways?
_ _ __ ___ _____ ________ _____________ _____________________ ... | Mathieu Bouchard - tél:+1.514.383.3801, Montréal, Québec
On Jan 23, 2009, at 10:38 PM, Mathieu Bouchard wrote:
On Fri, 23 Jan 2009, Hans-Christoph Steiner wrote:
Since the svnnotify script includes direct links to the changed code, and more, would anyone object if the commit emails no longer include the diff? I think I initially objected to this, now I have seen the error of my ways. :D
So, what's the error of your ways?
_ _ __ ___ _____ ________ _____________ _____________________ ... | Mathieu Bouchard - tél:+1.514.383.3801, Montréal, Québec
It was just a joke, I mean that I have come around to others' way of thinking on this.
.hc
----------------------------------------------------------------------------
News is what people want to keep hidden and everything else is publicity. - Bill Moyers
On Sat, 24 Jan 2009, Hans-Christoph Steiner wrote:
On Jan 23, 2009, at 10:38 PM, Mathieu Bouchard wrote:
On Fri, 23 Jan 2009, Hans-Christoph Steiner wrote:
Since the svnnotify script includes direct links to the changed code, and more, would anyone object if the commit emails no longer include the diff? I think I initially objected to this, now I have seen the error of my ways. :D
So, what's the error of your ways?
It was just a joke, I mean that I have come around to others' way of thinking on this.
My question is: what are the reasons for not putting the diff inside of the email?
_ _ __ ___ _____ ________ _____________ _____________________ ... | Mathieu Bouchard - tél:+1.514.383.3801, Montréal, Québec
On Jan 24, 2009, at 3:40 PM, Mathieu Bouchard wrote:
On Sat, 24 Jan 2009, Hans-Christoph Steiner wrote:
On Jan 23, 2009, at 10:38 PM, Mathieu Bouchard wrote:
On Fri, 23 Jan 2009, Hans-Christoph Steiner wrote:
Since the svnnotify script includes direct links to the changed code, and more, would anyone object if the commit emails no longer include the diff? I think I initially objected to this, now I have seen the error of my ways. :D
So, what's the error of your ways?
It was just a joke, I mean that I have come around to others' way of thinking on this.
My question is: what are the reasons for not putting the diff inside of the email?
_ _ __ ___ _____ ________ _____________ _____________________ ... | Mathieu Bouchard - tél:+1.514.383.3801, Montréal, Québec
The emails get quite large, like 260k+ per email and they are not very easy to navigate. The web svn has a lot more info, so I think that it is more useful to get to the web site as soon as possible to get info.
.hc
----------------------------------------------------------------------------
'You people have such restrictive dress for women,’ she said, hobbling away in three inch heels and panty hose to finish out another pink- collar temp pool day. - “Hijab Scene #2", by Mohja Kahf
On Jan 25, 2009, at 7:20 PM, Hans-Christoph Steiner wrote:
On Jan 24, 2009, at 3:40 PM, Mathieu Bouchard wrote:
On Sat, 24 Jan 2009, Hans-Christoph Steiner wrote:
On Jan 23, 2009, at 10:38 PM, Mathieu Bouchard wrote:
On Fri, 23 Jan 2009, Hans-Christoph Steiner wrote:
Since the svnnotify script includes direct links to the changed code, and more, would anyone object if the commit emails no longer include the diff? I think I initially objected to this, now I have seen the error of my ways. :D
So, what's the error of your ways?
It was just a joke, I mean that I have come around to others' way of thinking on this.
My question is: what are the reasons for not putting the diff inside of the email?
_ _ __ ___ _____ ________ _____________ _____________________ ... | Mathieu Bouchard - tél:+1.514.383.3801, Montréal, Québec
The emails get quite large, like 260k+ per email and they are not very easy to navigate. The web svn has a lot more info, so I think that it is more useful to get to the web site as soon as possible to get info.
.hc
Ok, it seems there were no objections, so I change it so that the diffs are no longer included in the emails to pd-cvs. Let me know if anyone wants it back, it is easy to change.
.hc
----------------------------------------------------------------------------
"[W]e have invented the technology to eliminate scarcity, but we are deliberately throwing it away to benefit those who profit from scarcity." -John Gilmore
Quoting "Hans-Christoph Steiner" hans@eds.org:
Ok, it seems there were no objections, so I change it so that the diffs are no longer included in the emails to pd-cvs. Let me know if anyone wants it back, it is easy to change.
hmm, know that is in action i find it rather annoying that i don't see what the commit actually did. (log-entries are sometimes so misleading, compared to diffs)
so i'm not sure yet whether i will vote for a switch-back.
fgmasdr IOhannes
---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.
On Feb 11, 2009, at 7:34 AM, zmoelnig@iem.at wrote:
Quoting "Hans-Christoph Steiner" hans@eds.org:
Ok, it seems there were no objections, so I change it so that the diffs are no longer included in the emails to pd-cvs. Let me know if anyone wants it back, it is easy to change.
hmm, know that is in action i find it rather annoying that i don't see what the commit actually did. (log-entries are sometimes so misleading, compared to diffs)
so i'm not sure yet whether i will vote for a switch-back.
fgmasdr IOhannes
Yeah, for short commits, that makes sense. Maybe this will encourage people to write good commit logs :). On the other hand, I recently commited a 1 meg .h file that has a giant 3D array filled with data. I cringed thinking that it would be sent as a 1 meg attachment to pd- cvs.
.hc
This message was sent using IMP, the Internet Messaging Program.
Pd-dev mailing list Pd-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
----------------------------------------------------------------------------
If nature has made any one thing less susceptible than all others of exclusive property, it is the action of the thinking power called an idea, which an individual may exclusively possess as long as he keeps it to himself; but the moment it is divulged, it forces itself into the possession of everyone, and the receiver cannot dispossess himself of it. - Thomas Jefferson
Quoting "Hans-Christoph Steiner" hans@eds.org:
Yeah, for short commits, that makes sense. Maybe this will encourage people to write good commit logs :). On the other hand, I recently commited a 1 meg .h file that has a giant 3D array filled with data. I cringed thinking that it would be sent as a 1 meg attachment to pd- cvs.
well, probably it is not such a good idea to have 1meg headerfiles in general. afaiu, this was to include WAVs into the binary. a probably better solution would have been to upload the WAVs as WAVs and include the data in the build-process. thus there would have been no 1meg logfile, and WAVs store data more efficiently than .h files.
fgamsdr IOhannes
---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.
On Feb 11, 2009, at 11:35 AM, zmoelnig@iem.at wrote:
Quoting "Hans-Christoph Steiner" hans@eds.org:
Yeah, for short commits, that makes sense. Maybe this will encourage people to write good commit logs :). On the other hand, I recently commited a 1 meg .h file that has a giant 3D array filled with data. I cringed thinking that it would be sent as a 1 meg attachment to pd- cvs.
well, probably it is not such a good idea to have 1meg headerfiles in general. afaiu, this was to include WAVs into the binary. a probably better solution would have been to upload the WAVs as WAVs and include the data in the build-process. thus there would have been no 1meg logfile, and WAVs store data more efficiently than .h files.
fgamsdr IOhannes
If it was a WAV, then yes. This is a 3D array of floats:
http://pure-data.svn.sourceforge.net/viewvc/pure-data/trunk/externals/earplu... ~/
.hc
----------------------------------------------------------------------------
"[T]he greatest purveyor of violence in the world today [is] my own government." - Martin Luther King, Jr.
Hans-Christoph Steiner wrote:
If it was a WAV, then yes. This is a 3D array of floats:
http://pure-data.svn.sourceforge.net/viewvc/pure-data/trunk/externals/earplu...
well, this is semantics. the data you are including is a set of HRIRs. to the best of my knowledge HRIRs are usually saved as WAVs (or similar formats, like AIFF), and the bundled into a group by meta-information like filenames, or paths.
of course you can decode the binary WAVs to a a human readable textfile (like earplug_data.txt).
(the comments of earplug_data.txt illustrate what i want to say)
i still think, that the WAVs should be included in the CVS and the earplug_data.txt (or earplug~.h) should be generated from them. you might gain precision with a smaller memory footprint.
but of course, i actually don't really care about it. but i think, such practices are rather bad examples on why we should not have CVS diffs included any more.
fgdam,r IOhannes
On Feb 12, 2009, at 7:01 AM, IOhannes m zmoelnig wrote:
Hans-Christoph Steiner wrote:
If it was a WAV, then yes. This is a 3D array of floats: http://pure-data.svn.sourceforge.net/viewvc/pure-data/trunk/externals/earplu... ~/
well, this is semantics. the data you are including is a set of HRIRs. to the best of my knowledge HRIRs are usually saved as WAVs (or similar formats, like AIFF), and the bundled into a group by meta- information like filenames, or paths.
of course you can decode the binary WAVs to a a human readable textfile (like earplug_data.txt).
(the comments of earplug_data.txt illustrate what i want to say)
i still think, that the WAVs should be included in the CVS and the earplug_data.txt (or earplug~.h) should be generated from them. you might gain precision with a smaller memory footprint.
but of course, i actually don't really care about it. but i think, such practices are rather bad examples on why we should not have CVS diffs included any more.
fgdam,r IOhannes
I was ignorant of all this WAV stuff, I just wanted to make earplug~ work without having to load a textfile. If you think it should be WAV, then by all means convert the code. But I do think that earplug~ should work without having to load a file, whether that file is a .h, .txt, or .wav.
.hc
----------------------------------------------------------------------------
Man has survived hitherto because he was too ignorant to know how to realize his wishes. Now that he can realize them, he must either change them, or perish. -William Carlos Williams
Hans-Christoph Steiner wrote:
I was ignorant of all this WAV stuff, I just wanted to make earplug~ work without having to load a textfile. If you think it should be WAV, then by all means convert the code. But I do think that earplug~ should work without having to load a file, whether that file is a .h, .txt, or .wav.
i think we all agree here :-)
fdmar IOhannes
-
Hans-Christoph Steiner -
IOhannes m zmoelnig -
Mathieu Bouchard -
zmoelnig＠iem.at