Patches item #3312794, was opened at 2011-06-06 22:56 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3312794...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pd-extended Group: None
Status: Closed
Resolution: Accepted Priority: 5 Private: No Submitted By: Albert Graef (agraef) Assigned to: Hans-Christoph Steiner (eighthave) Summary: pd-extended: magic glass not 64 bit clean
Initial Comment: The magicGlass_new and magicGlass_setCanvas functions in g_magicglass.c both take an int parameter c which gets assigned to the x_c member of the t_magicGlass struct. However, in g_canvas.c a t_canvas* is being passed for this parameter, cast to int. This doesn't work on 64 bit systems (or if it does, you're just lucky) because an int is 32 bit and a pointer 64 bit.
Suggested fix: Make x_c a t_glist* and fix up the uses of this member in g_magicglass.c accordingly. Make the c parameter of magicGlass_new and magicGlass_setCanvas a t_glist* as well, and fix up the invocation of magicGlass_new in g_canvas.c accordingly.
I'd also suggest to move the declaration of the t_magicGlass struct into g_magicglass.h. Currently it is replicated in g_magicglass.c and g_canvas.c which is error-prone.
----------------------------------------------------------------------
Comment By: SourceForge Robot (sf-robot)
Date: 2011-06-21 04:20
Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-06-07 03:54
Message: Included in pd-extended.git
----------------------------------------------------------------------
Comment By: Albert Graef (agraef) Date: 2011-06-07 00:13
Message: Attached. This is a git format-patch which should apply cleanly to pure-extended HEAD.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-06-06 23:44
Message: Thanks for the bug report! If you can put together a 'git format-patch' or a 'diff -uw', then I'll include it. Otherwise, it'll have to wait until I have some time to dive into that again.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3312794...
-
SourceForge.net