Hi Guenter, all,
Now we can take a look if our enhancements survived ....
I think they did. I did some work last night to clean up the jsarlo patches and to integrate them with recent changes from Miller. While I was in there, I checked on the possibility of moving them out to command-line options. I just checked them in.
On the CVS devel_0_36 branch, you can find two new command-line options:
-guishadow -- add discrete shadows to basic objects
This is in a fairly good state. I took out my earlier #ifdefs and substituted a pre-existing macro (EXTRAPIX) I think accounted for the difference between Linux and Mac shadow appearance.
-cordcolor [col] -- change color of audio wires, with opt hex #rrggbb spec
This is slightly more "beta" quality. The default color if simply type "-cordcolor" is the dirty yellow you all love. If you prefer a fetching magenta, type "-cordcolor #bb33bb" (or "-cordcolor #b3b", as I just discovered). Currently there is no sanity check for a properly formed color, and strange behavior that I can't control, but have traced back to g_editor.c:103, glist_deselectline. Feel free if you want to tackle it...
The default behavior for all platforms should make Frank happy :) (e.g., no visible change from Miller's 0.36-0 behavior).
adam
Hi, Adam Lindsay hat gesagt: // Adam Lindsay wrote:
-guishadow -- add discrete shadows to basic objects
The shadows work great now, I mean: they're gone!! You made me happy :)
This is in a fairly good state. I took out my earlier #ifdefs andsubstituted a pre-existing macro (EXTRAPIX) I think accounted for the difference between Linux and Mac shadow appearance.
-cordcolor [col] -- change color of audio wires, with opt hex #rrggbb spec
But this one doesn't work here. I always get the old green cords. I didn't look to much into it, but I tried to change s_main.c to include a red color:
strcpy(sys_cordcolor,"#ff0000");
or init it with: char sys_cordcolor[] = "#0000bb";
but I always get the green. I must be doing somthing wrong, maybe an old config somewhere...
ciao
Frank Barknecht said this at Tue, 10 Dec 2002 17:53:33 +0100:
Hi, Adam Lindsay hat gesagt: // Adam Lindsay wrote:
-guishadow -- add discrete shadows to basic objects
The shadows work great now, I mean: they're gone!! You made me happy :)
Glad I could help. :)
But this one doesn't work here. I always get the old green cords. I didn't look to much into it, but I tried to change s_main.c to include a red color:
strcpy(sys_cordcolor,"#ff0000");
or init it with: char sys_cordcolor[] = "#0000bb";
but I always get the green. I must be doing somthing wrong, maybe an old config somewhere...
Oops. Thanks for pointing that out. I believe that bug only showed up when opening pre-existing patches. Sure enough, there was a line that I missed in my changes last night. Here's the change I made:
% diff g_canvas.c.~1.1.1.2.2.4.~ g_canvas.c 858c858 < sys_vgui(".x%x.c create line %d %d %d %d -width 2 -fill #999900 -tags l%x\n", ---
sys_vgui(".x%x.c create line %d %d %d %d -width 2 -fill %s -
tags l%x\n", 860c860,861 < t.tr_lx1, t.tr_ly1, t.tr_lx2, t.tr_ly2, oc); ---
t.tr_lx1, t.tr_ly1, t.tr_lx2, t.tr_ly2, sys_cordcolor, oc);
Still not bug-free, but hopefully it will allow Frank to avoid any sign of color on his screen. :p
Putting it into CVS now...
adam
I believe Joseph A. Sarlo said this around Tue, 10 Dec 2002:
I did some work last night to clean up the jsarlo patches and to integrate them with recent changes from Miller.
Thanks, I was just about to do that.
Cool. I, for one, really appreciate those patches you originated.
And, um, if you're still looking for something to do with them, that glist_deselectline() in g_editor is going to take some serious thought for getting the colored patch cords exactly right. You clearly understand the graphical internals better than I do.
Since doing Paradiddle, I now need to take a closer look at GriPD to see exactly what you've got going on...
Cheers, adam
-- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Adam Lindsay +44(0)1524 594 537 atl@comp.lancs.ac.uk http://www.comp.lancs.ac.uk/computing/users/atl/ -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
-
Adam Lindsay -
Frank Barknecht -
Joseph A. Sarlo