bitwise magic in OSS-backend - Pd-dev

16 Mar 2016


      while running Pd through some static code analysis, i stumbled upon the
following in s_audio_oss.c:322-325
~~~
if ((flags = fcntl(fd, F_GETFL)) < 0)
   post("couldn't get audio device flags");
else if (fcntl(fd, F_SETFL, flags & (!O_NDELAY)) < 0)
   post("couldn't set audio device flags");
~~~
i guess this is meant to put the device into blocking-mode (without
changing other device settings), so Pd could use it as a time-source,
but shouldn't it then read :
    flags & (~O_NDELAY)
i guess the OSS code has not been used for a while, and probably the
'flags' only ever contained the O_NDELAY bit (if any), so it haven't
made much of a difference...
fmads
IOhannes