Patches item #1572310, was opened at 2006-10-06 20:20 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1572310...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update.
Category: puredata Group: None
Status: Open Resolution: Fixed Priority: 2 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: after Save As..., the path remains at the location
Initial Comment:
If you open an instance of an abstraction, then Save As... to somewhere else, the path of that abstraction stays at the original location, even though the file was saved to the new location. Clicking File->Save will then save to the original location rather than the new location.
Tested on Mac OS X with Pd-0.39.2, Pd-0.39.2-extended-test5, and Pd-0.40-0.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2011-06-01 11:31
Message: looking through the sources, the problem is: canvas_rename() calls canvas_reflectttitle() just before the directory is set. so the old directory is shown (reflected)
attached patch (against todays git) reverses the order, so when canvas_reflecttitle() is called, the directory is already set to the new value.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2011-06-01 10:48
Message: confirmed with Pd-vanilla 0.42 (OSX) and 0.43 (linux)
note that as soon as you edit the patch, the path get's updated to show the correct (new) one.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2008-04-28 23:51
Message: Logged In: YES user_id=27104 Originator: YES
Strange, I looked into this. It seems that just the title bar isn't being updated, but the patch does think of itself in the new location. [getdir] will show the new location. It seems that when canvas_rename() is called inside of canvas_savetofile(), the directory is not yet updated, when things get to canvas_reflecttitle(), and therefore canvas_getdir() returns the old location rather than the new one. Since this is now cosmetic, I'll leave it for another day.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2006-10-07 23:49
Message: Logged In: YES user_id=27104
"Save As..." means write out a new file. A new file means a new class. The instance that started this process remains the old class, therefore is no longer related to this new class.
This means its inconsistent to have this instance remain as the original class.
Also, from a usability perspective, it makes things much more coherent. In every other app that I use, when I do "Save As...", that current view changes to the new file. It does not remain on the old file.
----------------------------------------------------------------------
Comment By: Frank Barknecht (fbar) Date: 2006-10-07 13:53
Message: Logged In: YES user_id=569446
I'm note sure if that's a bug, though I agree, that it's confusing. But if you open an instance of an abstraction and save that under a different name, this action doesn't affect the name of the abstraction's instance as it is used in the parent patch: This one will stay the same. If you want to use your newly saved abstraction you need to rename the instance to the new name as well first.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1572310...