Hi devels, while i had to spend some time today fixing things in Mathu's "fixes" i wondered why someone would really need these changes. They have no impact on performance, but rather introduce new bugs as they are obviously untested. Hence, i took the risk and reverted them in the devel cvs, before it's too late and other changes have been superimposed. Nevertheless i posted the changes to the patch tracker so they are saved and can still eventually be considered by the community after some discussion.
I also added the actual patches to the tracker items of the two bugs that Matju found (Matju, you have to check the "upload" box to really upload your patches!!) and re-applied them in devel_0_39
all the best, Thomas
Thomas Grill schrieb:
Am 27.11.2005 um 19:51 schrieb Mathieu Bouchard:
On Sun, 27 Nov 2005, Tim Blechmann wrote:
btw i'm making efforts to "fix" warnings that i get with using "scons wall=1", which turns on "-Wall" in gcc. This is so that new warnings are more easily noticed, and because unused variables make the code more difficult to understand.
well, i once started to work on this, but stopped, after realizing that it makes merging the code _much_ more difficult ... please think about this, before checking it the core ...
Too late, I've checked it into devel_0_39 several hours ago.
Hey all, what i like(d) about the pd-devel branch is that it is/has been still possible to keep up with Miller's improvements to the main branch, without sacrifying too much time with merging. I don't think we should endanger that opportunity by changing the code in a more or less cosmetic fashion. Ok, memory leaks have been found, that's great, how about a general patch --reverse now? I was always sceptical about large-area changes to the code base and am pleased that DesireData has its own sandbox within desire.c and some tcl scripts. As already proposed, since pd-devel is a collaborative project, i would strongly encourage that larger changes to the code are discussed before and have to be supported by some majority of people working on the branch.
best greetings, Thomas
PD-dev mailing list PD-dev@iem.at http://lists.puredata.info/listinfo/pd-dev