Thanks for the reply, don't worry about testing then. I re-read the discussion and checked the newer Portmidi code to confirm the changes we requested are in place, except that LIMIT_RATE is still hard-defined in the sources. I updated the patch to add #ifndef blocks around it so we can still override. It seems as though they did update the logic to detect if the port is an IAC virtual device or not but I think we should continue to disable the rate limit for now. Also, nice to see a number of warnings disappear when building the newer Portmidi on macOS.
On May 15, 2024, at 9:06 AM, cyrille henry ch@chnry.net wrote:
Hello Dan,
I guess you are talking about this : https://github.com/pure-data/pure-data/issues/581
unfortunately, I found the problem on someone else computer. I don't have any mac. So I can't test. (I can test on my linux laptop if needed)
cheers c
Le 15/05/2024 à 00:40, Dan Wilcox a écrit :
Howdy all, I noticed Miller needed to make a change to the portmidi sources and that the update script is out of date as it still uses the old Portmidi Sourceforge SVN link. I have updated the script to now use the active Portmidi Github repo and made a PR: https://github.com/pure-data/pure-data/pull/2305 https://github.com/pure-data/pure-data/pull/2305 As it's late in the release process, I haven't updated the sources themselves yet as I first wanted to check that the macOS midi rate limiting patch is still being applied successfully. This is the only major patch we need to apply for now. @Cyrille: Can you check that this macOS arm64 build sends & receives MIDI ok? I believe you first noticed the issue back around 2018. http://docs.danomatika.com/pdbuilds/0.55/Pd-0.55.0-pm-no-ratelimit.zip http://docs.danomatika.com/pdbuilds/0.55/Pd-0.55.0-pm-no-ratelimit.zip
Dan Wilcox danomatika.com http://danomatika.com robotcowboy.com http://robotcowboy.com
-------- Dan Wilcox danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/