OK, I just merged this, even though it isn't very well tested yet it's almost certainly an improvement - and I need to push it to github to get it compiled for Mac so that I can get Maurice (who first reported this) to try it out. Anyway I fixed a crasher bug I found while working on a big fat patch with lots of data structures in it.
cheers Miller
On 8/6/25 4:08 PM, Benjamin Wesch wrote:
So maybe the name of this menu item is a "Macism"?
yep. see https://urldefense.com/v3/__https://github.com/pure-data/pure-data/blob/mast...
... for this reason, the "HTML Manual..." entry is only added to the help menu for non-macOS or previous TCL versions: https://urldefense.com/v3/__https://github.com/pure-data/pure-data/blob/mast...
i'm not sure whether my new approach is good - so i'd certainly be glad if more eyes could check this. i see 2 options now:
- create only the help menu twice outside the loop (what Roman
tested): https://urldefense.com/v3/__https://github.com/pure-data/pure-data/compare/m... 2. create all these menus twice: https://urldefense.com/v3/__https://github.com/pure-data/pure-data/compare/m...
after burning my fingers here, i'd prefer to let others decide. ;)
... and there's now unfortunately a need for a quick bugfix release based on this mess, i'd be curious if other mac users can reproduce what i reported in https://urldefense.com/v3/__https://github.com/pure-data/pure-data/issues/27...
cheers, ben
On Wed, Aug 6, 2025 at 3:09 PM Roman Haefeli reduzent@gmail.com wrote:
On Wed, 2025-08-06 at 14:42 +0200, Miller Puckette via Pd-dev wrote:
OK, I'll wait until Roman (or anyone else) can verify this fixes it. (Meanwhile I've hit at least one crasher bug when deleting fields from [struct] objects (which sets off a chain of data resizing and relocation) - so I'll probably have something to update in a day or two as well.
I applied this patch¹ to pd_menus.tcl and the menu entry "Pd Help" appeared again and opens the HTML manual in the browser. From what I can tell, this looks good on macOS Sequoia with this patch.
Note: In Linux, the corresponding menu item is named "HTML Manual" which I find is more meaningful than just "Pd Help". Also, on the Mac, all menu items are localized except "Pd Help". I see in the code that macOS is handled differently. So maybe the name of this menu item is a "Macism"?
Roman
¹ https://urldefense.com/v3/__https://github.com/pure-data/pure-data/commit/7e...
pd-dev@lists.iem.at - the Pd developers' mailinglist https://urldefense.com/v3/__https://lists.iem.at/hyperkitty/list/pd-dev@list...
pd-dev@lists.iem.at - the Pd developers' mailinglist https://urldefense.com/v3/__https://lists.iem.at/hyperkitty/list/pd-dev@list...