... one could argue that the previous approach actually *is* cleaner since it only duplicates the menu for macOS and keeps the simple approach of reusing all menus for pdwindow and patch window in all other cases.
if that's preferable, then https://github.com/pure-data/pure-data/compare/master...ben-wes:fix/pdwindow... would be the corresponding fix on master.
cheers, ben
On Thu, Aug 7, 2025 at 8:40 AM Benjamin Wesch benjamin.wesch@gmail.com wrote:
hi,
following up with a bit of embarrassing clarification on that issue: the problem simply was that i didn't use the translation [_ Help], but hardcoded "Help" in eaa3fb53.
so this is not at all connected to setups without dev tools, but simply happening whenever the "Help" menu has a different name, causing the entryconfigure command to fail, i guess (which i used to replace the pdwindow's help menu - and which was not the cleanest approach anyway). i can reproduce the issue on my system after simply switching macOS to German.
so again: sorry for this rather stupid mistake! at least, it seems like we don't need to consider any dev tools state when testing.
cheers, ben
On Wed, Aug 6, 2025 at 9:05 PM IOhannes m zmölnig via Pd-dev pd-dev@lists.iem.at wrote:
Am 6. August 2025 19:43:16 MESZ schrieb "IOhannes m zmölnig via Pd-dev" pd-dev@lists.iem.at:
Am 6. August 2025 17:12:24 MESZ schrieb Miller Puckette via Pd-dev pd-dev@lists.iem.at:
OK, I just merged this, even though it isn't very well tested yet it's almost certainly an improvement - and I need to push it to github to get it compiled for Mac so that
cool. btw, the iem-ci should be back to operational.
obviously the iem-ci is **not** back to normal yet (but git.iem.at is) - the macOS build bot is still out of order.
sorry for the confusion.
mfg.sfg.jfd IOhannes
pd-dev@lists.iem.at - the Pd developers' mailinglist https://lists.iem.at/hyperkitty/list/pd-dev@lists.iem.at/message/2GC522CHKQM...