Patches item #3609350, was opened at 2013-03-28 04:42 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3609350...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: None Priority: 5 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: prevent recursive loading of gui-plugins
Initial Comment: if a gui-plugin loads other plugin, we might easily encounter a recursion (where the plugin tries to load itself). while the current gui-plugin loader mechanism tries to prevent re-loading of the "same" plugin (based on the filename of the plugin), it doesn't catch recursive loading. the attached patch fixes this, by adding the to-be-loaded plugin to the "::loaded_plugins" list, then tries to load it and removes it from the list if the loading fails (rather than adding the plugin to the list after the loading succeeded)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2013-03-28 13:34
Message: I haven't tested this, but the rationale and the patch make sense to me.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig) Date: 2013-03-28 05:15
Message: forgot: the patch also makes "load_plugin_script" return '1' if the plugin script has been successfully loaded, or '0' otherwise.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3609350...