Sorry for the repeated e-mails... here's wat I now thing I should do:
- remove cos_table and COSTABLESIZE from m_pd.h
- if "compatibility" is <= 0.54, make the cosine table 512-point, otherwise 2048-point
I don't see any performance hit on any architecture although I think very old machines will be slowed down by the new table size - but then setting back compatiblity is at least a workaround.
Anyway, since we're about to see changes in Pd's audio output because of differences between MAC ARM and even other ARM implementations (I found that RPI 3 acted exactly like INTEL and differently from MAC M2) I think we're going to now see different outputs on different machines, hopefully usually small ones. So there's no more reason for me to hold on to the old table size at all.
Any objections before I pull the switch?
cheers
Miller
On 5/26/24 6:19 PM, Alexandre Torres Porres wrote:
Em dom., 26 de mai. de 2024 às 11:02, Christof Ressi info@christofressi.com escreveu:
Are there any existing externals that do use cos_table? When in doubt, we could keep the old cos_table around, but deprecate it. In the future we can remove the cos_table symbol, so old externals simply won't load.Cyclone used to have it, but we removed long ago when updating [cycle~]. Old versions still have it of course and 'nilwind' (which is basically an old version of Cyclone) still has it https://github.com/electrickery/pd-nilwind/blob/cf4f468f5585608c997c501cf305... https://urldefense.com/v3/__https://github.com/electrickery/pd-nilwind/blob/cf4f468f5585608c997c501cf3057d45fc2402b9/shared/sickle/sic.c*L69__;Iw!!Mih3wA!EUv21nqXrabdxVCU3iqtXuD70WmtWgewbGfUNbhPX3yx0dyANcb10KOrHUEG7_qvY9VQ0CFttQ$ but can be updated if the idea is to maintain an old version of cylone...
Pd-dev mailing list Pd-dev@lists.iem.at https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!...