Patches item #3596868, was opened at 2012-12-17 03:11 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596868...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata-dev Group: None
Status: Pending Resolution: Rejected
Priority: 5 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: use HAVE_STDINT_H for including stdint.h
Initial Comment: this is a follow-up for commit:5459876b16 that includes stdint.h.
the patch uses HAVE_STDINT_H to include the header, and only uses hand-crafted types as fallbacks (i envision the time when MSCV will be C99 compatible!)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-17 12:04
Message: I don't have a strong opinion on this, but I agree with Miller.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette) Date: 2012-12-17 11:58
Message: I think it's better kept 'MSC_VER" - I don't believe any other compile chain anywhere will fail to supply STDINT, and leaving it MSC_VER marks it clearly as crufty BS that should get cleaned out someday.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596868...