Patches item #1963983, was opened at 2008-05-14 10:36 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1963983...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: None Priority: 6 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: use FILENAME_MAX for all filenames, since its < MAXPDSTRING
Initial Comment: On Windows, FILENAME_MAX is much smaller than MAXPDSTRING, so I replaced MAXPDSTRING with FILENAME_MAX everywhere I could find that is related to filenames. FILENAME_MAX is a POSIX standard macro for defining the max length of a complete filename.
The current situation could result in crashes on Windows.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2010-07-28 17:47
Message: I'm not sure but I don't think Windows should have trouble trying to open files with too-long names -- if it's anything near correct it should simply refuse. And it's better to have as few POSIX dependencies as possible (Pd bios, anyone? :)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2008-05-14 10:47
Message: Logged In: YES user_id=27104 Originator: YES
ok, this time really removed all bits of add_tilde_support_toopen-0.41.4.patch File Added: use_FILENAME_MAX_for_file_operations-0.41.4.patch
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2008-05-14 10:39
Message: Logged In: YES user_id=27104 Originator: YES
oops, removed add_tilde_support_toopen-0.41.4.patch from this one File Added: use_FILENAME_MAX_for_file_operations-0.41.4.patch
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1963983...