Thanks, fixed.

As to teh "clk" confusion, I think I was under the false impression that F8 was a sort of "realtime" message but it's not. Maybe it's better to leave it the way it is, even if it's wrong - I don't know.

cheers Miller

On Mon, Aug 28, 2006 at 03:47:21PM +0200, Thomas Grill wrote:

Hi all, since the SF patch tracker is down i post it here for now. It's already fixed in the devel branch.

First, there's a bug in x_midi.c, preventing the output of the midi status byte from the midirealtime object. Find the fixing diff below.

Second: Midi clock messages are also sent to midirealtime, although there's also a midiclkin object (for midi status F8), which seems to be unused. The respective inmidi_clk function is used nowhere in PD. Is midiclkin supposed to be used one day?

greetings, Thomas

Index: src/x_midi.c

RCS file: /cvsroot/pure-data/pd/src/x_midi.c,v retrieving revision 1.2.8.5 diff -u -w -r1.2.8.5 x_midi.c --- src/x_midi.c 28 Aug 2006 13:25:45 -0000 1.2.8.5 +++ src/x_midi.c 28 Aug 2006 13:38:15 -0000 @@ -639,7 +639,7 @@ t_atom at[2]; SETFLOAT(at, portno); SETFLOAT(at+1, SysMsg);

•    pd_list(midirealtimein_sym->s_thing, &s_list, 1, at);
  

•    pd_list(midirealtimein_sym->s_thing, &s_list, 2, at);
  

  }

}

Thomas Grill http://grrrr.org