Patches item #1833178, was opened at 2007-11-16 09:56 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1833178...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix
Status: Closed Resolution: Out of Date
Priority: 5 Private: No Submitted By: oskude (oskude) Assigned to: Miller Puckette (millerpuckette) Summary: arrow keys update scrollbars
Initial Comment: this patch _always_ updates the scrollbars when moving objects with the arrow keys. a "better" patch would be to only update scrollbars if we are getting bigger than the current canvas size.
and for long shot, maybe we should do this all in canvas_displaceselection anyway...
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-01-01 20:51
Message: This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43 or made irrelevant by it.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2007-11-26 17:46
Message: Logged In: YES user_id=27104 Originator: NO
I added this change as described in my previous comment to branch-0-40-extended.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2007-11-16 13:52
Message: Logged In: YES user_id=27104 Originator: NO
It looks to me that this should definitely be included directly in canvas_displaceselection():
sys_vgui("pdtk_canvas_getscroll .x%lx.c\n", x);
Then this could probably be removed from canvas_mouseup():
if (x->gl_editor->e_onmotion != MA_NONE) sys_vgui("pdtk_canvas_getscroll .x%lx.c\n", x);
My only concern is that this could slow things down on older machines, since it would be running pdtk_canvas_getscroll a low more.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1833178...