On Jul 31, 2017, at 9:51 PM, Alexandre Torres Porres porres@gmail.com wrote:
2017-07-21 6:54 GMT-03:00 Dan Wilcox <danomatika@gmail.com mailto:danomatika@gmail.com>: Ok all, at this point we've nailed most of the bugs and feedback so far. The latest PR is https://github.com/pure-data/pure-data/pull/123 https://github.com/pure-data/pure-data/pull/123
As far as I can tell, the only remaining things which could be done/included for the release are:
Small Stuff
- Remove midiin & sysexin Windows warnings in x_midi.c (& update help file)
Hi, did you mean My Pull Request for removing [midiclkin]? => https://github.com/pure-data/pure-data/pull/79 https://github.com/pure-data/pure-data/pull/79
No. https://github.com/pure-data/pure-data/commit/cad03cde700dc3b756c1c77150a746... https://github.com/pure-data/pure-data/commit/cad03cde700dc3b756c1c77150a746950791a83f
That seems like a small stuff indeed, and it's been sitting there for a while. I wonder if it's being forgotten or if there's something to check/debate on.
I have the feeling [midiclkin] will not be removed and, s IOhannes suggests, it's better to put the help file updates in a different PR.
-------- Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/