Patches item #3079451, was opened at 2010-10-01 14:06 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3079451...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None
Status: Closed
Resolution: Out of Date Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Miller Puckette (millerpuckette) Summary: check for Tcl/Tk 8.6 properly
Initial Comment: Index: configure.in =================================================================== --- configure.in (rvision 14147) +++ configure.in (copie de travail) @@ -149,25 +149,20 @@ # exit -1 fi
-AC_CHECK_LIB(tcl85, main,, - AC_CHECK_LIB(tcl8.5, main,, - AC_CHECK_LIB(tcl84, main,, - AC_CHECK_LIB(tcl8.4, main,, - AC_CHECK_LIB(tcl8.3, main,, - AC_CHECK_LIB(tcl8.2, main,, - AC_CHECK_LIB(tcl8.0, main,, - echo no tcl library found; exit 1))))))) +AC_CHECK_LIB(tcl8.6, main,, AC_CHECK_LIB(tcl86, main,, +AC_CHECK_LIB(tcl8.5, main,, AC_CHECK_LIB(tcl85, main,, +AC_CHECK_LIB(tcl8.4, main,, AC_CHECK_LIB(tcl84, main,, +AC_CHECK_LIB(tcl8.3, main,, +AC_CHECK_LIB(tcl8.2, main,, + echo no tcl library found; exit 1))))))))
-AC_CHECK_LIB(tk85, main,, - AC_CHECK_LIB(tk8.5, main,, - AC_CHECK_LIB(tk84, main,, - AC_CHECK_LIB(tk8.4, main,, - AC_CHECK_LIB(tk8.3, main,, - AC_CHECK_LIB(tk8.2, main,, - AC_CHECK_LIB(tk8.0, main,, - echo no tk library found; exit 1))))))) +AC_CHECK_LIB(tk8.6, main,, AC_CHECK_LIB(tk86, main,, +AC_CHECK_LIB(tk8.5, main,, AC_CHECK_LIB(tk85, main,, +AC_CHECK_LIB(tk8.4, main,, AC_CHECK_LIB(tk84, main,, +AC_CHECK_LIB(tk8.3, main,, +AC_CHECK_LIB(tk8.2, main,, + echo no tk library found; exit 1))))))))
- if test x$tk != "xno"; then GUISRC="t_main.c t_tkcmd.c" else
----------------------------------------------------------------------
Comment By: SourceForge Robot (sf-robot)
Date: 2010-10-19 10:20
Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2010-10-05 10:06
Message: but even if then, the fixes are void, as even with miller's oldschool build-system there is no more use to link against tcl/tk!
so a patch addressing the issues of tcl/tk checks, should simply remove them.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2010-10-05 09:47
Message: I think only Miller is maintaining the old build system in pd/src/configure.in, so I am assigning this to him.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2010-10-05 08:44
Message: there are 2 independent configure scripts; the one in src/ is legacy and includes obsolete checks for tcl (and is still used by miller). the new one is directly in /pd/ and does not include checks.
the old configure-system (that does the checks) has never been used to build on w32. instead makefile.nt (miller) and makefile.mingw (pdx) have been used,
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody) Date: 2010-10-04 19:00
Message: i have Pd-0.43-0test2, it STILL contains this check in configure.in... and makefile.in still assigns @LIBS@ to GLIB, and $(GLIB) is still used in making pdtcl.dll. (why?)
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig) Date: 2010-10-01 20:02
Message: the upcoming Pd-0.43 and all releases thereafter will not have this configure check anymore, since it will ship with a self contained tcl/tk script, rendering this patch obsolete.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3079451...