I agree that there should only be one set of levels, that would just mean removing the "+4" from two places, and it would be that way. Tomorrow morning I can complete a patch for 0.43 based on a tested and debugged version of all this that I have mostly in the pd-extended.git patch_series branch with some bug fixes that are currently only on my machine. It makes the Pd window log much more usable and has little risk as I see it, so I think is worth including.
Other than that, yes, let's release 0.43!
hc
On Mar 9, 2011, at 12:32 AM, Miller Puckette wrote:
Hi all,
Sorry to reopen this old thread -- I think there's a more recent message from HC but I can't find it right now.
I wonder if, in the interest of putting 0.43 out, we should just hide the verbosity level control and let all printout through for 0.43, then try to figure out how to do this correctly for 0.44. I'm worried that the verbosity level and the "verbose" flag (in the search path menu) aren't coordinated. and I think they really should be. We would need to figure out whether verbosity can just be a level or should be a bitfield (file open attempts, warnings, blah blah). Also, the filtering almost certainly should be done down in Pd, not in the Tcl code, unless there's a significant amount of printout coming from the Tcl layer which I think there isn't.
I still need to test Pd on a couple more hardware/software combinations, but would dearly love to get the damn thing done so I can start working on some things I'm delaying for 0.44.
thanks Miller
On Wed, Feb 23, 2011 at 05:50:56PM -0500, Hans-Christoph Steiner wrote:
On Feb 23, 2011, at 5:38 AM, IOhannes m zmoelnig wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 2011-02-23 09:05, IOhannes m zmoelnig wrote:
On 2011-02-22 23:26, Hans-Christoph Steiner wrote:
This would be very nice, I could see being about to double-click any line in the log and have it pop up which object made the log message. I won't have time to implement this in the foreseeable future.
well, the thing is that for now we only have to reserve an additional variable "objectID" for the logpost(), which could be NULL/empty.
logpost(objectID, level, msg,...)
then, time permitting, fill in the missing code on both the C and the tcl side.
i only try to avoid re-defining functions in each release.
anyhow, here is a draft for how this would work (to be applied on top of pd-extended.git#fac011b1)
apart from changing the logpost() functions, it also adds a new global method to Pd that allows for selecting/highlighting an object based on a symbolic representation of it's address.
like alway, most work was spent in trying to figure out things in tcl :-)
Now I'm starting to think that these would be appropriate levels, and use both the number and the name for the Log menu:
0 fatal 1 error 2 normal 3 info ALL
.hc
As we enjoy great advantages from inventions of others, we should be glad of an opportunity to serve others by any invention of ours; and this we should do freely and generously. - Benjamin Franklin
Pd-dev mailing list Pd-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
----------------------------------------------------------------------------
"A cellphone to me is just an opportunity to be irritated wherever you are." - Linus Torvalds