Hi again --
I looked all over and still can't find it... maybe git isn't really sending them???
I think from my standpoint either the e-mail or SF patch tracker works fine.
About the race condition itself... the problem seems to be that there's no way to keep other Pd TK commands to get interpreted right after the pdtk_pd_startup, which migth depend on various stuff in the GUI having been initialized. I think the best way is to put the initialization stuff:
::pd_bindings::class_bindings ::pd_bindings::global_bindings ::pdtk_canvas::create_popup ::pdwindow::create_window ::pd_menus::create_menubar ::pd_menus::configure_for_pdwindow
inside pdtk_pd_startup. I'm worried about the lines:
load_startup_plugins open_filestoopen
which might depend on the path being set -- I don't think the "vwait" there works either, but the fix will be more complicated (but of course maybe your patch already addresses that, once I see it :)
M
"msp[]ucsd_edu" literally (instead of msp@ucsd.edu
On Tue, Jul 13, 2010 at 08:56:31AM +0200, IOhannes m zmoelnig wrote:
On 2010-07-13 02:40, Miller Puckette wrote:
Hi Hannes --
I didn't see the "[PATCH] only add window-bindings ..." - is it on Source- forge or somewhere else?
no, i used "git format-patch" and "git send-email" to send a number of patchsets to msp[]ucsd_edu (the address you used for committing to git). you should be able to apply them using "git am"
by now, i have about 7 changesets lying around on my harddisk. some of them are fixing race-conditions (like the one originally mentioned, but also a more severe one with the list of APIs), trying to get in patches used in the original Debian packages (some ifdefs for Debian/Hurd and Debian/kFreeBSD) and some small fixes.
so, in order to safe you from as much work as possible, what would be the best way to send you these patches?
- use "git send-email" but with an email-address you are actually using?
- commit patches to the sourceforge git repository, so you can pull them
and then "git cherry-pick" them into your final versioin?
- use the sourceforge tracker?
you choose.
fgmasdr IOhannes
Pd-dev mailing list Pd-dev@iem.at http://lists.puredata.info/listinfo/pd-dev