Let me forward here to this list my communication with Shahrokh. I thought I'd write him directly about these issues and he quickly replied to say he's gonna work on it, so I wanted to let people know things are moving and that we're on it.
---------- Forwarded message --------- De: Alexandre Torres Porres porres@gmail.com Date: ter., 20 de ago. de 2024 às 21:11 Subject: Re: [expr] updates for Pd 0.55-1 To: Shahrokh Yadegari sdy@ucsd.edu
Em ter., 20 de ago. de 2024 às 19:54, Shahrokh Yadegari sdy@ucsd.edu escreveu:
Dear Alexandre,
Thank you for your email and reporting the bugs that you have found! I will address them as soon as I can (hopefully in the next few days).
Yay!
Some of them are kind of features like the spaces before the symbol itself in output of symboln(), but if that is not clear to you, perhaps I should change the API.
hmm, ok, I think I get it now, but, well, yeah, I think it makes better sense to not put the extra missing characters as spaces in the beginning.
I worked on the array[$v#] implementation, but many interpolation issues came up (some related to backward compatibility) and I decided to leave that for the next release. I wanted to get the symbol processing changes out asap.
I see. Even if we leave it for later, I think we can discuss what we expect for the signal input and interpolation. I was discussing that on the PR I opened.
Please stay tuned for a more complete email and please keep the bugs coming!
Ok, let's kinda focus on bugs and let me filter them out a bit and describe them more. I will leave the signal support for index aside for now.
This is one we're already discussing https://github.com/pure-data/pure-data/issues/2399
This is a simple and classic bug for heap corruption / memory leaks that you can have a look at https://github.com/pure-data/pure-data/issues/531
And here's another clear bug https://github.com/pure-data/pure-data/issues/402 but it seems this is more about how Pd deals with string handling, which escapes some of the special characters, so maybe a job for IOhannes in the develop branch.
For last, this feels to me like a bug as well https://github.com/pure-data/pure-data/issues/2398
The rest is more like feature requests, and I'll focus on this one that aims to allow symbol inputs to be treated as variables, seems like a good feature to be part of the whole symbol support update that we're focusing on https://github.com/pure-data/pure-data/issues/2400
And another related feature request would be expanding [value] to also take symbols so we can make use of the inside [expr], but more about [value] than [expr], I guess that a PR and a commit for this one could be done once we're through with symbol support and other bugs.
Cheers
Cheers, Shahrokh
On Tue, Aug 20, 2024 at 2:25 PM Alexandre Torres Porres porres@gmail.com wrote:
Hi again, I've been creating new issues, new PRs and writing comments in 'expr' related issues and PRs. To organize things, I created a new 'expr' label for issues and PRs. Here are them all https://github.com/pure-data/pure-data/labels/expr https://urldefense.com/v3/__https://github.com/pure-data/pure-data/labels/expr__;!!Mih3wA!Em8VTuW7HdeNM2CSOJFad7RmuHN-g07GrXnZ7z5i0FhjjUS3-Jr_oOF7qYJF1FQw78Y2zdxE-JXfhC4$
There are more expr related issues and PRs but these are the ones I thought it was worth tagging for now, being more important and relevant while we're making changes to 'expr'. Not that I also think ALL of them should be taken care of right now...
cheers
Em ter., 20 de ago. de 2024 às 14:26, Alexandre Torres Porres < porres@gmail.com> escreveu:
Hi Sharok Yadegari, how are you?
I see Miller just merged an update of the [expr] family of objects and it's really exciting to have support for symbols in [expr] now.
I was writing about this in the pd-dev list and I'm not if you are there or following it, so I thought I'd just write to you directly.
Since the expr 0.58 version is not official out yet, we can maybe work out some bugs to make it into this update.
I just came across this bug for instance https://github.com/pure-data/pure-data/issues/2398 https://urldefense.com/v3/__https://github.com/pure-data/pure-data/issues/2398__;!!Mih3wA!Em8VTuW7HdeNM2CSOJFad7RmuHN-g07GrXnZ7z5i0FhjjUS3-Jr_oOF7qYJF1FQw78Y2zdxEzRXfvCE$ I also see that the update notes within the expr code mentions *" fixed the expr~ array[0] "bug"* and I wonder what bug that was... when trying to test it is when I came across this bug I reported...
Also, this may seem like a 'feature', but it seems to me is just how things should work intuitively, which is being able to set an array index with audio signals, see https://github.com/pure-data/pure-data/issues/719 https://urldefense.com/v3/__https://github.com/pure-data/pure-data/issues/719__;!!Mih3wA!Em8VTuW7HdeNM2CSOJFad7RmuHN-g07GrXnZ7z5i0FhjjUS3-Jr_oOF7qYJF1FQw78Y2zdxEmVkdiPQ$ and there's already a PR for that https://github.com/pure-data/pure-data/pull/853 https://urldefense.com/v3/__https://github.com/pure-data/pure-data/pull/853__;!!Mih3wA!Em8VTuW7HdeNM2CSOJFad7RmuHN-g07GrXnZ7z5i0FhjjUS3-Jr_oOF7qYJF1FQw78Y2zdxEMLHJl2w$ maybe you as the author can revise this and work on it yourself on top of the new code.
As for the new string functions, I opened this issue https://github.com/pure-data/pure-data/issues/2399 https://urldefense.com/v3/__https://github.com/pure-data/pure-data/issues/2399__;!!Mih3wA!Em8VTuW7HdeNM2CSOJFad7RmuHN-g07GrXnZ7z5i0FhjjUS3-Jr_oOF7qYJF1FQw78Y2zdxEeswcH9Y$
And I would also like to support value names in [expr] with symbols input, so I opened this https://github.com/pure-data/pure-data/issues/2400 https://urldefense.com/v3/__https://github.com/pure-data/pure-data/issues/2400__;!!Mih3wA!Em8VTuW7HdeNM2CSOJFad7RmuHN-g07GrXnZ7z5i0FhjjUS3-Jr_oOF7qYJF1FQw78Y2zdxEhtbo6MI$
What do you think about these issues and requests?
I could try and work on a PR that takes care of it all and send it to you for revision.
cheers
ps. I hear Miller say you were also planning on supporting multichannel connections in [expr~]/[fexpr~], that'd be great, but I assume this could take a while and be a reality in the version 0.59?
-- Shahrokh Yadegari Professor, Music Department Associate Director, Qualcomm Institute Director, Sonic Arts R&D and IDEAS, QI University of California, San Diego Email: sdy@ucsd.edu Web: http://yadegari.org
Em ter., 20 de ago. de 2024 às 18:22, Alexandre Torres Porres < porres@gmail.com> escreveu:
I have been creating new issues, new PRs and writing comments in 'expr' related issues and PRs. to organize things, I created a new 'expr' label for issues and PRs.
Here are them all https://github.com/pure-data/pure-data/labels/expr
there are more expr related issues and PRs but these are the ones I thought it was worth tagging for now.
Em ter., 20 de ago. de 2024 às 01:39, Alexandre Torres Porres < porres@gmail.com> escreveu:
Hi, I see you merged doc updates and develop, thanks! Seems that a test release might be coming up soon!
Now, I also see that we have a nice surprise with new features in [expr] for string manipulations! Awesome!
In this context, I think we should enjoy the opportunity and also work on some bugs in expr. I just came across this bug for instance https://github.com/pure-data/pure-data/issues/2398 I also see that the update notes within the expr code mentions *" fixed the expr~ array[0] "bug"* and I wonder what bug that was... when trying to test it is when I came across this bug I reported...
Also, this may seem like a 'feature', but it seems to me is just how things should work intuitively, which is being able to set an array index with audio signals, see https://github.com/pure-data/pure-data/issues/719 and there's already a PR for that https://github.com/pure-data/pure-data/pull/853
And string support in [expr] may also call for support for symbols in [value] and we also have PRs for that, see https://github.com/pure-data/pure-data/pull/817
cheers
Em sex., 19 de jul. de 2024 às 13:40, Miller Puckette < mpuckette@cloud.ucsd.edu> escreveu:
To Pd Dev -
What do you think, is it time to put 0.55-1 out?
If I don't hear any objections I'll stick out a "test" one Saturday, and maybe the real one in a week or so.
cheers
M
Pd-dev mailing list Pd-dev@lists.iem.at https://lists.puredata.info/listinfo/pd-dev