On 08.08.2025 10:13, Miller Puckette via Pd-dev wrote:
I'm happy to merge this but just FWIW I think it's wrong to just take out 'EXTERN' since without it the code works differently on some platforms compared to others. Perhaps for a future release there could be a macro PRIVATE which becomes 'static' unless PD_INTERNAL is defined (which a foolish extern writer _could_ define but then they'd be creating their own problems :)
Again, why would you tag a *private* function as EXTERN in the first place? EXTERN is a macro for *exporting* a function from the Pd binary so that Pd externals can use it. (I guess the better name would have been PD_EXPORT all along.)
If you just want to make a forward declaration, there is no need for EXTERN at all because functions have extern linkage by default. Just have a look at "s_stuff.h": some functions are marked EXTERN, but others are not.
The issue is just that Linux and macOS export all functions by default, but this can be simply solved by compiling with "-fvisiblity=hidden". See https://github.com/pure-data/pure-data/issues/569. (Linux and macOS really got the defaults wrong in this case.)
Cheers,
Christof
cheers M
On 8/7/25 9:12 PM, IOhannes m zmölnig via Pd-dev wrote:
hi
a couple of things:
- it seems that miller tagged a new release, but apparently some
numbers were swapped (or i'm having this sleepy hollow moment) as the tag reads "0.65-1test1" (rather than "0.56-1test1") i can delete the tag, but i'd rather have miller do the correct tagging.
before tagging, please consider the following though:
- i've pushed a few small changes to the `develop` branch, that I
would like to see in the bugfix release: very minor things, like fixing the screenshot image URL (required for the flatpak packages), and making a new symbol private that shouldn't have been public anyhow https://github.com/pure-data/pure-data/pull/2721
- practically all translations have been touched as well (not that
three were any significant change sto the actual translations though) https://github.com/pure-data/pure-data/pull/2722
fmasr IOhannes
--- pd-dev@lists.iem.at - the Pd developers' mailinglist https://lists.iem.at/hyperkitty/list/pd-dev@lists.iem.at/message/YDHOU42AQ42...
pd-dev@lists.iem.at - the Pd developers' mailinglist https://lists.iem.at/hyperkitty/list/pd-dev@lists.iem.at/message/OSXQHND3K7O...