So perhaps I should someday get rid of s_audio_paring.c and fix the portaudio code to talk to z_ringbuffer.c which seems to be more up to date.
On 4/12/24 01:23, Dan Wilcox wrote:
It's the implementation used by libpd for passing messages between the audio thread to the various hooks. It is also used in the libpd Obj-C PdAudioUnit for buffering samples sample rate conversion is happening and the buffer size is inconsistent. If it was broken in some way, we would have heard about it over the last 10+ years or so. I trust the guy who wrote it (Peter Brinkmann) but it is admittedly older code now and I only updated to C atomics in a cursory manner via the macros. If y'all have thoughts/suggestions on improvement, please open an issue (or better a PR) on the libpd Github repo.
On Apr 11, 2024, at 12:00 PM, pd-dev-request@lists.iem.at wrote:
As an aside: is the code in z_ringbuffer.{c,h} considered trustworthy? I note that the other code in PD appears to use the sys_ringbuffer* API, which seems to be built on the PA ringbuffer. I ask because I had some problems with z_ringbuffer.c and after a code read, there are some bits which look sketchy enough to me that I decided to stop using it.
Dan Wilcox danomatika.com https://urldefense.com/v3/__http://danomatika.com__;!!Mih3wA!C-m1mpLMe6r1rI9wq21cosGkbVC_gPEKQ5fp-JpWyBFARWP_v40n-5_1ho0nXQL3_wLPdu3FST-HG_o$ robotcowboy.com https://urldefense.com/v3/__http://robotcowboy.com__;!!Mih3wA!C-m1mpLMe6r1rI9wq21cosGkbVC_gPEKQ5fp-JpWyBFARWP_v40n-5_1ho0nXQL3_wLPdu3FOZuwvuE$
Pd-dev mailing list Pd-dev@lists.iem.at https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!...