Patches item #1230498, was opened at 2005-06-30 19:50
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1230498&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: crash on saving changed iem-guis in subpatchers
Initial Comment:
as described by t.grill, the "numberbox2" (from the
iemguis) crashes pd, when an abstraction is saved,
where there is an active nbx2 in a closed subpatch.
attached is a patch against 0.38-4 that resolves this
issue.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-16 02:26
Message:
Logged In: YES
user_id=313747
applied (should already be in CVS main)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1230498&group_…
Patches item #1224768, was opened at 2005-06-21 11:57
Message generated for change (Comment added) made by timblech
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224768&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: checks for NULL-pointers in g_rtext.c & g_graph.c
Initial Comment:
most funtions in g_rtext.c do not check whether a
passed pointer is non-zero and thus crash with
NULL-pointers.
the added patch performs these checks.
is this a performance hog ???
this should fix BUG-1186531 (which i wasn't able to
reproduce at all)
----------------------------------------------------------------------
>Comment By: Tim Blechmann (timblech)
Date: 2005-07-16 11:52
Message:
Logged In: YES
user_id=326084
what about asserts?
i think, this is, what they are for ... tim
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-16 02:32
Message:
Logged In: YES
user_id=313747
I think that adding speculative checks for NULL pointers
will delay
Pd crashing but whatever the problem was will manifest
itself some
other way later (and be even harder to reproduce and fix)...
so for now
I'd like to leave it so that it crashes right away if this
ever happens...
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2005-06-30 20:27
Message:
Logged In: YES
user_id=564396
the same for g_graph.c
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224768&group_…
Patches item #1214164, was opened at 2005-06-03 03:48
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1214164&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Nobody/Anonymous (nobody)
Summary: route bug with zero-length lists ("bang") in float-mode
Initial Comment:
when sending a "bang" message [route] in float-mode
(e.g. [route 1 2]), the bang will silently vanish.
i think this is due to the fact, that now "bang"s are
equal to zero-length-lists which are discarded by the
route_list-method in float-mode.
anyhow, the attached patch (against pd-0.38-4) will
send the "bang" to the reject-outlet
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-15 18:17
Message:
Logged In: YES
user_id=313747
Sounds right... so I took it...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1214164&group_…
Patches item #1214166, was opened at 2005-06-03 03:51
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1214166&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Nobody/Anonymous (nobody)
Summary: complaining about [route] with mixed-type arguments
Initial Comment:
quoting the reference-patch of [route]:
"Route checks the first element of a message against
each of its
arguments, which may be numbers or symbols (but not a
mixture of the two.)"
however, creating [route 5 bla] is possible and no
hints are given that this is illegal.
attached is a patch that checks the creation arguments,
and if they are illegal, no object will be created
(with some verbosity, so the user knows what went wrong)
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-15 18:02
Message:
Logged In: YES
user_id=313747
OK... I fixed it slightly differently though.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1214166&group_…
Patches item #1217759, was opened at 2005-06-09 13:20
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1217759&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 7
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Nobody/Anonymous (nobody)
Summary: small font/display change
Initial Comment:
I would like to propose a minor font change to make
text more readable. First, in the console, make the
text regular rather than bold. Usually regular fonts
are used in terminal windows and bold is only for
highlights.
-text .printout.text -relief raised -bd 2 -font
-*-courier-bold--normal--12-* +text .printout.text -relief raised -bd 2 -font
-*-courier-regular--normal--12-*
Secondly, courier is not a font meant for reading text,
but rather terminals and things like that. So I
propose changing the default font in text windows (not
used very often) to Times Regular 14 point.
- text $name.text -relief raised -bd 2 -font
-*-courier-bold--normal--12-* + text $name.text -relief raised -bd 2 -font
-*-times-regular--normal--14-*
Attached is a diff patch file. This should work on all
platforms since those fonts are already used within Pd.
Lastly is a Mac OS X only change: setting minimun
line size for anti-aliasing. If set to 1 or 0, then
every line will be anti-aliased. While this makes
connections and circles in [bng] and such look really
good, it makes boxes and messages look out of focus.
Setting this to 2 makes it so only the thick audio rate
connections are anti-aliased
+ set tk::mac::CGAntialiasLimit 2
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-15 17:54
Message:
Logged In: YES
user_id=313747
Took the Helvetica and antialiasing patches... left the
console in bold for
now because normal is less legible on linux. Perhaps this
should be set
platform-dependently.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1217759&group_…
Patches item #1217783, was opened at 2005-06-09 13:54
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1217783&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: Frank Barknecht (fbar)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix font in pdtk_data_dialog
Initial Comment:
This patch fixes a tiny typo in pdtk_data_dialog where
the wrong font is used because of a missing dollar sign.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-15 17:35
Message:
Logged In: YES
user_id=313747
taken (although I couldn't find the patch itself, the
comment was enough to
figure it out.)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1217783&group_…
Patches item #1224768, was opened at 2005-06-21 02:57
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224768&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: checks for NULL-pointers in g_rtext.c & g_graph.c
Initial Comment:
most funtions in g_rtext.c do not check whether a
passed pointer is non-zero and thus crash with
NULL-pointers.
the added patch performs these checks.
is this a performance hog ???
this should fix BUG-1186531 (which i wasn't able to
reproduce at all)
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-15 17:32
Message:
Logged In: YES
user_id=313747
I think that adding speculative checks for NULL pointers
will delay
Pd crashing but whatever the problem was will manifest
itself some
other way later (and be even harder to reproduce and fix)...
so for now
I'd like to leave it so that it crashes right away if this
ever happens...
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2005-06-30 11:27
Message:
Logged In: YES
user_id=564396
the same for g_graph.c
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224768&group_…
Patches item #1228872, was opened at 2005-06-28 02:12
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1228872&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix verbosity of iemgui's when changing send/receive-names
Initial Comment:
you can set the send/receive-names of the iemgui_s with
messages.
however, somebody has added some debugging output into
the code that does change the send-name, resulting in
following output to the console:
"send: before [newname], after [newname]"
while this does not affect the functionality, it fills
the console with messages that do not provide any realy
functionality.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-15 17:28
Message:
Logged In: YES
user_id=313747
That was my fault. Fixed now. -msp
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2005-06-28 02:14
Message:
Logged In: YES
user_id=564396
assigned to msp
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1228872&group_…
Patches item #1230498, was opened at 2005-06-30 10:50
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1230498&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: crash on saving changed iem-guis in subpatchers
Initial Comment:
as described by t.grill, the "numberbox2" (from the
iemguis) crashes pd, when an abstraction is saved,
where there is an active nbx2 in a closed subpatch.
attached is a patch against 0.38-4 that resolves this
issue.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-15 17:26
Message:
Logged In: YES
user_id=313747
applied (should already be in CVS main)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1230498&group_…
Patches item #1224730, was opened at 2005-06-21 02:04
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224730&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: pdsend bug with long(>127) sendbuffers
Initial Comment:
in pdsend the length of the buffer is limited to 4096
chars.
however, in the send-routine, the buffer-length is
evaluated into a variable of type "char";
this prohibits the sending of buffers where
(char)strlen(buf)<0 (easy to reach, when working with
buffers longer than 127 chars)
this behaviour appears in all versions of pd<=0.38-4 (i
guess)
attached is a patch that uses "unsigned int" for the
length instead of "char"
NOTE: i guess the correct type should rather be "size_t"
NOTE: i think pdsend/netsend (and pdreceive/netreceive)
should really use the same code rather than 2 separate
copies.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-07-15 17:22
Message:
Logged In: YES
user_id=313747
Wow, that was stupid of me. Thanks for catching it. To
appear next CVS commit.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1224730&group_…