Patches item #1368484, was opened at 2005-11-28 10:35
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1368484&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Submitted By: Mathieu Bouchard (matju)
Assigned to: Nobody/Anonymous (nobody)
Summary: [poly] memory leak
Initial Comment:
fixed [poly] memory leak
removed unused vars
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-12-31 11:50
Message:
Logged In: YES
user_id=313747
Took for 0.40
----------------------------------------------------------------------
Comment By: Thomas Grill (xovo)
Date: 2005-11-30 05:46
Message:
Logged In: YES
user_id=350252
here's the missing patch:
Index: x_midi.c
===================================================================
RCS file: /cvsroot/pure-data/pd/src/x_midi.c,v
retrieving revision 1.2.8.3
diff -u -r1.2.8.3 x_midi.c
--- x_midi.c 30 Nov 2005 13:36:58 -0000 1.2.8.3
+++ x_midi.c 30 Nov 2005 13:44:24 -0000
@@ -1187,7 +1187,7 @@
static void poly_setup(void)
{
poly_class = class_new(gensym("poly"),
- (t_newmethod)poly_new, (t_method)poly_clear,
+ (t_newmethod)poly_new, (t_method)poly_free,
sizeof(t_poly), 0, A_DEFFLOAT, A_DEFFLOAT, 0);
class_addfloat(poly_class, poly_float);
class_addmethod(poly_class, (t_method)poly_stop,
gensym("stop"), 0);
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1368484&group_…
Patches item #1070226, was opened at 2004-11-20 17:13
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1070226&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: carmen rocco (ix9)
Assigned to: Nobody/Anonymous (nobody)
Summary: win32/GCC fixes
Initial Comment:
* various #defines intended to reduce warnings in MSVC
create warnings in GCC
* catch stuff in s_entry and dllexport stuff in m_pd is
unnecessary/broken with GCC
* couldnt find TCL/wish.exe if in system PATH
* .pdrc wasnt being read on windows, where it is called
pd.ini and can be located in pd/ or ~/ (portions from
timblechmann & matju, includes previous "comments in rc
file" patch
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2005-12-31 03:47
Message:
Logged In: YES
user_id=27104
this is now old, and some of the changes have been
incorporated in other patchs.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2005-05-18 00:41
Message:
Logged In: YES
user_id=313747
I'm not sure what to do with "pd.ini" since I'm trying to phase
out "pdrc" already. I could take the other changes, but
have taken
so many other patches today I'm afraid of dropping a patch
in halfway.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1070226&group_…
Patches item #1217414, was opened at 2005-06-09 02:27
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1217414&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 3
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: change defines MACOSX to __APPLE__
Initial Comment:
gcc defines __APPLE__ automatically on Mac OS X so
there is no need for the -DMACOSX, #ifdef MACOSX, etc
This patch just changes every relevant instance of
MACOSX to __APPLE__ and removes -DMACOSX in configure.in.
This does not change the functionality at all, but
cleans up the code, using standard constructs, and
makes things consistent with __linux__ and __FreeBSD__.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2005-12-31 03:42
Message:
Logged In: YES
user_id=27104
FYI: I've been using this sed script as part of the
Pd-extended builds and so far no problems.
Also, the Win32 platform does have a common macro, its
_WIN32 (not WIN32 like I previously mentioned, tho WIN32
seems to work most of the time).
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2005-12-02 13:23
Message:
Logged In: YES
user_id=27104
Rather than a patch, its much easier to just run this sed
command:
sed -i.bak 's/MACOSX/__APPLE__/g' *.[ch]
This will only replace #ifdefs and comments, it won't affect
any code. These leaves -DMACOSX in the makefile for legacy
support.
On Windows, MSVC, Cygwin, and MinGW use WIN32 and the
automatic platform define. But the sed replacement isn't as
straightforward.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2005-09-30 09:00
Message:
Logged In: YES
user_id=564396
assigned to miller.
its oh so bad, that w32 doesn't really have such an
automatic define.
(mingw does define __WIN32__; probably it would be good to
add that one to the NT/MSW magic in m_pd.h)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2005-06-09 14:10
Message:
Logged In: YES
user_id=27104
For Apple documentation on this topic, check out the
"Predefined Macros" section of this webpage:
http://developer.apple.com/technotes/tn2002/tn2071.html
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1217414&group_…
Patches item #1371497, was opened at 2005-12-02 01:59
Message generated for change (Settings changed) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1371497&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 7
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: tiny fix on optional MacOS X/Jack
Initial Comment:
This patch has no effect unless Pd is compiled with
--enable-jack on Mac OS X. It will not affect any
other kind of build. This patch makes the Jack
dependency optional. Apple calls it "weak libraries",
aka "soft imports".
Here's the very simple patch:
--- configure.in 16 Aug 2005 04:06:28 -0000
1.15
+++ configure.in 2 Dec 2005 06:56:30 -0000
@@ -316,11 +316,11 @@
EXTERNTARGET=pd_darwin
if test x$jack == "xyes";
then
- LDFLAGS=$LDFLAGS" -framework Jack"
+ LDFLAGS=$LDFLAGS" -weak_framework Jack"
fi
if test x$jack == "xrun";
then
- LDFLAGS=$LDFLAGS" -framework Jack"
+ LDFLAGS=$LDFLAGS" -weak_framework Jack"
fi
fi
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2005-12-31 00:36
Message:
Logged In: YES
user_id=313747
OK, will drop this in. I'm curious how Pd will avoid
crashing when asked to use jack when it isn't there - will
put it on my dolist to try to test this someday.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1371497&group_…
Patches item #1371467, was opened at 2005-12-01 21:26
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1371467&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: backwards compatible makefile.in cleanup
Initial Comment:
I cleaned up makefile.in so that it follows the GNU
standards for configure variables. Plus I added a
couple variables which allows the install target to
work properly across platforms.
This has the added benefit of making it easier to
compile Pd from the Pd-extended build system.
Tested on Pd-0.38.3 and 0.38.4 on all platforms and
applies cleanly to the HEAD of pd in CVS.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-12-30 22:09
Message:
Logged In: YES
user_id=313747
Took for 0.40
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1371467&group_…
Patches item #1371478, was opened at 2005-12-01 21:55
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1371478&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: Minor define fix for MinGW
Initial Comment:
MinGW doesn't use the #pragmas that MSVC does, and
throws a warning. Changing #ifdef NT to #ifdef
_MSC_VER will make sure that the #pragmas are only used
with compiling with MSVC and not MinGW or Cygwin.
This patch is part of the Pd-0.38.4-extended builds and
applies cleanly to .38.x and CVS HEAD in combination
with all of the patches that I am currently using (in
CVS at packages/patches).
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-12-30 21:41
Message:
Logged In: YES
user_id=313747
took for 0.40
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1371478&group_…
Patches item #1371497, was opened at 2005-12-01 22:59
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1371497&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: tiny fix on optional MacOS X/Jack
Initial Comment:
This patch has no effect unless Pd is compiled with
--enable-jack on Mac OS X. It will not affect any
other kind of build. This patch makes the Jack
dependency optional. Apple calls it "weak libraries",
aka "soft imports".
Here's the very simple patch:
--- configure.in 16 Aug 2005 04:06:28 -0000
1.15
+++ configure.in 2 Dec 2005 06:56:30 -0000
@@ -316,11 +316,11 @@
EXTERNTARGET=pd_darwin
if test x$jack == "xyes";
then
- LDFLAGS=$LDFLAGS" -framework Jack"
+ LDFLAGS=$LDFLAGS" -weak_framework Jack"
fi
if test x$jack == "xrun";
then
- LDFLAGS=$LDFLAGS" -framework Jack"
+ LDFLAGS=$LDFLAGS" -weak_framework Jack"
fi
fi
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-12-30 21:36
Message:
Logged In: YES
user_id=313747
OK, will drop this in. I'm curious how Pd will avoid
crashing when asked to use jack when it isn't there - will
put it on my dolist to try to test this someday.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1371497&group_…
Patches item #1378927, was opened at 2005-12-12 10:37
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1378927&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Submitted By: Thomas Grill (xovo)
Assigned to: Nobody/Anonymous (nobody)
Summary: OSX/pd 0.39: fix for loading externals using static libs
Initial Comment:
Hi all,
unlike with pd 0.38, externals that share equal symbol names (like
when they have been compiled using the same static lib) won't get
loaded, but rather bail out with a "linker error".
This can be easily fixed by including the
NSLINKMODULE_OPTION_PRIVATE option in s_loader.c
ret = NSLinkModule( image, filename,
NSLINKMODULE_OPTION_BINDNOW |
NSLINKMODULE_OPTION_RETURN_ON_ERROR |
NSLINKMODULE_OPTION_PRIVATE);
Is there a reason this has been taken out in pd 0.39?
best greetings,
Thomas
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2005-12-30 21:31
Message:
Logged In: YES
user_id=313747
I ended up adding "DL_OPEN" to the configure.in special case
code for OSX. As soon as I can get a correct configure
script (tried real hard already but can't get autoconf to
work as advertised yet) this can be automatic.
----------------------------------------------------------------------
Comment By: Thomas Grill (xovo)
Date: 2005-12-13 08:55
Message:
Logged In: YES
user_id=350252
here's the patch
----------------------------------------------------------------------
Comment By: Jamie Tittle (tigital)
Date: 2005-12-12 11:40
Message:
Logged In: YES
user_id=634044
...this was kinda covered in the bugtracker last year:
"[ 1082938 ] sys_load_lib() on OSX too limited?"
https://sourceforge.net/tracker/index.php?func=detail&aid=1082938&group_id=…
...I'd like to suggest we ditch the NSLinkModule() stuff on
OSX, as it's been deprecated since 10.3.x: the replacement
is (drumroll please), dlopen()! As a matter of fact, hans
and I have been using a patch to do just this in the most
recent development releases: it's currently available in
/packages/patches/darwin/darwin_dlopen.patch, which I would
attach, but it's not letting me atm...
...also, I strongly suggest that we make another change in
the building of externals, from bundles to dynamic libs:
-dynamiclib -mmacosx-version-min=10.3 -undefined
dynamic_lookup (or suppress)
...this works for everything I've tried, but admittedly I
haven't done it with all externals or flext...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1378927&group_…
Patches item #1394140, was opened at 2005-12-30 23:35
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1394140&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 9
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: finally.. a real help browser
Initial Comment:
This is the beginnings of a real help browser. Its
basically a NeXT/Mac OS X file browser implemented in
Tcl/Tk and tweaked to work for Pd docs.
This eliminates the slow recursive help menu, the Mac
OS X workaround kludges, and works exactly the same on
all platforms.
This patch removes menu_documentation and doc_submenu
since they are both unnecessary now.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1394140&group_…
Patches item #1379647, was opened at 2005-12-13 11:46
Message generated for change (Settings changed) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1379647&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Guenter Geiger (ggeiger)
Assigned to: Miller Puckette (millerpuckette)
Summary: Linux Help browser startup
Initial Comment:
The help browser doesn't start up in background mode.
pd-0.39.2, tcl/tk 8.4.9, Linux
I think this is on all distros, but I haven't tried.
Might be worth to check. The attached patch fixes
the problem.
Cheers,
Günter
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2005-12-30 22:24
Message:
Logged In: YES
user_id=313747
damn, am I logged in yet? (testing...)
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2005-12-30 22:21
Message:
Logged In: NO
took for 0.40
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1379647&group_…