Patches item #1862178, was opened at 2008-01-02 14:40
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862178&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 1
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
>Summary: [feature] make makefilename accept floats in %s
Initial Comment:
while fiddling with the bug-fix for the missing "%c" in [makefilename] (see #1862168), i found that
[makefilename %s] will safely ignore any number that it receives.
in theory this is nice and consistent behaviour.
in practice i find it weird that
[32(
|
[makefilename %s]
outputs nothing(!).
and
[32(
|
[makefilename _%s+]
outputs "_+"
the attached patch uses "%g" to convert a number into a string which is then inserted as %s.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862178&group_…
Patches item #1867738, was opened at 2008-01-09 16:25
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1867738&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: [FIX] gensym() should use "const char*"
Initial Comment:
gensym is currently defined as "t_symbol *gensym(char *s);"
this leads to numerous warnings when compiling C++-externals, since C++ treats literals (strings) as "const char*".
e.g.
gensym("hello");
yields and a warning "warning: deprecated conversion from string constant to 'char*'"
the fix for this is simple and makes total sense, since gensym() does not need to modify the passed string. just use:
t_symbol *gensym(const char *s);
the attached patch does this (it additionally applies the same to the dogensym() function in m_class.c
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1867738&group_…
This error should have been fixed yesterday in the autobuild scripts. The
builders just need to be updated now, it seems ...
Pd user wrote:
> checking for snd_pcm_info in -lasound... yes
> checking for shm_open in -lrt... yes
> checking for jack_set_xrun_callback in -ljack... yes
> checking for jack_set_error_function in -ljack... yes
> MORECFLAGS --------------- -O6 -funroll-loops -fomit-frame-pointer
> checking for special C compiler options needed for large files... no
> checking for _FILE_OFFSET_BITS value needed for large files... 64
> ./configure: line 8297: syntax error near unexpected token `SINF,'
> ./configure: line 8297: `AST_EXT_LIB_CHECK(SINF, m, sinf)'
> make[1]: [pd] Error 2 (ignored)
> make -C /home/pd/auto-build/pd-extended/pd/src BUILDLAYOUT_DIR=/home/pd/auto-build/pd-extended/packages cvs_root_dir=/home/pd/auto-build/pd-extended DESTDIR=/home/pd/auto-build/pd-extended/packages/linux_make/build/ prefix=/usr/local libpddir=/home/pd/auto-build/pd-extended/packages/linux_make/build//usr/local/lib/pd OPT_CFLAGS="-O2 -mcpu=i686 -march=i386 -ftree-vectorize -ftree-vectorizer-verbose=3" UNAME=Linux install
> make[2]: Entering directory `/home/pd/auto-build/pd-extended/pd/src'
> make[2]: *** No rule to make target `install'. Stop.
> make[2]: Leaving directory `/home/pd/auto-build/pd-extended/pd/src'
> make[1]: *** [pd_install] Error 2
> make[1]: Leaving directory `/home/pd/auto-build/pd-extended/packages'
> make: *** [install] Error 2
> upload specs linux_make . deb
> Uploading /home/pd/auto-build/pd-extended/packages/linux_make/./Pd*.deb
> ls: /home/pd/auto-build/pd-extended/packages/linux_make/./Pd*.deb: No such file or directory
>
> _______________________________________________
> PD-cvs mailing list
> PD-cvs(a)iem.at
> http://lists.puredata.info/listinfo/pd-cvs
>
Patches item #1852385, was opened at 2007-12-17 09:07
Message generated for change (Comment added) made by russellbryant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: Improve strtokcpy() efficiency, prevent stack overflow
Initial Comment:
This patch provides a revised implementation of the strtokcpy() function in s_path.c. It provides the following benefits:
1) Prevent potential overflow of a stack buffer. This function did nothing to ensure that it didn't write past the end of the destination buffer.
It is possible to cause this to happen by providing certain command line arguments that are longer than MAXPDSTRING. Also, there may be other ways to trigger this bug if namelist_append_files() is used anywhere beyond the uses I reviewed, which are the ones in pd/*.c.
2) Copy bytes from the string in the same loop that looks for the delimiter. This is simply for efficiency in that the string only has to be traversed once, instead of twice (one to find the delimiter, and the second to copy up to it).
3) Document the function using doxygen style tags.
----------------------------------------------------------------------
>Comment By: Russell Bryant (russellbryant)
Date: 2008-01-06 08:39
Message:
Logged In: YES
user_id=1942915
Originator: YES
Checked in to branch-v0-40-extended
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2007-12-17 09:07
Message:
Logged In: YES
user_id=1942915
Originator: YES
File Added: strokcpy.txt
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_…
Patches item #1848356, was opened at 2007-12-10 21:29
Message generated for change (Comment added) made by russellbryant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848356&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: Yes
Submitted By: Russell Bryant (russellbryant)
Assigned to: Guenter Geiger (ggeiger)
Summary: streamin/streamout doc updates, bugs, and a security issue
Initial Comment:
This issue has been marked private as it includes details on a remotely exploitable buffer overflow vulnerability in the code for [streamin~].
A while ago, I was looking around at different options for streaming audio in and out of Pd. I spent a short time looking at the code for [streamin~] and [streamout~]. I ended up not using them for my project. However, I made this set of changes while looking at the code.
Since I moved on to something else, these changes aren't exactly complete, but point out some important things, so I think they may be worth putting in as is.
Here is a summary of the changes that are included.
stream.h changes:
1) doxygen style documentation updates
2) added an ifdef to protect against multiple or recursive inclusion of the header
3) Documentation of some of the fields in the data structures
4) Fixed potential alignment bugs by adding the packed attribute for the structure that defines frame headers. This attribute should always be used when it is used to directly interpret data from the network or when used to prepare data to send directly over the network. This section of the gcc manual has a tidbit about the attribute:
http://gcc.gnu.org/onlinedocs/gcc-4.2.2/gcc/Variable-Attributes.html#Variab…
5) Point out the fact that the code is not endianness-safe. The code should eventually be updated to respect network byte order.
6) Point out that the version field of the frame header is ignored when parsing incoming frames. It should eventually be checked, but doesn't matter much until the format gets changed such that the version number gets bumped.
7) Change a list of #defines to an enum, for the sake of better coding practice.
8) Change the use of "int" in the frame header structure to explicitly list that the field is 32-bits by using the int32_t type.
streamin~.c changes:
1) Fix a remotely exploitable buffer overflow that would allow remote execution of arbitrary code. The frame header includes 4 bytes to specify the frame length. However, the code only allocates enough space for the frame header and 256 bytes of payload data. The size portion of the frame header was not checked to ensure that its value was valid. This little hack should fix it.
----------------------------------------------------------------------
>Comment By: Russell Bryant (russellbryant)
Date: 2008-01-06 08:31
Message:
Logged In: YES
user_id=1942915
Originator: YES
I have merged these patches into the externals repository.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848356&group_…
Patches item #1836228, was opened at 2007-11-21 22:37
Message generated for change (Comment added) made by russellbryant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: [patch] simplify pd_makeversion() in src/s_main.c
Initial Comment:
This minor patch simplifies the pd_makeversion() function in src/s_main.c.
It replaces the sprintf / malloc / strcpy, with the equivalent single call to asprintf. It also provides the side benefit of removing the length limitation introduced by the intermediary stack buffer (with bounds that weren't being checked).
----------------------------------------------------------------------
>Comment By: Russell Bryant (russellbryant)
Date: 2008-01-05 22:30
Message:
Logged In: YES
user_id=1942915
Originator: YES
File Added: makeversion.patch2.txt
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2008-01-05 22:29
Message:
Logged In: YES
user_id=1942915
Originator: YES
Actually, I mean sprintf to snprintf. Anyway, here is an updated patch
that includes the change from sprintf to snprintf, as well as a
simplification to use strdup() instead of malloc/strcpy.
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2008-01-05 22:26
Message:
Logged In: YES
user_id=1942915
Originator: YES
Well, it turns out that asprintf() is a GNU extension, and is not a part
of standard C or POSIX. So, this probably will not be acceptable.
However, I'd like to still leave it open, as I'd like to see the strcpy
changed to strncpy ...
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-23 13:24
Message:
Logged In: YES
user_id=27104
Originator: NO
Funny, I originally submitted the patch with this function and it included
asprintf(). Miller accepted the patch, but replaced the asprintf() with
the sprintf/malloc/strcpy combo, with only this comment:
"modified to avoid the effete asprintf() call, then took for 0.40"
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Patches item #1836228, was opened at 2007-11-21 22:37
Message generated for change (Comment added) made by russellbryant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: [patch] simplify pd_makeversion() in src/s_main.c
Initial Comment:
This minor patch simplifies the pd_makeversion() function in src/s_main.c.
It replaces the sprintf / malloc / strcpy, with the equivalent single call to asprintf. It also provides the side benefit of removing the length limitation introduced by the intermediary stack buffer (with bounds that weren't being checked).
----------------------------------------------------------------------
>Comment By: Russell Bryant (russellbryant)
Date: 2008-01-05 22:29
Message:
Logged In: YES
user_id=1942915
Originator: YES
Actually, I mean sprintf to snprintf. Anyway, here is an updated patch
that includes the change from sprintf to snprintf, as well as a
simplification to use strdup() instead of malloc/strcpy.
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2008-01-05 22:26
Message:
Logged In: YES
user_id=1942915
Originator: YES
Well, it turns out that asprintf() is a GNU extension, and is not a part
of standard C or POSIX. So, this probably will not be acceptable.
However, I'd like to still leave it open, as I'd like to see the strcpy
changed to strncpy ...
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-23 13:24
Message:
Logged In: YES
user_id=27104
Originator: NO
Funny, I originally submitted the patch with this function and it included
asprintf(). Miller accepted the patch, but replaced the asprintf() with
the sprintf/malloc/strcpy combo, with only this comment:
"modified to avoid the effete asprintf() call, then took for 0.40"
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Patches item #1836228, was opened at 2007-11-21 22:37
Message generated for change (Comment added) made by russellbryant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: [patch] simplify pd_makeversion() in src/s_main.c
Initial Comment:
This minor patch simplifies the pd_makeversion() function in src/s_main.c.
It replaces the sprintf / malloc / strcpy, with the equivalent single call to asprintf. It also provides the side benefit of removing the length limitation introduced by the intermediary stack buffer (with bounds that weren't being checked).
----------------------------------------------------------------------
>Comment By: Russell Bryant (russellbryant)
Date: 2008-01-05 22:26
Message:
Logged In: YES
user_id=1942915
Originator: YES
Well, it turns out that asprintf() is a GNU extension, and is not a part
of standard C or POSIX. So, this probably will not be acceptable.
However, I'd like to still leave it open, as I'd like to see the strcpy
changed to strncpy ...
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-23 13:24
Message:
Logged In: YES
user_id=27104
Originator: NO
Funny, I originally submitted the patch with this function and it included
asprintf(). Miller accepted the patch, but replaced the asprintf() with
the sprintf/malloc/strcpy combo, with only this comment:
"modified to avoid the effete asprintf() call, then took for 0.40"
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1836228&group_…
Bugs item #1863325, was opened at 2008-01-03 13:25
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863325&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
>Status: Closed
>Resolution: Duplicate
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: font bug
Initial Comment:
when I run pd the font is good
but when I install pd-extended
I have a awful font for the consol and for helps
It very dificult for read it
I run on debian/lenny/testing
You can download screenshot of the bug here : http://pazelty.free.fr/fichiers/pd-extended.png
on ubuntu I don't have this problem.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-01-05 03:06
Message:
Logged In: YES
user_id=27104
Originator: NO
This seems to be a common problem but it's not actually a problem with
Pd-extended. Either you are missing the ttf-bitstream-vera package which
has the font you need, or your fonts aren't properly setup. try this:
dpkg-reconfigure x-ttcidfont-conf
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1863325&group_…