Greetings,
I really don't intend to start a SCM war here, but has the discussion of
switching to using svn on sourceforge instead of cvs ever come up before?
Instead of rambling on about reasons why I think svn would be nicer than cvs, I
am curious if people have any reasons _not_ to switch.
The amount that it would increase my happiness when working with the pure-data
repository is enough that I would volunteer to put forth the leg work to do the
conversion, and to write a quick guide for developers with commit access, if
people were interested and willing to let me do it. :) I help admin a fairly
large svn server (svn.digium.com and svncommunity.digium.com), and I found the
following guide for doing the conversion for a sourceforge project. It looks
fairly easy to do ...
https://sourceforge.net/docs/E09
--
Russell Bryant
hey,
is desiredata still alive? i posted a couple of messages about trying to
get an OSX version from SVN compiling a month or two ago and never got any
replies..
otherwise, what's the status on UI development? if i was to just dive
headfirst and try and fix some of the things that have been bugging me over
the last week, is that at all useful or helpful? or is there someone i
should talk to first?
i haven't been involved in development of any open source projects before,
and i guess i'm just not sure what the procedure normally is.
in particular (i'm running Miller's 0.40-2 on OSX 10.4):
- i'd like to bring in the multiple-level undo code from dd, or implement
something similar
- there seem to be some OSX-specific issues around sub-windows switching
between PD windows - apple-` doesn't switch between PD sub-windows like it
should. this could also be a Tcl/Tk issue.
- there are consistent problems with populating the Window menu
- the scrollbar down arrow is 95% hidden on the main Pd window, so
scrolling messages down involves clicking a two-pixel-high strip, which is
really hard
- i'd like to put a scrollbar on the path preferences, so more than 10
lines can fit
- mouse cursor alignment over the outlet 'plugs' on objects is bloody
frustrating for new users (i've spent the week watching one) and it's just
an offset issue i think
- preserving newlines in comments! i don't know how possible this is (how
tied comments are to Pd's core messaging system) but i'd love to be able to
have multi-paragraph documentation with one comment object
- occasionally when switching into a sub-window the mouse x offset is
completely munted, so Tcl/Tk thinks the mouse is way over from where it
should be
- other things i can't think of right now
i suppose what i'm really asking is - if i went ahead and spent a week
fixing all the UI things that really bugged me, assuming my code wasn't
really stupid or ugly or bad, what's the chances my changes would make it
out into the world, and so be useful for people who aren't me?
--
damian stewart | +351 967 797 263 | damian(a)frey.co.nz
frey | live art with machines | http://www.frey.co.nz
Patches item #1835093, was opened at 2007-11-20 03:42
Message generated for change (Comment added) made by sf-robot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1835093&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: documentation
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Frank Barknecht (fbar)
Assigned to: Miller Puckette (millerpuckette)
Summary: Corrected help patch for [swap]
Initial Comment:
As Chuckk Hubbard noted, the help file for[swap] has left and right swapped in some places. Attached is a corrected help patch ready to be dropped in as a replacement with an added example use for swap.
----------------------------------------------------------------------
>Comment By: SourceForge Robot (sf-robot)
Date: 2008-01-30 19:20
Message:
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2008-01-14 10:44
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1835093&group_…
Patches item #1862148, was opened at 2008-01-02 04:41
Message generated for change (Comment added) made by sf-robot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862148&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: [bugfix] setitimer invalid timeval
Initial Comment:
as described by claude in bug#1841758
(https://sourceforge.net/tracker/index.php?func=detail&aid=1841758&group_id=…)
there is a small bug in the use of setitimer() in sys_setalarm().
the problem is, that the setitimer() API has changed in order to be POSIX-conformant and Pd has not yet adapated to this change.
the attached patch fixes the problem, by splitting the given "microsec" value into seconds and microseconds.
----------------------------------------------------------------------
>Comment By: SourceForge Robot (sf-robot)
Date: 2008-01-30 19:20
Message:
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2008-01-14 10:37
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862148&group_…
Patches item #1867738, was opened at 2008-01-09 07:25
Message generated for change (Comment added) made by sf-robot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1867738&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: [FIX] gensym() should use \"const char*\"
Initial Comment:
gensym is currently defined as "t_symbol *gensym(char *s);"
this leads to numerous warnings when compiling C++-externals, since C++ treats literals (strings) as "const char*".
e.g.
gensym("hello");
yields and a warning "warning: deprecated conversion from string constant to 'char*'"
the fix for this is simple and makes total sense, since gensym() does not need to modify the passed string. just use:
t_symbol *gensym(const char *s);
the attached patch does this (it additionally applies the same to the dogensym() function in m_class.c
----------------------------------------------------------------------
>Comment By: SourceForge Robot (sf-robot)
Date: 2008-01-30 19:20
Message:
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2008-01-14 10:38
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1867738&group_…
Patches item #1862168, was opened at 2008-01-02 05:22
Message generated for change (Comment added) made by sf-robot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862168&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: None
Priority: 6
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: [bugfix] makefilename ignores \"%c\"
Initial Comment:
the bugfix-#1688540 introduced argument-checking in [makefilename].
unfortunately, the author forgot about the "%c", which is currently the only way to get "weird" characters (like space,...).
this breaks quite some patches which depend on that workaround.
since there is still no "clean" way to produce symbols with special characters, i'd suggest to include "%c" into the formatting in [makefilename].
attached is a fix, that adds "%c" to the types that request an integer.
----------------------------------------------------------------------
>Comment By: SourceForge Robot (sf-robot)
Date: 2008-01-30 19:20
Message:
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2008-01-14 10:40
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1862168&group_…
Patches item #1848295, was opened at 2007-12-10 16:53
Message generated for change (Comment added) made by sf-robot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848295&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: Fix small potential stack overflow
Initial Comment:
Attached is a patch to fix another potential stack buffer overflow in s_main.c. I didn't send this over in private because I don't think it can be exploited in any useful way, so it's just a small bug.
----------------------------------------------------------------------
>Comment By: SourceForge Robot (sf-robot)
Date: 2008-01-30 19:20
Message:
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2008-01-14 10:45
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-12-26 13:45
Message:
Logged In: YES
user_id=27104
Originator: NO
checked into branch-v0-40-extended
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2007-12-10 18:41
Message:
Logged In: YES
user_id=1942915
Originator: YES
Also, let me just clarify my original summary just a little bit.
You can cause the overrun of the buffer by providing a really long input
string to the -schedlib command line option. It's just not exploitable in
such a way that it would be considered a security issue.
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2007-12-10 18:38
Message:
Logged In: YES
user_id=1942915
Originator: YES
I'm sorry for the stupid typo. That code is actually only compiled in for
a Windows build (whenever MSW is defined), so I didn't notice.
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2007-12-10 18:36
Message:
Logged In: YES
user_id=1942915
Originator: YES
File Added: filename_overflow.patch2.txt
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-12-10 17:18
Message:
Logged In: YES
user_id=27104
Originator: NO
I am guessing there is a typo in that patch, since the new line also uses
sprintf() instead of snprintf():
- sprintf(filename, "%s.dll", sys_externalschedlibname);
+ sprintf(filename, sizeof(filename), "%s.dll",
sys_externalschedlibname);
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1848295&group_…
Patches item #1852385, was opened at 2007-12-17 07:07
Message generated for change (Comment added) made by sf-robot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: Improve strtokcpy() efficiency, prevent stack overflow
Initial Comment:
This patch provides a revised implementation of the strtokcpy() function in s_path.c. It provides the following benefits:
1) Prevent potential overflow of a stack buffer. This function did nothing to ensure that it didn't write past the end of the destination buffer.
It is possible to cause this to happen by providing certain command line arguments that are longer than MAXPDSTRING. Also, there may be other ways to trigger this bug if namelist_append_files() is used anywhere beyond the uses I reviewed, which are the ones in pd/*.c.
2) Copy bytes from the string in the same loop that looks for the delimiter. This is simply for efficiency in that the string only has to be traversed once, instead of twice (one to find the delimiter, and the second to copy up to it).
3) Document the function using doxygen style tags.
----------------------------------------------------------------------
>Comment By: SourceForge Robot (sf-robot)
Date: 2008-01-30 19:20
Message:
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2008-01-14 10:37
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2008-01-06 06:39
Message:
Logged In: YES
user_id=1942915
Originator: YES
Checked in to branch-v0-40-extended
----------------------------------------------------------------------
Comment By: Russell Bryant (russellbryant)
Date: 2007-12-17 07:07
Message:
Logged In: YES
user_id=1942915
Originator: YES
File Added: strokcpy.txt
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852385&group_…
Patches item #1842162, was opened at 2007-11-30 21:16
Message generated for change (Comment added) made by sf-robot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1842162&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Russell Bryant (russellbryant)
Assigned to: Miller Puckette (millerpuckette)
Summary: Fix typo in trigger-help.pd
Initial Comment:
Here is a silly tiny patch.
In the trigger-help.pd file, there is the object:
[trigger float bang symbol list anything]
Later, it says that it can be simplified to:
[t f b l s a]
This patch fixes the typo in the simplified version by changing it to:
[t f b s l a]
----------------------------------------------------------------------
>Comment By: SourceForge Robot (sf-robot)
Date: 2008-01-30 19:20
Message:
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2008-01-14 10:42
Message:
Logged In: YES
user_id=313747
Originator: NO
taken.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1842162&group_…
Patches item #1881907, was opened at 2008-01-29 17:24
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1881907&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: more t_float/t_sample fixes
Initial Comment:
pd-0.41 has a lot of cleanup regarding the types of numbers (see patch-#1822001 'use of t_float/t_sample instead of "float"')
however, some things have been left out by the original patches, here are some more:
m_pd.h:
seems like the t_float-enabling of postfloat() was forgotten in the declaration
d_math.c:
here it is the other way round: while the declarations in m_pd.h use t_float, the definitions do not
g_array.c g_template.c:
here my patch was a bit rash: scanf() doesn't like to get pointers to double (if "t_float" is set to "double") if the format string is really "%f" (or "%g"); the new patches use an internal _double_ variable and the format string "%lf" ("%lg"); the _double_ variable is then cast to (t_float).
this should be on the save side; the alternatives would have been using an internal _float_ variable, and/or to change the format-string depending on the used type.
d_fftroutine.c: this needed a bit more changes, but luckily enough, the original code already was aware of possible type-changes; i have currently used "t_float" (in line with the m_pd.h declaration of "pd_fft()"), but i am not sure whether this really should be "t_sample".
changes should be rather simple: just change the defines of FLOAT and SAMPLE in the beginning... (and don't forget the declaration in m_pd.h)
with these changes, Pd compiles without (additional) warnings with t_float/t_floatarg and t_sample set to "double".
(there is still work to do in d_ugen.c though, to make it really usable...)
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-29 18:54
Message:
Logged In: YES
user_id=564396
Originator: YES
File Added: sigmund~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-29 18:12
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/sigmung~
File Added: sigmund~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-29 18:11
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for pique
File Added: pique.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-29 18:09
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/lrshift~
File Added: lrshift~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-29 18:08
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/loop~
(the core code originally was not dependent on Pd; i therefore introduced
an additional "#define t_sample float" in case it is not compiled for Pd)
File Added: loop~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-01-29 18:06
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/choice
File Added: choice.c.diff
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1881907&group_…