Patches item #1943614, was opened at 2008-04-16 06:25
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1943614&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jakob Leben (jleben)
Assigned to: Nobody/Anonymous (nobody)
Summary: patch 1943301 updated
Initial Comment:
Here is the update of my patch filed as 1943301 (move instead of draw when 'graphed on parent') - now made with diff -uwB ;)
I fixed both of the bugs mentioned when I posted the first version of this patch. I noticed that one of them, namely the name of garray missing when array is created was a general bug and not produced by my code. This is now solved also, for the good of the pd community!
I also added iemgui_graph function which now all iemgui objects call as their graph_fn function and it in turn calls object's x_gui.x_draw function. This allows for graph_displace to make generic calls to graph_fn functions of all of it's children.
I would also like to point out that this patch only offers the possibility to use Tk command move for moving graphics of objects which are 'graphed on parent'. To add graph_fn functions to all the pd-vanilla objects I simply copied the code they use to draw themselves when being displaced, and currently many of them actually redraw themselves instead of just move. I paid attention that garray's graphics are really moved though, because to speed up array drawing was the main objective of writing this patch.
One problem I wish to point at is: if an object uses iemgui_displace function (and it holds the same now for new iemgui_graph function) it actually loses possibility to easily use Tk move command, because iemgui functions don't pass the dx and dy arguments to local object's functions they call for drawing. Thus using iemgui_displace and iemgui_graph makes it even less convenient and effective. I think iemgui functions should do more to make writing of gui externals easy.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1943614&group_…
Patches item #1930681, was opened at 2008-03-31 19:44
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930681&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Miller Puckette (millerpuckette)
Summary: 0.41-4 s_path.c fixes
Initial Comment:
Two fixes for buffer overrun (buf[1000]=0 later) and rc file args:
--- s_path.ori.c 2008-04-01 01:37:03.000000000 +0200
+++ s_path.c 2008-04-01 01:38:02.000000000 +0200
@@ -379,7 +379,7 @@
int rcargc;
char* rcargv[NUMARGS];
char* buffer;
- char fname[MAXPDSTRING], buf[1000], *home = getenv("HOME");
+ char fname[MAXPDSTRING], buf[1001], *home = getenv("HOME");
int retval = 1; /* that's what we will return at the end; for now, let's think it'll be an error */
/* initialize rc-arg-array so we can safely clean up at the end */
@@ -423,7 +423,7 @@
fclose(file);
if (sys_verbose)
{
- if (rcargv)
+ if (rcargc)
{
post("startup args from RC file:");
for (i = 1; i < rcargc; i++)
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 19:59
Message:
Logged In: YES
user_id=27104
Originator: NO
checked into branches/pd-extended/0.40
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930681&group_…
Patches item #1930769, was opened at 2008-03-31 22:09
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930769&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Miller Puckette (millerpuckette)
Summary: 0.41-4 fix memory leak with array sinesum/cosinesum
Initial Comment:
svecs are allocated twice....
--- ../src.ori/g_array.c 2008-03-15 01:03:00.000000000 +0100
+++ g_array.c 2008-04-01 04:05:50.000000000 +0200
@@ -1221,7 +1221,7 @@
static void garray_sinesum(t_garray *x, t_symbol *s, int argc, t_atom *argv)
{
- t_float *svec = (t_float *)t_getbytes(sizeof(t_float) * argc);
+ t_float *svec;
int npoints, i;
if (argc < 2)
{
@@ -1244,7 +1244,7 @@
static void garray_cosinesum(t_garray *x, t_symbol *s, int argc, t_atom *argv)
{
- t_float *svec = (t_float *)t_getbytes(sizeof(t_float) * argc);
+ t_float *svec;
int npoints, i;
if (argc < 2)
{
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 19:51
Message:
Logged In: YES
user_id=27104
Originator: NO
checked this into branches/pd-extended/0.40
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930769&group_…
Patches item #1930733, was opened at 2008-03-31 21:02
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930733&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata
Group: bugfix
Status: Open
Resolution: None
>Priority: 7
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Miller Puckette (millerpuckette)
Summary: 0.41-4: prevent buffer overrun in m_class.c
Initial Comment:
the array only has MAXPDARG elements.......
--- m_class.ori.c 2008-04-01 03:00:09.000000000 +0200
+++ m_class.c 2008-04-01 03:00:12.000000000 +0200
@@ -763,7 +763,7 @@
va_start(ap, fmt);
while (1)
{
- if (nargs > MAXPDARG)
+ if (nargs >= MAXPDARG)
{
pd_error(x, "pd_vmess: only %d allowed", MAXPDARG);
break;
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 19:42
Message:
Logged In: YES
user_id=27104
Originator: NO
checked into branches/pd-extended/0.40
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930733&group_…
Patches item #1943301, was opened at 2008-04-15 15:09
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1943301&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: move instead of redraw GUI objects 'graphed on parent
Initial Comment:
New widget behavior 'graphfn' which gets called by graph_displace function and only uses Tk command 'move' to move graphics instead of erasing and recreating them.
Patch also adds graphfn functions to all the pd-vanilla GUI objects.
Also some modification inside g_array.c to remove unnecessary multiple visualizations of garrays.
Result: improved performace of array drawing.
Usage: invoke the patch inside the 'src' folder.
Known bugs that are newly introduced by this patch:
- Array name is not visible immediately after inserting an array. It gets drawn though at first redraw of the array after the array has been moved from the border of the canvas.
- Comments that are 'graphed on parent' don't move with graph. However, they are drawn at the right place when their redrawing occurs.
Fixes come soon.
Jakob Leben
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 18:59
Message:
Logged In: YES
user_id=27104
Originator: NO
This patch seems to include a lot of whitespace changes, making it very
hard to read. Can you recreate it in 'diff -uw' format please? :)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1943301&group_…
Patches item #1716480, was opened at 2007-05-10 08:40
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1716480&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: abstractions
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: ISOdate unnecessarily complicated...
Initial Comment:
i just noticed that the [hcs/ISOdate] abstraction uses an unnecessarily complicated syntax with externals to create the ISO-datestring:
you can replace both [pd addzero] (with everything in it) by [makefilename %02d]
the attached diff does this (but it might well be simpler to do the change by hand)
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 18:51
Message:
Logged In: YES
user_id=27104
Originator: NO
took it. I wonder why [makesymbol %02d] doesnt work...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1716480&group_…
Patches item #1939017, was opened at 2008-04-09 19:47
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1939017&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dan Wilcox (danomatika)
Assigned to: Nobody/Anonymous (nobody)
Summary: Unix: hidden files/folders in tk open/save dialogs
Initial Comment:
Howdy,
After some discussion on the pd list, I'd like to submit a patch to pd.tk that sets the tk variables for hiding hidden (.filename) files/folders in the Open/Save/Save As dialog boxes. It also adds a button to show said hidden files.
In Windows and Mac, this behavior is inherited from the OS, so the associated code is only called for Unix environments.
I have tested this on my installation of pd-extended 0.39.3 and I believe this is a easy and useful addition to pd-vanilla. I will submit this patch to pd-extended as well.
I haven't submitted a patch before, so forgive me if I somehow screw up the file.
--
Dan Wilcox
robotcowboy.com
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 17:52
Message:
Logged In: YES
user_id=27104
Originator: NO
I see now, this is a 'recommended' kludge :)
http://groups.google.com/group/comp.lang.tcl/tree/browse_frm/month/2006-03/…
I checked it into branches/pd-extended/0.40/.
----------------------------------------------------------------------
Comment By: Dan Wilcox (danomatika)
Date: 2008-04-15 17:48
Message:
Logged In: YES
user_id=2032867
Originator: YES
Yeah as for the catch part, it doesn't actually open the panel, at least
in a noticeable way. I'm not a tk/tcl expert at all, but from what I've
read, the panel needs to be called before changing the variables will hold.
It's a sort of "soft" open.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 17:38
Message:
Logged In: YES
user_id=27104
Originator: NO
Does the "catch {tk_getOpenFile -with-invalid-argument}" part open the
panel? Is seems like a kludge. I suspect there is probably a cleaner way
to make those settings stick.
As for submitting a patch, this is find. I think that making the changes
to the SVN-controlled sources, then using 'svn diff -x -w' makes the
cleanest patches in the easiest way.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1939017&group_…
Patches item #1939017, was opened at 2008-04-09 18:47
Message generated for change (Comment added) made by danomatika
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1939017&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dan Wilcox (danomatika)
Assigned to: Nobody/Anonymous (nobody)
Summary: Unix: hidden files/folders in tk open/save dialogs
Initial Comment:
Howdy,
After some discussion on the pd list, I'd like to submit a patch to pd.tk that sets the tk variables for hiding hidden (.filename) files/folders in the Open/Save/Save As dialog boxes. It also adds a button to show said hidden files.
In Windows and Mac, this behavior is inherited from the OS, so the associated code is only called for Unix environments.
I have tested this on my installation of pd-extended 0.39.3 and I believe this is a easy and useful addition to pd-vanilla. I will submit this patch to pd-extended as well.
I haven't submitted a patch before, so forgive me if I somehow screw up the file.
--
Dan Wilcox
robotcowboy.com
----------------------------------------------------------------------
>Comment By: Dan Wilcox (danomatika)
Date: 2008-04-15 16:48
Message:
Logged In: YES
user_id=2032867
Originator: YES
Yeah as for the catch part, it doesn't actually open the panel, at least
in a noticeable way. I'm not a tk/tcl expert at all, but from what I've
read, the panel needs to be called before changing the variables will hold.
It's a sort of "soft" open.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 16:38
Message:
Logged In: YES
user_id=27104
Originator: NO
Does the "catch {tk_getOpenFile -with-invalid-argument}" part open the
panel? Is seems like a kludge. I suspect there is probably a cleaner way
to make those settings stick.
As for submitting a patch, this is find. I think that making the changes
to the SVN-controlled sources, then using 'svn diff -x -w' makes the
cleanest patches in the easiest way.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1939017&group_…
Patches item #1939017, was opened at 2008-04-09 19:47
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1939017&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dan Wilcox (danomatika)
Assigned to: Nobody/Anonymous (nobody)
Summary: Unix: hidden files/folders in tk open/save dialogs
Initial Comment:
Howdy,
After some discussion on the pd list, I'd like to submit a patch to pd.tk that sets the tk variables for hiding hidden (.filename) files/folders in the Open/Save/Save As dialog boxes. It also adds a button to show said hidden files.
In Windows and Mac, this behavior is inherited from the OS, so the associated code is only called for Unix environments.
I have tested this on my installation of pd-extended 0.39.3 and I believe this is a easy and useful addition to pd-vanilla. I will submit this patch to pd-extended as well.
I haven't submitted a patch before, so forgive me if I somehow screw up the file.
--
Dan Wilcox
robotcowboy.com
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 17:38
Message:
Logged In: YES
user_id=27104
Originator: NO
Does the "catch {tk_getOpenFile -with-invalid-argument}" part open the
panel? Is seems like a kludge. I suspect there is probably a cleaner way
to make those settings stick.
As for submitting a patch, this is find. I think that making the changes
to the SVN-controlled sources, then using 'svn diff -x -w' makes the
cleanest patches in the easiest way.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1939017&group_…
Patches item #1942258, was opened at 2008-04-14 13:19
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1942258&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: jack fixes and enhancements
Initial Comment:
the jack-implementation in Pd has several flaws:
- maximum number of ports = 32 (hardcoded)
- Pd crashes when you request more than 32 channels
- jackd has to run before Pd is started
- Pd doesn't like jackd quitting
- maximum of 2 parallel Pd's connecting to jack
- ...
i believe that the attached patch fixes most of these issues:
- raises the maximum number of ports to 1024 (this is the maximum number of ports qjackctl allows me to select for the jackd)
- when initializing ports, Pd checks whether a port was successfully created; if not it doesn't add more ports but leaves this as the maximum it could get from jackd (no more crashes with high number of ports)
- Pd automatically starts a default jackd if none is running yet
- when the jackd quits while Pd is running, it sets the jack_client to 0, efficiently preventing hangs. jackd is restarted automatically when selected via the audio-settings
- Pd tests the return status when trying to connect to jackd; if it finds that the name is already given it tries alternative names; if initialization failed for other reasons, it just fails.
i have tested this on my debian unstable/testing system that provides libjack-dev 0.109.2-1.1
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 17:29
Message:
Logged In: YES
user_id=27104
Originator: NO
checked this patch into branches/pd-extended/0.40:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=9702
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-04-14 13:21
Message:
Logged In: YES
user_id=564396
Originator: YES
i raised priority a bit, as the current implementation makes Pd unusable
with highly multichannel systems (e.g. using 64 channels) and jack
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1942258&group_…