Patches item #2872631, was opened at 2009-10-04 14:00
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2872631&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: dllextent for pd~ on Windows and Cygwin
Initial Comment:
Add the dllextent stuff on Windows and Cygwin since pd~ should build on Cygwin:
Index: pd~/pd~.c
===================================================================
--- pd~/pd~.c (revision 12522)
+++ pd~/pd~.c (working copy)
@@ -60,6 +60,9 @@
static char pd_tilde_dllextent[] = ".d_fat",
pd_tilde_dllextent2[] = ".pd_darwin";
#endif
+#if defined(_WIN32) || defined(__CYGWIN__)
+static char sys_dllextent[] = ".m_i386", sys_dllextent2[] = ".dll";
+#endif
/* ------------------------ pd_tilde~ ----------------------------- */
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 21:07
Message:
FYI: this patch has already been included in the pd-gui-rewrite/0.43
branch:
https://pure-data.svn.sourceforge.net/svnroot/pure-data/branches/pd-gui-rew…
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-10-04 14:06
Message:
oops sys_dllextent[ should be pd_tilde_dllextent
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2872631&group_…
Patches item #2883658, was opened at 2009-10-21 23:13
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2883658&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: remove portaudio.h from s_midi_pm.c
Initial Comment:
Somehow, s_midi_pm.c has portaudio.h in it. Its not needed at all, and having it there prevents compiling Pd with portmidi but without portaudio, which is needed by some devices, like the iPhone/iPod.
===================================================================
--- src/s_midi_pm.c (revision 12617)
+++ src/s_midi_pm.c (working copy)
@@ -18,7 +18,6 @@
#include <stdlib.h>
#include <string.h>
#include <errno.h>
-#include "portaudio.h"
#include "portmidi.h"
#include "porttime.h"
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 21:06
Message:
FYI: this patch has already been included in the pd-gui-rewrite/0.43
branch:
https://pure-data.svn.sourceforge.net/svnroot/pure-data/branches/pd-gui-rew…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2883658&group_…
Patches item #2886889, was opened at 2009-10-27 00:41
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2886889&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: build fixes for Android, clean up for Linux/BSD
Initial Comment:
Android seems to be an odd mix of Linux and BSD. In the process of porting Pd to android, I found a few inconsistencies:
- int32 was being using in UNIX land, when int32_t should be used there (int32 is Windows and IRIX)
- int32_t should come from stdint.h not sys/types.h
- sighandler_t is not defined in Android, but sig_t is defined in Linux, MacOSX, and Android
I checked these on Ubuntu 9.04, Mac OS X 10.5.8, Cygwin, MinGW, OpenBSD, and Android.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 21:05
Message:
FYI: this patch has already been included in the pd-gui-rewrite/0.43
branch:
https://pure-data.svn.sourceforge.net/svnroot/pure-data/branches/pd-gui-rew…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2886889&group_…
Patches item #2859780, was opened at 2009-09-16 00:50
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2859780&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: make canvas_vis() the same for all platforms
Initial Comment:
the order of the Tcl commands caused issues on some platforms. If [wm deiconify] is first, then it seems to work fine on all platforms. This eliminates some bugs on the windows side of things, caused by the fact that the original code was unvising and then revising a patch when it should have just raised the window.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 21:01
Message:
FYI: this patch has already been included in the pd-gui-rewrite/0.43
branch:
https://pure-data.svn.sourceforge.net/svnroot/pure-data/branches/pd-gui-rew…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2859780&group_…
Patches item #2859478, was opened at 2009-09-15 14:35
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2859478&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: in Win32, allloca() is in malloc.h
Initial Comment:
bonk~.c won't build without this change. MinGW has alloca() but defined in malloc.h. I don't know about Microsoft VC, so I added a guard for that:
===================================================================
--- bonk~/bonk~.c (revision 12350)
+++ bonk~/bonk~.c (working copy)
@@ -82,7 +82,9 @@
static t_class *bonk_class;
#endif
-#ifndef _MSC_VER
+#ifdef _WIN32
+#include <malloc.h>
+#elif ! defined(_MSC_VER)
#include <alloca.h>
#endif
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 21:01
Message:
FYI: this patch has already been included in the pd-gui-rewrite/0.43
branch:
https://pure-data.svn.sourceforge.net/svnroot/pure-data/branches/pd-gui-rew…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2859478&group_…
Patches item #2857679, was opened at 2009-09-12 15:03
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2857679&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: use pdtk_couldnotfind in g_editor.c
Initial Comment:
added pdtk_couldnotfind and have the find function call it via sys_vgui() when it can't find something, allowing for much more dynamic responses
adjusted 'really quit?' dialog to apply to '.pdwindow' instead of '.', and
made pdtk_check deiconify and raise the window it applies to
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 21:00
Message:
FYI: this patch has already been included in the pd-gui-rewrite/0.43
branch:
https://pure-data.svn.sourceforge.net/svnroot/pure-data/branches/pd-gui-rew…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2857679&group_…
Patches item #1412210, was opened at 2006-01-22 13:26
Message generated for change (Settings changed) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1412210&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix for bug in menu_openhtml on Windows
Initial Comment:
menu_openhtml() currently does not work if there is a
space in the file/path name (i.e. "C:\Program Files\pd")
Here is a fix. In menu_openhtml() in u_main.tk, change:
exec rundll32 url.dll.FileProtocolHandler \
[format "file:%s" $filename] &
To this:
exec rundll32 url.dll.FileProtocolHandler \
[format "file:%s" [file attributes $filename
-shortname]] &
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:58
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2006-01-28 22:06
Message:
Logged In: YES
user_id=27104
This is a better method of fixing this that Martin Peach
posted. (I haven't tested it yet) .hc
In u_main.tk the procedure menu_openhtml fails on the
NT platform when pd_guidir contains both spaces and the
double dot (/..) which is currently always added for NT
when pd_guidir is constructed from e.g. "C:/Program
Files/pd/bin" as "C:/Program Files/pd/bin/.." instead
of the more straightforward "C:/Program Files/pd".
Forcing the use of short filenames is one way around
this but the attached patch just strips off the "/bin"
instead of adding "/.." to it.
This line terminates the path just before the last slash:
set pd_guidir [string range $pd_guidir 0 [expr [string
last / $pd_guidir] - 1]]
It also might be more efficient to work only with
pd_guidir, since it always gets shortened, so I took
out the temporary string pd_gui3 as well.
Martin Peach
martinrp(a)vax2.concordia.ca
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2006-01-25 12:53
Message:
Logged In: NO
The bug seems to be happen only when the path has spaces
_and_ the double dot .. in it.
It might be better to make guidir a straight path instead.
In this part of pd.tk:
if {$pd_nt == 1} {
global pd_guidir
global pd_tearoff
set pd_gui2 [string range $argv0 0 [expr [string last \\
$argv0 ] - 1]]
regsub -all \\\\ $pd_gui2 / pd_gui3
set pd_guidir $pd_gui3/..
load $pd_guidir/bin/pdtcl.dll
set pd_tearoff 1
}
Change to:
if {$pd_nt == 1} {
global pd_guidir
global pd_tearoff
set pd_gui2 [string range $argv0 0 [expr [string last \\
$argv0 ] - 1]]
regsub -all \\\\ $pd_gui2 / pd_gui3
set pd_gui4 [string range $pd_gui3 0 [expr [string last
/ $pd_gui3] - 1]]
set pd_guidir $pd_gui4
load $pd_guidir/bin/pdtcl.dll
set pd_tearoff 1
}
This has the effect:
argv0: C:\Copy of pd_039_0_test7\pd\bin\pd.tk
pd_guidir: C:/Copy of pd_039_0_test7/pd
(instead of C:/Copy of pd_039_0_test7/pd/bin/..)
pd_gui2: C:\Copy of pd_039_0_test7\pd\bin
pd_gui3: C:/Copy of pd_039_0_test7/pd/bin
menu_openhtml filename: C:/Copy of
pd_039_0_test7/pd/doc/1.manual/index.htm
(Lines are too short on this comment box:( )
Martin
martinrp(a)vax2.concordia.ca
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2006-01-22 13:27
Message:
Logged In: YES
user_id=27104
oops, "-shortname]] &" should be on the same line as the
line above.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1412210&group_…
Patches item #1829055, was opened at 2007-11-09 10:58
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1829055&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: stffn (stffn)
Assigned to: Miller Puckette (millerpuckette)
Summary: Growing patch-window size
Initial Comment:
I made a patch to test the behavior. This is the test:
1) Note that the patch is 500x300 initially. Either by opening in a text editor or with 'head -1' or.
2) Open the attached patch. Click the [10( on one of the sides.
3) Note that the patch has grown to 504x304
Now the weird bit.
4) with out closing the patch, click the [10( again.
5) Note that it has _not_ grown to 508x308.
6) Close the patch
7) Reopen the patch
8) Click the [bang(
9) Note that it has now grown to 508x308
So it seams it grows 4px per run with a reload.
More weirdness. Or observations.
10) Now try the above but clicking the [100( on either side.
11) Note that it still only increases by 4px.
12) Close and reopen the patch.
13) Just save it as you normally would.
14) Note that only one save increases the size 4px.
15) Note that using either the [until] method or the [delay] method doesn't make a difference.
Word on the street says that it don't happen on Linux. This is not tested. This test is done on OS X.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:54
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
Comment By: stffn (stffn)
Date: 2007-11-10 17:46
Message:
Logged In: YES
user_id=1658640
Originator: YES
Side note: It's amazing what using the/this tracker does to getting bugs
fixed. Especially if it has been bothering some people for 5+ years.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-10 11:05
Message:
Logged In: YES
user_id=27104
Originator: NO
Oops, I should correct myself, it's "-highlightthickness" rather than
"-highlightborder".
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-10 00:40
Message:
Logged In: YES
user_id=27104
Originator: NO
found the source of the 2px growing bug, basically, Tk was automatically
drawing a 2px "highlightborder" around the canvas, and would return that
value
sometimes, I don't really know the details. But by setting
"-highlightborder
0" and then removing the 2px adjustment code, it fixes the bug on my
computer. Tested on Pd-0.40.3-extended on Mac OS X and 0.41-test06 on
Ubuntu gutsy.
File Added: fix_2px_growing_canvas-0.41-test06.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1829055&group_…
Patches item #1833178, was opened at 2007-11-16 09:56
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1833178&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: oskude (oskude)
Assigned to: Miller Puckette (millerpuckette)
Summary: arrow keys update scrollbars
Initial Comment:
this patch _always_ updates the scrollbars when moving objects with the arrow keys. a "better" patch would be to only update scrollbars if we are getting bigger than the current canvas size.
and for long shot, maybe we should do this all in canvas_displaceselection anyway...
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:51
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-26 17:46
Message:
Logged In: YES
user_id=27104
Originator: NO
I added this change as described in my previous comment to
branch-0-40-extended.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-16 13:52
Message:
Logged In: YES
user_id=27104
Originator: NO
It looks to me that this should definitely be included directly in
canvas_displaceselection():
sys_vgui("pdtk_canvas_getscroll .x%lx.c\n", x);
Then this could probably be removed from canvas_mouseup():
if (x->gl_editor->e_onmotion != MA_NONE)
sys_vgui("pdtk_canvas_getscroll .x%lx.c\n", x);
My only concern is that this could slow things down on older machines,
since it would be running pdtk_canvas_getscroll a low more.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1833178&group_…
Patches item #1551825, was opened at 2006-09-04 04:17
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1551825&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Out of Date
Priority: 7
Private: No
Submitted By: oskude (oskude)
Assigned to: Miller Puckette (millerpuckette)
Summary: autoscrollbars
Initial Comment:
autoscrollbars patch for pd cvs. dunno how good the
code is, but it works :)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:50
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 23:23
Message:
Logged In: YES
user_id=313747
Originator: NO
oops,. then un-took it again, since it was acting funny (scrollbars
appeared and disappeared constantly when clicking inside the canvas
help window)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-13 19:02
Message:
Logged In: YES
user_id=27104
Originator: NO
works for me, checking into branch-v0-40-extended (FYI: this patch
replaces the old one)
----------------------------------------------------------------------
Comment By: oskude (oskude)
Date: 2007-11-13 18:39
Message:
Logged In: YES
user_id=1383707
Originator: YES
pd_autoscrollbars_2007-11-14.patch
- should fix #1830767 (Slide bars don't update automatically)
- moved code to pdtk_canvas_getscroll, thanks for the tip!
+ a new, empty patch should not have scrollbars
File Added: pd_autoscrollbars_2007-11-14.patch
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-13 02:29
Message:
Logged In: YES
user_id=27104
Originator: NO
I think this functionality should probably be incorporated into
pdtk_canvas_getscroll in u_main.tk since it gets called on button release.
This should help with bug #1830767
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-12 19:59
Message:
Logged In: YES
user_id=27104
Originator: NO
This patch works well for resize events, but it prevents the scrollbars
from working properly when cutting, pasting, and adding objects. I'd like
to keep it in, but it needs to be fixed.
See bug #1830767
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2006-09-18 09:19
Message:
Logged In: YES
user_id=27104
One other thing that would be fixed ideally. This problem
existed before this patch, but its related. If a patch is
bigger than the window, the scrollbars are not displayed
when that patch is opened. You have to resize the window,
then the scrollbars will display.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2006-09-16 13:07
Message:
Logged In: YES
user_id=27104
Very nice! My only comment is that it is a couple pixels
off on Mac OS X 10.4/Pd-extended 0.39.2-test5. I can cover
about 3 pixels before the scrollbars kick in.
I added to the Pd-extended build system as
pure-data/packages/patches/pd_autoscrollbars-0.40-pre.patch
It will be in the nightly builds starting tomorrow.
----------------------------------------------------------------------
Comment By: oskude (oskude)
Date: 2006-09-15 04:09
Message:
Logged In: YES
user_id=1383707
this patch removes scrollbars in a pd-patch canvas window
when the content is smaller than the window size.
and add scrollbars to pd-patch window if content bigger than
window size.
works individually for height(bottom scrollbar) and
width(right scrollbar)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2006-09-13 15:26
Message:
Logged In: YES
user_id=27104
can you elaborate on what this patch does?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1551825&group_…