Patches item #1881907, was opened at 2008-01-29 11:24
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1881907&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmlnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: more t_float/t_sample fixes
Initial Comment:
pd-0.41 has a lot of cleanup regarding the types of numbers (see patch-#1822001 'use of t_float/t_sample instead of "float"')
however, some things have been left out by the original patches, here are some more:
m_pd.h:
seems like the t_float-enabling of postfloat() was forgotten in the declaration
d_math.c:
here it is the other way round: while the declarations in m_pd.h use t_float, the definitions do not
g_array.c g_template.c:
here my patch was a bit rash: scanf() doesn't like to get pointers to double (if "t_float" is set to "double") if the format string is really "%f" (or "%g"); the new patches use an internal _double_ variable and the format string "%lf" ("%lg"); the _double_ variable is then cast to (t_float).
this should be on the save side; the alternatives would have been using an internal _float_ variable, and/or to change the format-string depending on the used type.
d_fftroutine.c: this needed a bit more changes, but luckily enough, the original code already was aware of possible type-changes; i have currently used "t_float" (in line with the m_pd.h declaration of "pd_fft()"), but i am not sure whether this really should be "t_sample".
changes should be rather simple: just change the defines of FLOAT and SAMPLE in the beginning... (and don't forget the declaration in m_pd.h)
with these changes, Pd compiles without (additional) warnings with t_float/t_floatarg and t_sample set to "double".
(there is still work to do in d_ugen.c though, to make it really usable...)
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:43
Message:
it seems that some of this stuff has been accepted and some not, perhaps
they should be reformated?
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:54
Message:
Logged In: YES
user_id=564396
Originator: YES
File Added: sigmund~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:12
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/sigmung~
File Added: sigmund~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:11
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for pique
File Added: pique.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:09
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/lrshift~
File Added: lrshift~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:08
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/loop~
(the core code originally was not dependent on Pd; i therefore introduced
an additional "#define t_sample float" in case it is not compiled for Pd)
File Added: loop~.c.diff
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-01-29 12:06
Message:
Logged In: YES
user_id=564396
Originator: YES
added a fix for extra/choice
File Added: choice.c.diff
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1881907&group_…
Patches item #2584887, was opened at 2009-02-10 07:12
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2584887&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Frank Barknecht (fbar)
Assigned to: Miller Puckette (millerpuckette)
Summary: bonk ignores relative paths when reading templates
Initial Comment:
bonk~ can not open previously stored attack templates when only a relative path is supplied to the "read templates.txt" message.
bonk~ also ignores any [declare] declarations when searching for template files and only works with absolute paths or templates in the working directory PPd was started from.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:35
Message:
This seems like it might be a duplicate of patch #1242459
https://sourceforge.net/tracker/?func=detail&aid=1242459&group_id=55736&ati…
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-02-15 23:29
Message:
one detail: MAXPDSTRING is longer than FILENAME_MAX on Windows, so to
prevent crasher bugs, any time a file path is stored, FILENAME_MAX should
be used instead of MAXPDSTRING.
----------------------------------------------------------------------
Comment By: Frank Barknecht (fbar)
Date: 2009-02-10 11:07
Message:
Okay, attached is a patch that changes the "read" and "write" messages to
use canvas-relative paths. Tested only briefly, but seems to work. Diff
against current SVN HEAD.
File Added: bonk~.c.diff
----------------------------------------------------------------------
Comment By: Frank Barknecht (fbar)
Date: 2009-02-10 07:19
Message:
bonk~ should probably use the canvas_open() method to open files instead of
a plain fdopen()
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2584887&group_…
Bugs item #1186531, was opened at 2005-04-20 05:13
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1186531&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: Tim Blechmann (timblech)
Assigned to: Nobody/Anonymous (nobody)
Summary: crash when using donecanvasdialog message
Initial Comment:
hi all ...
pd crashes, if i send a donecanvasdialog message to a
closed subpatch:
|;pd-mysubpatch donecanvasdialog 0 0 1(
works fine (switching on gop)
|;pd-mysubpatch donecanvasdialog 0 0 0(
results in:
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 16384 (LWP 11495)]
0x0805f3d3 in glist_findrtext (gl=0x0, who=0x83dc7f8)
at g_rtext.c:332
332 t_rtext *x = gl->gl_editor->e_rtext;
(gdb) where
#0 0x0805f3d3 in glist_findrtext (gl=0x0,
who=0x83dc7f8) at g_rtext.c:332
#1 0x0805a23d in graph_vis (gr=0x83dc7f8,
parent_glist=0x83dc718, vis=0) at g_graph.c:665
#2 0x0805a1e5 in graph_vis (gr=0x83dc718,
parent_glist=0x84808d0, vis=138266616) at g_graph.c:804
#3 0x0806c81c in canvas_setgraph (x=0x83dc718, flag=0)
at g_editor.c:830
#4 0x0806c8a7 in canvas_donecanvasdialog (x=0x83dc718,
xperpix=-nan(0x7fffff), yperpix=1,
fgraphme=-nan(0x7fffff)) at g_editor.c:872
#5 0x08085671 in pd_typedmess (x=0x83dc718,
s=0x83dc8f8, argc=0, argv=0x8108428) at m_class.c:815
#6 0x080882a4 in binbuf_eval (x=0x0, target=0x83dc718,
argc=1, argv=0xbff3d9b0) at m_binbuf.c:597
#7 0x0805bfd0 in message_float (x=0x83dc7f8, f=0) at
g_text.c:300
#8 0x0808653d in outlet_float (x=0x0, f=0) at m_obj.c:431
#9 0x0807ca3e in toggle_bang (x=0x83de2e8) at
g_toggle.c:250
#10 0x0807cbbe in toggle_newclick (z=0x0,
glist=0x84808d0, xpix=511, ypix=328, shift=0, alt=0,
dbl=0, doit=1)
at g_toggle.c:282
#11 0x0806e14b in canvas_doclick (x=0x84808d0,
xpos=511, ypos=328, which=1, mod=0, doit=1) at
g_editor.c:1036
#12 0x0806eb6a in canvas_mousedown (x=0x0, xpos=511,
ypos=328, which=1, mod=0) at g_editor.c:1209
#13 0x08085671 in pd_typedmess (x=0x84808d0,
s=0x83dc8f8, argc=0, argv=0x8108408) at m_class.c:815
#14 0x080852b3 in pd_typedmess (x=0x83dcce0,
s=0x83dc8f8, argc=4, argv=0x81083e8) at m_class.c:836
#15 0x080882a4 in binbuf_eval (x=0x0, target=0x83dcce0,
argc=0, argv=0x0) at m_binbuf.c:597
#16 0x0808e7eb in socketreceiver_read (x=0x822b6a0,
fd=5) at s_inter.c:537
#17 0x0808d9fa in sys_domicrosleep (microsec=0,
pollem=138266616) at s_inter.c:177
#18 0x0808e404 in sys_pollgui () at s_inter.c:820
#19 0x0808c094 in m_scheduler () at m_sched.c:488
#20 0x0808d841 in sys_main (argc=2, argv=0xbff3f554) at
s_main.c:354
#21 0x080918a6 in main (argc=0, argv=0x0) at s_entry.c:27
cheers ... t
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:28
Message:
Using Pd-devel 0.43 on Mac OS X 10.5.8, I couldn't reproduce this.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2005-06-21 05:58
Message:
Logged In: YES
user_id=564396
i cannot reproduce this.
could you post a patch ? (to pd-dev)?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1186531&group_…
Patches item #1821455, was opened at 2007-10-27 22:36
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1821455&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Out of Date
Priority: 4
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: flags to compile Pd for 64-bit on Mac OS X
Initial Comment:
Whenever Pd is ready to be tested on 64-bit machines, these flags should be added to the build to where the existing "-arch" flags are (both CFLAGS and LDFLAGS):
-arch x86_64 -arch ppc64
In the current HEAD, the pd files build fine with these flags on my Mac Book Pro with 10.4.10. But the build dies on pa_mac_core.c.
These flags will need to go into pd/src/configure.in and pd/extra/makefile.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:17
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1821455&group_…
Patches item #1899317, was opened at 2008-02-21 22:43
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1899317&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Out of Date
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix for new version of JackOSX
Initial Comment:
With the upgrade to JackOSX 0.76, the has a framework with a different name. The old version was called 'Jack.framework', this one is called 'Jackmp.framework'. two lines in configure.in need to reflect this. That's what this patch does.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:16
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-03-20 12:41
Message:
I would like to set up a Pd-vanilla + extended build on Mac OS X, and the
issue fixed by this little patch is making it difficult. Including this
change would make it easy, and would allow Pd+Jack to be usable on Mac OS
X. The new version of JackOSX fixes lots of bugs.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1899317&group_…
Patches item #1844492, was opened at 2007-12-04 19:00
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1844492&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: improved makefile.dependencies generation
Initial Comment:
This patch started with a bug in the MinGW build and then a suggestion from Russell Bryant. In addition to adding this patch, "pd/src/makefile.dependencies" should be removed from CVS.
Basically, this patch monitors $(SRC) and the newly created $(HEADERS) for changes, and if any of those files change, then makefile.dependencies is regenerated (this is still leaving out the portaudio headers).
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:15
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2007-12-17 15:16
Message:
Logged In: YES
user_id=564396
Originator: NO
(oops, incidentally closed...)
make can handle dependencies pretty well, even if there is no
makefile.dependencies yet for inclusion.
the secret is, that make will iterate several times over a makefile in
order to get dependencies right.
that is: when running make it will try to "-include makefile.dependencies"
(the "-" is there to prevent a fatal error because of the missing
makefile), and fail (because of the missing makefile), than it will find a
rule to build the makefile and run it (generating the
makefile.dependencies); then it will re-run itself, include the
makefile.dependencies and thus get the dependencies right.
this is almost the canonical way to use dependencies with make.
the gnu make manual suggest to split the dependencies into several files
(one per c-file)
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 11:54
Message:
Logged In: YES
user_id=313747
Originator: NO
How does this not break the line, "include makefile.dependencies" in
makefile?
That's the reason the empty makefile.dependencies file is in CVS. Of
course,
I'd prefer something better than what's there now.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1844492&group_…
Patches item #1825692, was opened at 2007-11-04 15:20
Message generated for change (Settings changed) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1825692&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix up panel keybindings and findpanel font selection
Initial Comment:
this patch:
- makes standard key bindings on all the panels (find, prefs, etc)
- adds live font resizing to the font panel
- adds a checkbox to turn on/off text in Pd window
- adds menu item to clear the Pd window's text
- adds Ctrl/Cmd-B to open Help Browser
- add the standard menus to the Pd window
Applies cleanly on 0.40.3 and 0.41-test06. Tested on 0.40.3 on Mac OS X, included in Pd-extended.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:07
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-11-05 20:51
Message:
Logged In: YES
user_id=27104
Originator: YES
Oops, found a bug in the find panel handling, this fixes it:
@@ -1933,8 +1968,9 @@
}
proc pdtk_canvas_dofont {name initsize} {
-
- global dofont_fontsize
+ global fontsize dofont_fontsize
+ set fontsize $initsize
+ set dofont_fontsize $initsize
global stretchval
set stretchval 100
@@ -1982,6 +2018,9 @@
pack $name.radiof.radio24 -side top -anchor w
pack $name.radiof.radio36 -side top -anchor w
+ set current_radiobutton [format "$name.radiof.radio%d" $initsize]
+ $current_radiobutton select
+
frame $name.stretchf
pack $name.stretchf -side left
@@ -3495,7 +3534,7 @@
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1825692&group_…
Patches item #1825460, was opened at 2007-11-04 02:42
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1825460&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: support for custom color schemes
Initial Comment:
This patch sets up a series of variables in pd.tk that can tailor the whole color scheme of Pd patches. It also allows signal and message inlets/outlets to be drawn differently.
It is included in Pd-0.40.3-extended. The only difference being that the version attached here has the default colors for pd-vanilla.
It applies cleanly to 0.40.3. It only needs a minor change for 0.41-test06 in g_scalar.c.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:07
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1825460&group_…
Patches item #1775023, was opened at 2007-08-15 18:35
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1775023&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: use Tcl's normalize to clean up pd_guidir on OSX and Win32
Initial Comment:
A minor cleanup to simplify pd_guidir using Tcl's [file normalize] on Mac OS X and Win32.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:07
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-09-01 23:56
Message:
[file normalize] was introduced in 8.4...
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-12-17 12:01
Message:
Logged In: YES
user_id=313747
Originator: NO
"file normalize" seems to be newer than at least one Tk I'm running.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1775023&group_…
Patches item #1760624, was opened at 2007-07-25 18:01
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1760624&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Out of Date
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: font/box size overhaul with properties panel clean-up
Initial Comment:
This patch includes everything from branch-v0-39-2-extended to make the fonts and boxes the same size on every platform.
The default font is changed to Monaco on Mac OSX (included with the OS) and Bitstream Vera Sans Mono on Windows and GNU/Linux (included with GNOME). The font is free as in speech and beer, so it can be distributed with any Pd package.
The iemgui properties panels were also changed to reflect the new fonts, plus they were cleaned up a bit to make them more readable.
It applies cleanly, builds and seems to work fine on 0.40.3 and 0.41.0-test04.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 20:06
Message:
This patch has either been incorporated into pd-gui-rewrite pd-devel 0.43
or made irrelevant by it.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-08-03 03:00
Message:
Logged In: YES
user_id=27104
Originator: YES
oops, a bit of the libquicktime patch snuck into this one, I removed it.
File Added: make_sizes_pixel_accurate_on_every_platform-0.40.3.patch
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-07-30 20:58
Message:
Logged In: YES
user_id=27104
Originator: YES
File Added: make_sizes_pixel_accurate_on_every_platform-0.40.3.patch
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2007-07-29 23:03
Message:
Logged In: YES
user_id=27104
Originator: YES
I have an Ubuntu box, and I saw this too. It only happens on GNU/Linux,
10 and 12 are different sizes on Windows and Mac OS X. I had it fixed for
the Pd-0.39.2-extended, but the font handling changed on 0.41, and I didn't
figure out how to adapt the new font handling. My guess is that the font
measurement code works different on GNU/Linux, so it's chosing a different
font.
The workaround is to do some kind of ifdef for GNU/Linux and force the
font size for the one that's sized wrong. That's how I did it on
Pd-0.39.2-extended.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2007-07-29 19:44
Message:
Logged In: YES
user_id=313747
Originator: NO
This did something funny on my machine (fedora 6). "10" and "12"
show up with the same font size, and/but boxes sized differently
(in 12 point, not fitting the un-enlarged text). I'll bring the
machine to Montreal so we can look...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1760624&group_…