Patches item #3032844, was opened at 2010-07-21 16:06
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3032844&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ClaudiusMaximus (claudiusmaximus)
Assigned to: Nobody/Anonymous (nobody)
Summary: Sort method tables by symbol and use binary search
Initial Comment:
Sort method tables by symbol and use O(log(N)) binary search instead of an O(N) linear search. This should speed up calling existing methods but it might slow down adding new methods.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2010-08-17 20:50
Message:
I once profiled Pd loading a large patch and found that a tiny percentage
of the CPU
time spent was method searching... are there situations where this makes
an important difference?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3032844&group_…
Patches item #3032363, was opened at 2010-07-20 17:54
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3032363&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Accepted
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: full UTF-8 support for 0.43
Initial Comment:
This patch aims to make Pd fully UTF-8 compliant in all parts, written by Bryan Jurish. Miller, we reviewed this patch at ICMC and it looks straightforward.
I refactored Bryan Jurish's pd-gui-rewrite-0.43.utf8-moo-2010-01-19.full.diff for 0.43, the patch is from here http://lists.puredata.info/pipermail/pd-dev/2010-01/014732.html
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2010-08-17 20:38
Message:
Dunno how the $*&%^$ this works but it's wonderful to look at the test
patch.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-20 17:55
Message:
I forgot to add, Tcl/Tk 8.5 is required for full UTF-8 support.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3032363&group_…
Patches item #3031833, was opened at 2010-07-19 14:43
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3031833&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: updated helpbrowser.tcl
Initial Comment:
I used helpbrowser.tcl in Pd-extended 0.42.5 and fixed a bunch of bugs there. This is the Pd-extended 0.42.5 helpbrowser.tcl ported to git/0.43
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-08-02 07:17
Message:
Things like not looking in the entire path for libraries, sometimes
libraries showing up twice, etc.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2010-08-02 05:05
Message:
could you provide any information on what those "bunch of bugs" is about?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3031833&group_…
Patches item #3011285, was opened at 2010-06-03 16:54
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3011285&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix gl_goprect logic
Initial Comment:
Based on a patch from Ivica Ico Bukvic, this change seems to help the GOP red rectangle get set more accurately, and according to Ivica also helps with other GOP bugs. I checked it into Pd-extended 0.42.5 here:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=135…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3011285&group_…
Patches item #2958837, was opened at 2010-02-25 09:10
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2958837&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Martin Peach (mrpeach)
Assigned to: Miller Puckette (millerpuckette)
Summary: Fix bendout on alsa
Initial Comment:
Using ALSA MIDI on linux, the [bendout] object takes input between -8192 and 8191 but the output is scrambled because it is sent as signed instead of offset.
This patch sends -8192 - 8191 as 0 - 16384 as per the spec.
[bendin] still needs to have 8192 subtracted from its outlet on _UNIX and _WIN32 at least.
----------------------------------------------------------------------
Comment By: Martin Peach (mrpeach)
Date: 2010-02-25 09:16
Message:
Er, that should read "This patch sends -8192 through 8191 as 0 through
16383"
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2958837&group_…
Patches item #2952880, was opened at 2010-02-16 08:33
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2952880&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Martin Peach (mrpeach)
Assigned to: Miller Puckette (millerpuckette)
Summary: a partial float fix
Initial Comment:
Pd currently doesn't store floats to their full precision because atom_string uses the %g format specifier to print them into the binbuf.
As a result 24-bit numbers lose precision.
This patch changes the format specifier to %f and also adds a routine to chop off trailing zeros and the decimal point if nothing is to the right of it.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2952880&group_…
Patches item #2946742, was opened at 2010-02-05 11:39
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2946742&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: BUGFIX: [bang( to [expr size("$s1")] crashes pd
Initial Comment:
tested in 0.43.0-devel-20100126 and 0.42-5 on winxp. Sending an initial bang before setting $s1 to a value crashes pd.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2010-03-17 02:45
Message:
the problem comes from ISTABLE() correctly checking for a NULL-symbol, but
then accessing the s_name field anyhow.
attached patch fixes this
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2946742&group_…
Patches item #2929284, was opened at 2010-01-10 05:36
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2929284&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Miller Puckette (millerpuckette)
Summary: bang to switch~ while dsp off: Pd exits
Initial Comment:
When a bang is sent to the switch~ object while dsp is turned off (after having been on at least once since start up of Pd), Pd will exit with segmentation fault. This was tested with Pd extended 0.41.4 on OSX 10.5 and on Linux Ubuntu. I guess the bug could be fixed by extending the conditional check in the bang method for block~/switch~:
if(x->x_switched && !x->x_switchon && canvas_dspstate)
(reported anonymously by Katja Vetter)
----------------------------------------------------------------------
Comment By: Katja (katjav)
Date: 2010-02-15 04:24
Message:
Hans, I suggested a check on canvas_dspstate because it seems to be a
global variable reflecting the dsp status of all root canvases. glob_dsp
uses it as well.
This suggestion was tested in Pd 0.41 on a Kubuntu system. With the
modification, the switch~ object in an encapsulated subpatch switches dsp
from off to on for one signal block, like it should do, and without Pd
crashing. Apparently I overlooked conditions where it does not work, since
it did not work for you.
Anyway, a check on dsp_chain does the job. Thanks.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-02-14 22:45
Message:
I added a patch to add a warning error when switch~ is banged and the DSP
is off, instead of crashing. It is also checked into Pd-extended 0.42.5:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=131…
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-02-13 16:35
Message:
It seems that dsp_chain is the issue, so the code should be perhaps
something like
if (x->x_switched && !x->x_switchon && dsp_chain)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-02-13 16:25
Message:
Reproduced using Pd-extended 0.42.5-20100120 pd-gui-rewrite/0.43 on Mac OS
X 10.5.8/Intel. Here's the stacktrace:
0 pd 0x0006b3e3 block_bang + 78
(d_ugen.c:227)
1 pd 0x00056eb4 outlet_bang + 56
(m_obj.c:370)
2 pd 0x0003e79c bng_newclick + 153
(g_bang.c:299)
3 pd 0x000378c8 canvas_doclick + 594
(g_editor.c:110)
4 pd 0x00038572 canvas_mousedown + 61
(g_editor.c:1440)
5 pd 0x00054e09 pd_typedmess + 1141
(m_class.c:792)
6 pd 0x00054ccf pd_typedmess + 827
(m_class.c:818)
7 pd 0x00058f5c binbuf_eval + 1224
(m_binbuf.c:726)
8 pd 0x00063232 socketreceiver_read + 1734
(s_inter.c:558)
9 pd 0x00061df2 sys_domicrosleep + 381
(s_inter.c:196)
10 pd 0x00061e7e sys_microsleep + 19
(s_inter.c:219)
11 pd 0x0005f004 m_mainloop + 1030
(m_sched.c:587)
12 pd 0x00061b21 sys_main + 2909
(s_main.c:304)
13 pd 0x00002852 _start + 216
14 pd 0x00002779 start + 41
Can you explain the addition of canvas_dspstate? For me, this change just
makes it so bang never turns on the canvas-local DSP.
----------------------------------------------------------------------
Comment By: Katja (katjav)
Date: 2010-02-13 15:37
Message:
Above-mentioned bug exists in Pd 0.42-4 as well. I have checked that the
problem is indeed solved with the following (where d_ugen_old.c is the
original file and d_ugen.c the modified version):
diff d_ugen_old.c d_ugen.c
222c222
< if (x->x_switched && !x->x_switchon)
---
> if (x->x_switched && !x->x_switchon && canvas_dspstate)
Hope this bug will be fixed soon cause I want to share a patch including
the switch~ object.
Katja
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2929284&group_…
Patches item #2936486, was opened at 2010-01-21 09:38
Message generated for change (Settings changed) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2936486&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: add broadcast support to netsend/netreceive
Initial Comment:
Add support for broadcast addresses to make it possible to use netsend/netreceive without having to set any IP. a 255.255.255.255 broadcast address will work on any IP range, including auto-assigned 169.254.0.0/16 addresses.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2936486&group_…
Patches item #2913280, was opened at 2009-12-12 14:08
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2913280&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: Fixed
Priority: 8
Private: No
Submitted By: Cyrille Henry (nusmuk)
Assigned to: Miller Puckette (millerpuckette)
Summary: GOP abstraction can crash pd if content is reloaded
Initial Comment:
if abs1 is an abstraction (maybe empty)
if abs2 is a GOP abstraction that use abs1
opening an other instance of abs1 and saving it will crash pd.
see attachement.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2010-08-18 02:48
Message:
I'm going to see if I can fix the bug better (the patch here simply refuses
to reload abstractions
under certain conditions which I think is wrong.)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-13 03:41
Message:
The bug is that canvas_doclear() wasn't checking whether x->gl_editor
exists before using it. Here's a patch to fix it, committed to Pd-extended
in svn commit #13707:
Index: g_editor.c
===================================================================
--- g_editor.c (revision 13704)
+++ g_editor.c (working copy)
@@ -2212,7 +2212,7 @@
int dspstate;
dspstate = canvas_suspend_dsp();
- if (x->gl_editor->e_selectedline)
+ if (x->gl_editor && x->gl_editor->e_selectedline)
{
canvas_disconnect(x, x->gl_editor->e_selectline_index1,
x->gl_editor->e_selectline_outno,
@@ -2229,7 +2229,7 @@
/* if text is selected, deselecting it might remake the
object. So we deselect it and hunt for a "new" object on
the glist to reselect. */
- if (x->gl_editor->e_textedfor)
+ if (x->gl_editor && x->gl_editor->e_textedfor)
{
newest = 0;
glist_noselect(x);
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-06-14 19:37
Message:
Confirmed on Mac OS X/10.5.8 Intel using Pd-extended 0.42.5-rc2.
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2009-12-12 14:49
Message:
confirmed (linux; Pd-vanilla-0.42.5)
it does _not_ crash on 0.41-4 on the same machine.
a quick backtrace shows that the crash appears in canvas_doclear() because
the gl_editor of the argument x is NULL.
----------------------------------------------------------------------
Comment By: Cyrille Henry (nusmuk)
Date: 2009-12-12 14:09
Message:
i forget to say that this is on linux, pd vanilla 0.42
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2913280&group_…