Patches item #3051663, was opened at 2010-08-23 16:45
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3051663&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
Status: Closed
Resolution: Accepted
Priority: 6
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Martin Peach (mrpeach)
Summary: make slipdec reassemble arbitrary packages
Initial Comment:
current slipdec doesn't work if the SLIP encoded package is not presented as a single list
(which kind of defeats the idea of SLIP, which is to paketize a _stream_ of data)
with the attached patch, [slipdec] is able to decode a stream even if it was [1, 192 2, 3 4, 5 192, 6, 192(
before applying and committing the patch, please have a close look at it.
for now, i just disabled the "valid" output (because it doesn't make so much sense anyhow, a SLIP stream is almost always valid)
i know think that the flag could indicate whether there is still data waiting in the queue (and is updated after each message received)
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2011-06-29 10:18
Message:
cv3Rn7 <a href="http://ekrpyxjljese.com/">ekrpyxjljese</a>,
[url=http://rqdebmgsgkcz.com/]rqdebmgsgkcz[/url],
[link=http://mmjdgstckugp.com/]mmjdgstckugp[/link],
http://lohwgqixxgzg.com/
----------------------------------------------------------------------
Comment By: SourceForge Robot (sf-robot)
Date: 2010-09-29 19:30
Message:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Martin Peach (mrpeach)
Date: 2010-08-26 20:34
Message:
Maybe it should output the size of the queue, so zero would mean a complete
packet.
Valid was supposed to mean that all the input was equivalent to bytes,
i.e. no floating point, symbols, etc.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3051663&group_…
Now that the core Pd docs (i.e. /usr/lib/pd/doc/*) are split out into a
separate Debian package, I think it could make sense to package the PDDP
docs in a kind of mirror or replacement package. Something like
pddp-doc. Jonathan, in particular, I was thinking that since you have
wanted to work on all the patches there, we could set it up so the
pddp-doc package mirrors the whole /usr/lib/pd/doc* directory and patch
structure, have this in SVN, git, or whatever somewhere. Then people
could choose the pddp-doc package if they so choose.
Here's the files in puredata-doc:
http://packages.debian.org/sid/all/puredata-doc/filelist
.hc
Patches item #3307639, was opened at 2011-05-25 13:17
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3307639&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
>Status: Pending
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Alexandre Castonguay (alxe)
>Assigned to: Hans-Christoph Steiner (eighthave)
Summary: updated FR localization
Initial Comment:
Mise à jour de la localisation française
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-06-27 16:44
Message:
Ok, I added this to Pd-extended. Be very careful to not copy things that
are not being translated. I.e. if "DSP" is going to remain "DSP", then it
should look like this:
msgid "DSP"
msgstr ""
NOT like this:
msgid "DSP"
msgstr "DSP"
There are a number of reasons to do this. This is the way the PO system
expects, msgstr "" means use the original text. Also, having the "DSP",
etc. duplicated caused a weird bug where the Log menu on the Pd Window was
not showing up which took me about an hour to figure out :(. And lastly,
it will help your translation, since tools like POedit will show you which
lines have not been translated.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3307639&group_…
Bugs item #3337413, was opened at 2011-06-27 15:51
Message generated for change (Tracker Item Submitted) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=3337413&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-devel
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: Big system lock won't be released in some circumstances
Initial Comment:
i'm currently working on some threading support in Gem, where i use sys_lock()/sys_unlock() to protect my calls to clock_delay().
while testing i noticed that the syslock was never unlocked by Pd in certain circumstances:
- i was using no audio (SCHED_AUDIO_NONE)
- my patch used up quite a lot of CPU (rendering a teapot without openGL acceleration)
in my worker-thread i called "sys_lock()", and i never got beyond this point.
after a lot of searching i found the reason:
in the mainloop, Pd will call sys_unlock() ONLY if it has a valid audio-backend OR it has idletime ("unlock while we are idle")
in my case, neither was true (the latter, because one of the cores was busy rendering a teapot)
this is unexpected behaviour since:
- i'm using multiple threads to get more performance out of my multicore system; if i moved all the work done by the helper thread into the main thread (to avoid the use of syslock) performance would be dramatically worse
- when i chose an(y) audio-backend, my helper threads will be unlocked, even though using audio could be expected to take even more time to calculate (hence an additional thread can be seen as even more undesireable when running under full load)
suggested solutions:
- when no audio-backend is used, the syslock should be unlocked/locked, so waiting threads have a chance to get scheduled
AND/OR
- get rid of the big system lock; in my special case it would be enough to have a thread-safe version of clock_delay() see [1] for a patch that implements this
attached is a patch (against current git) that unlocks the syslock for a tiny period (and immediately locks it again) when using no audio backend, so waiting threads get a chance to be scheduled by the OS.
[1] thread save clocks: https://sourceforge.net/tracker/?func=detail&aid=3322973&group_id=55736&ati…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=3337413&group_…
Patches item #3322973, was opened at 2011-06-20 11:59
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3322973&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata-dev
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: make clocks thread safe
Initial Comment:
when writing threaded externals, i often find myself wanting Pd to call a callback from the main thread, depending on the "other" thread's state.
e.g. when doing asynchronous data acquisition, i want to notify Pd when new data has arrived, so it can be delivered in the main thread.
the obvious way is to use t_clock, and registers a new clock_delay() event from within the helper-thread; Pd will then callback in the next tick.
unfortunately the clock_set(),... methods are not thread safe, possibly leading to corruption of the clock_setlist when accessing them simultaneously.
one workaround is to use the global sys_lock(), but i find this to terribly slow down the entire Pd process, esp. when i have to call sys_lock() multiple times before ticks. that's most likely because sys_lock() locks about everything.
an alternative i used in the past, is to have a special (mutex-protected) flag, indicating whether i already have a clock running that is waiting to be called back from the main thread.
however, i find this quite complicated
therefore, i propose to make the clock_delay/clock_set/clock_unset methods threadsafe, by internally maintaining a separate mutex that solely protects the clock_setlist.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2011-06-20 13:24
Message:
just a few final words:
the problem i describe can well be solved with sys_lock()
however this creates a "Big Kernel Lock", potentially affecting
performance.
my proposal is to use finer grained locking, to avoid problems with the
BIG syslock.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2011-06-20 13:19
Message:
i have also written a small external that illustrates the problem.
find it in the "threadclock.tgz" archive, and compile it.
the object will create a number of threads (use the argument to specify
how many threads you want);
each thread will sleep for a short time (100ms or so), and then call
clock_delay() to wake up the object from the main thread.
sooner or later, this will crash Pd; using my path it won't
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2011-06-20 12:05
Message:
attached is a first draft (against todays git master)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3322973&group_…
Patches item #3336039, was opened at 2011-06-27 05:11
Message generated for change (Comment added) made by elgusanorojo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3336039&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix Windows non-starting
Initial Comment:
Removed bizarre 'k' character in 'package' command, causing Windows to not start. This was in the proc get_config_win in tcl/pd_guiprefs.tcl. My smallest patch ever, literally changing one character ;)
----------------------------------------------------------------------
>Comment By: Yvan Volochine (elgusanorojo)
Date: 2011-06-27 12:34
Message:
oops, my mistake (k with an accent), thanks for spotting.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3336039&group_…
Patches item #3336039, was opened at 2011-06-26 23:11
Message generated for change (Tracker Item Submitted) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3336039&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fix Windows non-starting
Initial Comment:
Removed bizarre 'k' character in 'package' command, causing Windows to not start. This was in the proc get_config_win in tcl/pd_guiprefs.tcl. My smallest patch ever, literally changing one character ;)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3336039&group_…
Bugs item #3335742, was opened at 2011-06-27 00:32
Message generated for change (Tracker Item Submitted) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=3335742&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: cant type in help-> search menu
Initial Comment:
Not sure why, but I am unable to type in the search box under the help menu. Was able to do once before.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=3335742&group_…
Patches item #3335390, was opened at 2011-06-26 21:32
Message generated for change (Tracker Item Submitted) made by patricecolet
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3335390&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Patko (patricecolet)
Assigned to: Nobody/Anonymous (nobody)
Summary: mp3amp~ win32
Initial Comment:
this patch resolve a conflicting BOOL in unauthorized mp3amp~ win32 build
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3335390&group_…