Patches item #3587404, was opened at 2012-11-14 22:29
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587404&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: ability to start multiple pd-guis
Initial Comment:
starting with Pd-0.43, pd-gui checks whether it is already running and tries to reconnect to the existing one.
while this is ok in some situations, it is an issue in other situations:
- when starting multiple instances of Pd on different desktops (i'm using the xfce window manager), the new instance will automatically focus the desktop of the already-running instance, which makes it difficult to separate those instances again (assuming that each instance has a number of windows open on startup)
- when using pd-gui to connect to a remote pd-core (while another instance of Pd is running on the same machines) is practically prohibited by this behaviour
it would be great if one could turn of this feature (at least when starting from the cmdline; and esp. when a <remotehost>:<remotport> is given...currently there is onl a check for remotport>5400 (when starting without <remotehost>)
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-17 09:37
Message:
I don't think that's a good enough test. The one you removed is much
stricter: $argc == 1 When pd starts pd-gui, it only sends one arg: the
port number. If you want this to affect only remote connections, shouldn't
you make the test based on ::host?
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-12-17 08:37
Message:
attached is a patch (against todays git/master) that doesn't try to connect
to a running instance if the user provided a remoteport to connect to.
it re-uses the logic already implemented in parse_args().
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-14 20:25
Message:
Since you are the master of remote pd-guis, IOhannes, I'm assigning this to
you. It makes sense to me to base it on the host:port arg.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587404&group_…
Patches item #3587404, was opened at 2012-11-14 22:29
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587404&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata
>Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
>Assigned to: Miller Puckette (millerpuckette)
>Summary: ability to start multiple pd-guis
Initial Comment:
starting with Pd-0.43, pd-gui checks whether it is already running and tries to reconnect to the existing one.
while this is ok in some situations, it is an issue in other situations:
- when starting multiple instances of Pd on different desktops (i'm using the xfce window manager), the new instance will automatically focus the desktop of the already-running instance, which makes it difficult to separate those instances again (assuming that each instance has a number of windows open on startup)
- when using pd-gui to connect to a remote pd-core (while another instance of Pd is running on the same machines) is practically prohibited by this behaviour
it would be great if one could turn of this feature (at least when starting from the cmdline; and esp. when a <remotehost>:<remotport> is given...currently there is onl a check for remotport>5400 (when starting without <remotehost>)
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-12-17 08:37
Message:
attached is a patch (against todays git/master) that doesn't try to connect
to a running instance if the user provided a remoteport to connect to.
it re-uses the logic already implemented in parse_args().
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-14 20:25
Message:
Since you are the master of remote pd-guis, IOhannes, I'm assigning this to
you. It makes sense to me to base it on the host:port arg.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3587404&group_…
Patches item #3596865, was opened at 2012-12-17 02:58
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596865&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: None
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: re-adding sys_close() for ABI compatibility
Initial Comment:
in a recent patch to Pd-0.44, the sys_close() function was removed (and replaced by a macro to close()) on non-w32 platforms.
this breaks ABI-compatibility for externals that use sys_close() and have been compiled against Pd-0.43 (e.g. Gem, as currently packaged in Debian).
the attached patch re-introduces sys_close() and also provides implementations for sys_open(), sys_fopen() and sys_fclose() on non-w32 platforms.
the patch reduces the total number of ifdefs in the code :-)
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-17 07:43
Message:
makes sense to me, I'm including it in Pd-extended
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-12-17 03:05
Message:
raising priority since it really prevents some externals from being loaded
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596865&group_…
Patches item #3596868, was opened at 2012-12-17 03:11
Message generated for change (Tracker Item Submitted) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596868&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: use HAVE_STDINT_H for including stdint.h
Initial Comment:
this is a follow-up for commit:5459876b16 that includes stdint.h.
the patch uses HAVE_STDINT_H to include the header, and only uses hand-crafted types as fallbacks (i envision the time when MSCV will be C99 compatible!)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596868&group_…
Patches item #3395438, was opened at 2011-08-20 11:16
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395438&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: minor compat fixes for new buildsystem
Initial Comment:
some problems have been reported [1], because the old configure based buildsystems in some rare cases conflicts with the new autotools based buildsystem.
the problem only appears on systems with case-insensitive filesystems (w32, osx), where the new buildsystem might be tricked into used src/makefile.in rather than src/Makefile.in
imo, the best solution would be to get rid of one of the build-systems entirely (which hopefully means to move to the shiny new one :-))
if this is not feasible for now, the attached patch proposes a workaround, by renaming the conflicting files in the new build system, so they won't clash on case-insensitive filesystems.
here's a longer explanation of the problem and its solution:
right now, there are 2 build-systems, based con autoconf:
- the olde one, living in ./src/, which uses ./src/makefile.in to generate
./src/makefile
- the new one livong in ./, which uses ./src/Makefile.am to generate
./src/Makefile.in to generate ./src/Makefile
the two buildsystems can co-exist happily, except if the host filesystem is
case-insensitive, in which case the "new" buildsystem might be tricked into
using (erroneously) ./src/makefile.in
this patch renames the src/Makefile* (for the new buildsystem) to
src/GNUmakefile*, so there is no name conflict on case-insensitive systems.
NOTE: GNU make will look for the makefiles GNUmakefile, makefile, and Makefile,
in that order. the "old" buildsystem is unaffected, as there will never be a
"GNUmakefile" (only "GNUmakefile.am" and eventually "GNUmakefile.in").
[1] https://sourceforge.net/tracker/?func=detail&atid=478070&aid=3395280&group_…
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-12-17 03:07
Message:
seems like the old buildsystems is gone for good.
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2011-09-21 11:06
Message:
i totally agree with hans.
however, until the old system is ditched, i would still favour if these
workarounds could be added
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2011-09-21 10:59
Message:
I vote for ditching the old build system, I think its quite well tested
these days.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3395438&group_…
Patches item #3596865, was opened at 2012-12-17 02:58
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596865&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: None
Status: Open
Resolution: None
>Priority: 7
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: re-adding sys_close() for ABI compatibility
Initial Comment:
in a recent patch to Pd-0.44, the sys_close() function was removed (and replaced by a macro to close()) on non-w32 platforms.
this breaks ABI-compatibility for externals that use sys_close() and have been compiled against Pd-0.43 (e.g. Gem, as currently packaged in Debian).
the attached patch re-introduces sys_close() and also provides implementations for sys_open(), sys_fopen() and sys_fclose() on non-w32 platforms.
the patch reduces the total number of ifdefs in the code :-)
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2012-12-17 03:05
Message:
raising priority since it really prevents some externals from being loaded
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596865&group_…
Patches item #3596865, was opened at 2012-12-17 02:58
Message generated for change (Tracker Item Submitted) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596865&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmölnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: re-adding sys_close() for ABI compatibility
Initial Comment:
in a recent patch to Pd-0.44, the sys_close() function was removed (and replaced by a macro to close()) on non-w32 platforms.
this breaks ABI-compatibility for externals that use sys_close() and have been compiled against Pd-0.43 (e.g. Gem, as currently packaged in Debian).
the attached patch re-introduces sys_close() and also provides implementations for sys_open(), sys_fopen() and sys_fclose() on non-w32 platforms.
the patch reduces the total number of ifdefs in the code :-)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3596865&group_…
Patches item #3594735, was opened at 2012-12-10 19:14
Message generated for change (Settings changed) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: Win32: unicode support for files with public API for externs
Initial Comment:
Right now, Pd on Windows does really badly if there are any non-ASCII characters in the path or filename. It makes it freeze for a while, and sometimes crashes it. These patches fix that.
Pd and Tcl/Tk is UTF-8 internally, and UNIXes all use UTF-8 for filenames
and paths. Windows uses UCS-2 everywhere, which is a 16-bit format. The
only place this affects Pd is reading and writing filenames, and printing
to the console. The POSIX-style functions open() and fopen() exist on
Windows, but only work for ASCII filenames. To support Unicode filenames,
we have to convert the UTF-8 to UCS-2, then use Win32-specific functions.
Since any external that opens files will also be affected the same
way, this patch provides a public API: sys_open()/sys_close(), and
sys_fopen()/sys_fclose(). For non-Win32 platforms, they are just
names that point to the normal POSIX versions. On Win32, they are
special functions to handle UTF-8 to UCS-2 conversion.
I have built and run this on Windows XP, Mac OS X 10.6, and Debian/squeeze amd64. These patches are also included in Pd-extended 0.43.4.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-16 16:29
Message:
Got 'em & pushed to repo... will re-apply the other patches later.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-16 15:34
Message:
OK -- I'll see if I can unwind the other patch and apply this one - if that
works I'll go and fix the
stdint stuff somehow that I can live with :)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-16 12:28
Message:
I agree that its good to avoid putting #includes in m_pd.h stdint.h is a
stable and widespread as stddef.h, which has been part of m_pd.h for a long
time. I put '#include <stdint.h>" because that's the only header that was
already included everywhere that needs types defined in stdint.h.
Another option would be to put the int32_t, etc. definitions in s_stuff.h
or some other header, and then add that header everywhere its needed.
As for the patches not applying, that's because you accepted 3 patches from
Marvin Humpreys that removes lots of code from s_utf8.* and that conflicts
with these patches.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 18:39
Message:
For some reason I can't apply the first patch (I get:
error: patch failed: src/s_utf8.c:26
error: src/s_utf8.c: patch does not apply
error: patch failed: src/s_utf8.h:1
error: src/s_utf8.h: patch does not apply
--- even though my eyeballs can't see any reason that would fail.
Anyway, I'd like not to have m_pd.h be in the business of pulling in other
include files
(except as needed to define its own data structures) as I think that's a
threat to future
portability - can this be fixed to leave m_pd.h, d_soundfile.h, etc., alone
and just "do the
necessary" to the UTF-8 code?
thanks
Miller
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:44
Message:
These are all the externals in Pd-extended that need changes to support
Unicode filenames:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…
Basically, you just need to change open() to sys_open() and fopen() to
sys_fopen(). You can remove sys_bashfilename() since its included in those
new open functions when needed.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:25
Message:
and a couple more for good measure ;)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 19:37
Message:
I added a fifth patch. Microsoft says that the POSIX close() was deprecated
in 2005, and to use
their ISO C++ _close() instead.
http://msdn.microsoft.com/en-US/library/ms235443(v=vs.80).aspxhttp://msdn.microsoft.com/en-US/library/5fzwd5ss(v=vs.80).aspx
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…
Patches item #3594735, was opened at 2012-12-10 19:14
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: Win32: unicode support for files with public API for externs
Initial Comment:
Right now, Pd on Windows does really badly if there are any non-ASCII characters in the path or filename. It makes it freeze for a while, and sometimes crashes it. These patches fix that.
Pd and Tcl/Tk is UTF-8 internally, and UNIXes all use UTF-8 for filenames
and paths. Windows uses UCS-2 everywhere, which is a 16-bit format. The
only place this affects Pd is reading and writing filenames, and printing
to the console. The POSIX-style functions open() and fopen() exist on
Windows, but only work for ASCII filenames. To support Unicode filenames,
we have to convert the UTF-8 to UCS-2, then use Win32-specific functions.
Since any external that opens files will also be affected the same
way, this patch provides a public API: sys_open()/sys_close(), and
sys_fopen()/sys_fclose(). For non-Win32 platforms, they are just
names that point to the normal POSIX versions. On Win32, they are
special functions to handle UTF-8 to UCS-2 conversion.
I have built and run this on Windows XP, Mac OS X 10.6, and Debian/squeeze amd64. These patches are also included in Pd-extended 0.43.4.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-16 16:29
Message:
Got 'em & pushed to repo... will re-apply the other patches later.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-16 15:34
Message:
OK -- I'll see if I can unwind the other patch and apply this one - if that
works I'll go and fix the
stdint stuff somehow that I can live with :)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-16 12:28
Message:
I agree that its good to avoid putting #includes in m_pd.h stdint.h is a
stable and widespread as stddef.h, which has been part of m_pd.h for a long
time. I put '#include <stdint.h>" because that's the only header that was
already included everywhere that needs types defined in stdint.h.
Another option would be to put the int32_t, etc. definitions in s_stuff.h
or some other header, and then add that header everywhere its needed.
As for the patches not applying, that's because you accepted 3 patches from
Marvin Humpreys that removes lots of code from s_utf8.* and that conflicts
with these patches.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 18:39
Message:
For some reason I can't apply the first patch (I get:
error: patch failed: src/s_utf8.c:26
error: src/s_utf8.c: patch does not apply
error: patch failed: src/s_utf8.h:1
error: src/s_utf8.h: patch does not apply
--- even though my eyeballs can't see any reason that would fail.
Anyway, I'd like not to have m_pd.h be in the business of pulling in other
include files
(except as needed to define its own data structures) as I think that's a
threat to future
portability - can this be fixed to leave m_pd.h, d_soundfile.h, etc., alone
and just "do the
necessary" to the UTF-8 code?
thanks
Miller
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:44
Message:
These are all the externals in Pd-extended that need changes to support
Unicode filenames:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…
Basically, you just need to change open() to sys_open() and fopen() to
sys_fopen(). You can remove sys_bashfilename() since its included in those
new open functions when needed.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:25
Message:
and a couple more for good measure ;)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 19:37
Message:
I added a fifth patch. Microsoft says that the POSIX close() was deprecated
in 2005, and to use
their ISO C++ _close() instead.
http://msdn.microsoft.com/en-US/library/ms235443(v=vs.80).aspxhttp://msdn.microsoft.com/en-US/library/5fzwd5ss(v=vs.80).aspx
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…
Patches item #3594735, was opened at 2012-12-10 19:14
Message generated for change (Comment added) made by millerpuckette
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: Win32: unicode support for files with public API for externs
Initial Comment:
Right now, Pd on Windows does really badly if there are any non-ASCII characters in the path or filename. It makes it freeze for a while, and sometimes crashes it. These patches fix that.
Pd and Tcl/Tk is UTF-8 internally, and UNIXes all use UTF-8 for filenames
and paths. Windows uses UCS-2 everywhere, which is a 16-bit format. The
only place this affects Pd is reading and writing filenames, and printing
to the console. The POSIX-style functions open() and fopen() exist on
Windows, but only work for ASCII filenames. To support Unicode filenames,
we have to convert the UTF-8 to UCS-2, then use Win32-specific functions.
Since any external that opens files will also be affected the same
way, this patch provides a public API: sys_open()/sys_close(), and
sys_fopen()/sys_fclose(). For non-Win32 platforms, they are just
names that point to the normal POSIX versions. On Win32, they are
special functions to handle UTF-8 to UCS-2 conversion.
I have built and run this on Windows XP, Mac OS X 10.6, and Debian/squeeze amd64. These patches are also included in Pd-extended 0.43.4.
----------------------------------------------------------------------
>Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-16 15:34
Message:
OK -- I'll see if I can unwind the other patch and apply this one - if that
works I'll go and fix the
stdint stuff somehow that I can live with :)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-16 12:28
Message:
I agree that its good to avoid putting #includes in m_pd.h stdint.h is a
stable and widespread as stddef.h, which has been part of m_pd.h for a long
time. I put '#include <stdint.h>" because that's the only header that was
already included everywhere that needs types defined in stdint.h.
Another option would be to put the int32_t, etc. definitions in s_stuff.h
or some other header, and then add that header everywhere its needed.
As for the patches not applying, that's because you accepted 3 patches from
Marvin Humpreys that removes lots of code from s_utf8.* and that conflicts
with these patches.
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2012-12-15 18:39
Message:
For some reason I can't apply the first patch (I get:
error: patch failed: src/s_utf8.c:26
error: src/s_utf8.c: patch does not apply
error: patch failed: src/s_utf8.h:1
error: src/s_utf8.h: patch does not apply
--- even though my eyeballs can't see any reason that would fail.
Anyway, I'd like not to have m_pd.h be in the business of pulling in other
include files
(except as needed to define its own data structures) as I think that's a
threat to future
portability - can this be fixed to leave m_pd.h, d_soundfile.h, etc., alone
and just "do the
necessary" to the UTF-8 code?
thanks
Miller
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:44
Message:
These are all the externals in Pd-extended that need changes to support
Unicode filenames:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&revisio…
Basically, you just need to change open() to sys_open() and fopen() to
sys_fopen(). You can remove sys_bashfilename() since its included in those
new open functions when needed.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 21:25
Message:
and a couple more for good measure ;)
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2012-12-11 19:37
Message:
I added a fifth patch. Microsoft says that the POSIX close() was deprecated
in 2005, and to use
their ISO C++ _close() instead.
http://msdn.microsoft.com/en-US/library/ms235443(v=vs.80).aspxhttp://msdn.microsoft.com/en-US/library/5fzwd5ss(v=vs.80).aspx
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3594735&group_…