I feel like the easiest method is to leave the main deken development in the separate repo and pull in periodic versions/updates upstream. So a good call for deken versioning. :)
Maybe another option is deken can be a submodule in the repo pure-data? This approach has helped libpd be a bit more maintainable by having pure-data as a submodule.
--------
Dan Wilcox
@danomatika <https://twitter.com/danomatika>
danomatika.com <http://danomatika.com/>
robotcowboy.com <http://robotcowboy.com/>
> On Mar 22, 2016, at 5:00 AM, pd-dev-request(a)lists.iem.at wrote:
>
> From: Miller Puckette <msp(a)ucsd.edu <mailto:msp@ucsd.edu>>
> Subject: Re: [PD-dev] [pure-data:pure-data] 2 new commits to pure-data
> Date: March 21, 2016 at 5:35:05 PM MDT
> To: IOhannes m zmölnig <zmoelnig(a)iem.at <mailto:zmoelnig@iem.at>>
> Cc: PureData developer's list <pd-dev(a)lists.iem.at <mailto:pd-dev@lists.iem.at>>
>
>
> Hmm... OK, reverting. I now would like to know where to track this
> from (or should I just leave it and have people submit patches to it
> in the pd repo instead?)
Howdy all,
I put the proposed changes in the previous patches into a couple WIP branches on GH.
https://github.com/pure-data/pure-data/pull/11 <https://github.com/pure-data/pure-data/pull/11>
https://github.com/pure-data/pure-data/pull/12 <https://github.com/pure-data/pure-data/pull/12>
--------
Dan Wilcox
@danomatika <https://twitter.com/danomatika>
danomatika.com <http://danomatika.com/>
robotcowboy.com <http://robotcowboy.com/>
> On Mar 26, 2016, at 5:41 PM, pd-dev-request(a)lists.iem.at wrote:
>
> Message: 2
> Date: Sun, 27 Mar 2016 10:41:06 +1100
> From: Tobias Brodel <brittlehaus(a)gmail.com <mailto:brittlehaus@gmail.com>>
> To: Dan Wilcox <danomatika(a)gmail.com <mailto:danomatika@gmail.com>>
> Cc: pd-dev(a)lists.iem.at <mailto:pd-dev@lists.iem.at>
> Subject: Re: [PD-dev] Pd-dev Digest, Vol 132, Issue 15
> Message-ID: <56F71E12.80604(a)gmail.com <mailto:56F71E12.80604@gmail.com>>
> Content-Type: text/plain; charset="windows-1252"; Format="flowed"
>
> that would be ace.
>
> happy easter all.
>
> On 03/27/16 10:17, Dan Wilcox wrote:
>> I can change stddef.h to stdlib.h in that proposed include update.
>>
>> --------
>> Dan Wilcox
>> @danomatika <https://twitter.com/danomatika <https://twitter.com/danomatika>>
>> danomatika.com <http://danomatika.com/> <http://danomatika.com <http://danomatika.com/>>
>> robotcowboy.com <http://robotcowboy.com/> <http://robotcowboy.com <http://robotcowboy.com/>>
>>
>>> On Mar 26, 2016, at 5:00 AM, pd-dev-request(a)lists.iem.at <mailto:pd-dev-request@lists.iem.at>
>>> <mailto:pd-dev-request@lists.iem.at <mailto:pd-dev-request@lists.iem.at>> wrote:
>>>
>>> Message: 2
>>> Date: Sat, 26 Mar 2016 13:32:06 +1100
>>> From: Tobias Brodel <brittlehaus(a)gmail.com <mailto:brittlehaus@gmail.com>
>>> <mailto:brittlehaus@gmail.com <mailto:brittlehaus@gmail.com>>>
>>> To:pd-dev@lists.iem.at <mailto:dev@lists.iem.at> <mailto:pd-dev@lists.iem.at <mailto:pd-dev@lists.iem.at>>
>>> Subject: Re: [PD-dev] clang warning fixes, was: Memory leaks?
>>> Message-ID: <56F5F4A6.3070001(a)gmail.com <mailto:56F5F4A6.3070001@gmail.com>
>>> <mailto:56F5F4A6.3070001@gmail.com <mailto:56F5F4A6.3070001@gmail.com>>>
>>> Content-Type: text/plain; charset="utf-8"; Format="flowed"
>>>
>>> hi dan, list.
>>>
>>> i have some patches i've been meaning to submit relating to the alloca.h
>>> ifdef hell.
>>>
>>> i'm a FreeBSD user and the stddef.h else clause is wrong and actually
>>> gets patched out downstream. Free/Net/Open and DragonFly BSD all have
>>> alloca() in stdlib.h.
>>>
>>> i'll can review my patches now and upload them but they retain the old
>>> style, not your proposed changes.
>>>
>>> cheers,
>>> t.
>
I can change stddef.h to stdlib.h in that proposed include update.
--------
Dan Wilcox
@danomatika <https://twitter.com/danomatika>
danomatika.com <http://danomatika.com/>
robotcowboy.com <http://robotcowboy.com/>
> On Mar 26, 2016, at 5:00 AM, pd-dev-request(a)lists.iem.at wrote:
>
> Message: 2
> Date: Sat, 26 Mar 2016 13:32:06 +1100
> From: Tobias Brodel <brittlehaus(a)gmail.com <mailto:brittlehaus@gmail.com>>
> To: pd-dev(a)lists.iem.at <mailto:pd-dev@lists.iem.at>
> Subject: Re: [PD-dev] clang warning fixes, was: Memory leaks?
> Message-ID: <56F5F4A6.3070001(a)gmail.com <mailto:56F5F4A6.3070001@gmail.com>>
> Content-Type: text/plain; charset="utf-8"; Format="flowed"
>
> hi dan, list.
>
> i have some patches i've been meaning to submit relating to the alloca.h
> ifdef hell.
>
> i'm a FreeBSD user and the stddef.h else clause is wrong and actually
> gets patched out downstream. Free/Net/Open and DragonFly BSD all have
> alloca() in stdlib.h.
>
> i'll can review my patches now and upload them but they retain the old
> style, not your proposed changes.
>
> cheers,
> t.
The last patch fixed some of the warnings. The rest I’m seeing from clang are simple stuff:
warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
aka
assignments in for loops & if/while statements should be wrapped in parens
warning: '&&' within '||' [-Wlogical-op-parentheses], so added paren wraps
switch statement not handling all enumerations, so added default: break;
Note: this is only for sources used by libpd.
Here’s a patch:
>> On Mar 22, 2016, at 10:39 AM, Miller Puckette <msp(a)ucsd.edu <mailto:msp@ucsd.edu>> wrote:
>>
>> It's already in and up - check away :)
>>
>> M
>> On Tue, Mar 22, 2016 at 10:37:20AM -0600, Dan Wilcox wrote:
>>> Sweet. clang on OSX gives me about 100+ warnings when building the pure-data sources for libpd, most of which involve simple things like suggested paren wraps, “implicit conversion loses integer precision,” etc. These might be related to what iOhannes is seeing. I’ll wait to see if this bugfix work is accepted and then I can make a similar patch for the warnings.
>>>
>>> --------
>>> Dan Wilcox
>>> @danomatika <https://twitter.com/danomatika <https://twitter.com/danomatika>>
>>> danomatika.com <http://danomatika.com/> <http://danomatika.com/ <http://danomatika.com/>>
>>> robotcowboy.com <http://robotcowboy.com/> <http://robotcowboy.com/ <http://robotcowboy.com/>>
>>>> On Mar 22, 2016, at 5:00 AM, pd-dev-request(a)lists.iem.at <mailto:pd-dev-request@lists.iem.at> wrote:
>>>>
>>>> From: IOhannes m zmölnig <zmoelnig(a)iem.at <mailto:zmoelnig@iem.at> <mailto:zmoelnig@iem.at <mailto:zmoelnig@iem.at>>>
>>>> Subject: Re: [PD-dev] Memory leaks?
>>>> Date: March 21, 2016 at 3:29:25 PM MDT
>>>> To: pd-dev(a)lists.iem.at <mailto:pd-dev@lists.iem.at> <mailto:pd-dev@lists.iem.at <mailto:pd-dev@lists.iem.at>>
>>>>
>>>>
>>>> On 03/21/2016 09:51 PM, Miller Puckette wrote:
>>>>> Yep, thanks. Fixing it now...
>>>>
>>>> since you seem to be in bug-squashing mode: there are about 100 more
>>>> bugs waiting to be fixed :-)
--------
Dan Wilcox
@danomatika <https://twitter.com/danomatika>
danomatika.com <http://danomatika.com/>
robotcowboy.com <http://robotcowboy.com/>
---
** [bugs:#1236] Tcl trace in console while configuring ALSA midi**
**Status:** open
**Group:** v0.46
**Created:** Wed Mar 23, 2016 07:51 PM UTC by electrickery
**Last Updated:** Wed Mar 23, 2016 07:51 PM UTC
**Owner:** nobody
Pd-0.47.0 ("test") compiled 19:15:29 Mar 23 2016
Pre-condition: MIDI device present, activated within ALSA.
While opening Media > MIDI Settings...
opened 0 MIDI input device(s) and 0 MIDI output device(s).
(Tcl) UNHANDLED ERROR: bad side "top-fill": must be top, bottom, left, or right
while executing
"pack $id.buttonframe -side top-fill x -pady 2m"
(procedure "pdtk_alsa_midi_dialog" line 48)
invoked from within
"pdtk_alsa_midi_dialog .gfxstub1021230 0 0 0 0 0 0 0 0 0 1"
("uplevel" body line 4)
invoked from within
"uplevel #0 $docmds"
Same configuration works ok with 0.46.7.
System: Xubuntu 14.04 x86-64
---
Sent from sourceforge.net because pd-dev(a)lists.iem.at is subscribed to https://sourceforge.net/p/pure-data/bugs/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/pure-data/admin/bugs/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Sweet. clang on OSX gives me about 100+ warnings when building the pure-data sources for libpd, most of which involve simple things like suggested paren wraps, “implicit conversion loses integer precision,” etc. These might be related to what iOhannes is seeing. I’ll wait to see if this bugfix work is accepted and then I can make a similar patch for the warnings.
--------
Dan Wilcox
@danomatika <https://twitter.com/danomatika>
danomatika.com <http://danomatika.com/>
robotcowboy.com <http://robotcowboy.com/>
> On Mar 22, 2016, at 5:00 AM, pd-dev-request(a)lists.iem.at wrote:
>
> From: IOhannes m zmölnig <zmoelnig(a)iem.at <mailto:zmoelnig@iem.at>>
> Subject: Re: [PD-dev] Memory leaks?
> Date: March 21, 2016 at 3:29:25 PM MDT
> To: pd-dev(a)lists.iem.at <mailto:pd-dev@lists.iem.at>
>
>
> On 03/21/2016 09:51 PM, Miller Puckette wrote:
>> Yep, thanks. Fixing it now...
>
> since you seem to be in bug-squashing mode: there are about 100 more
> bugs waiting to be fixed :-)
On 03/21/2016 10:17 PM, Pure Data Computer Music System Git repository
wrote:
> <div class="markdown_content"><p>update deken to snapshot from Mar 21, 2016</div>
>
> By Miller Puckette on 03/21/2016 21:14
> [**View Changes**](https://sourceforge.net/p/pure-data/pure-data/ci/4fbb3f038c26384…
hmm, i'm not sure that the current deken-plugin should be imported into
the Pd mainline.
afaict, the version you imported was actually older than the version
already in mainline, and the import unfortunately undid a few things
(namely the disabling of the apt-backend).
gmadsr
IOhannes