Pd-dev April 2011

pd-dev@lists.iem.at

19 participants
73 discussions

[ pure-data-Patches-1502860 ] class-destructor (free-method) not called when quitting pd
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #1502860, was opened at 2006-06-08 14:33 Message generated for change (Comment added) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1502860&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata-dev Group: bugfix Status: Open Resolution: None Priority: 7 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: class-destructor (free-method) not called when quitting pd Initial Comment: when an object is destroyed (either directly deleted or by closing the patch containing it) the "free" method (a "destructor" in c++-speak) for this object is called. however, when pd is "quit" (e.g. "Ctrl-Q"), this destructor does not get called, which potentially leaves the system in a bad state. the attached patch fixes this by adding a "glob_closeall()" function to g_editor.c (which closes all root canvases) and calling it from within glob_quit() in s_inter.c ---------------------------------------------------------------------- >Comment By: IOhannes m zmölnig (zmoelnig) Date: 2011-04-18 18:18 Message: updated the patch so it applies to Pd-0.43 (and incorporated thomas' suggestion) ---------------------------------------------------------------------- Comment By: Thomas Grill (xovo) Date: 2006-08-02 18:20 Message: Logged In: YES user_id=350252 I think there's a problem in this patch when traversing the canvas list with canvases vanishing meanwhile. It should be more like: void glob_closeall(void*dummy, t_floatarg fforce) { t_canvas*x,*y; for (x = canvas_list; x; ) { y = x->gl_next; canvas_menuclose(x, fforce); /* forced closing of this root canvas */ x = y; } } Still, this assumes that PD doesn't do more than removing that one entry from the canvas list, which is not very clean. ---------------------------------------------------------------------- Comment By: IOhannes m zmölnig (zmoelnig) Date: 2006-07-26 11:43 Message: Logged In: YES user_id=564396 actually i think this is rather important when objects interface with the system - so i raised the priority ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1502860&group_…

1 0

[ pure-data-Patches-3288939 ] fix GUI hangs due to recentfile patch
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #3288939, was opened at 2011-04-18 08:55 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3288939&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None >Status: Pending >Resolution: Accepted Priority: 7 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: fix GUI hangs due to recentfile patch Initial Comment: patch #3234958 (git rev 31b22b6918b033) hangs Pd, if the list of recent files is empty (e.g. because you just installed the patch). this is due to a "while(--i)" loop with "i" initialized to 0 ouch! attached patch fixes this by changing the loop to "while(--i > 0)" it also fixes a typo in the doc ---------------------------------------------------------------------- >Comment By: Miller Puckette (millerpuckette) Date: 2011-04-18 08:58 Message: Of course, the best way is (while i--) :) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3288939&group_…

1 0

[ pure-data-Patches-3288939 ] fix GUI hangs due to recentfile patch
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #3288939, was opened at 2011-04-18 17:55 Message generated for change (Tracker Item Submitted) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3288939&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None Status: Open Resolution: None Priority: 7 Private: No Submitted By: IOhannes m zmölnig (zmoelnig) Assigned to: Miller Puckette (millerpuckette) Summary: fix GUI hangs due to recentfile patch Initial Comment: patch #3234958 (git rev 31b22b6918b033) hangs Pd, if the list of recent files is empty (e.g. because you just installed the patch). this is due to a "while(--i)" loop with "i" initialized to 0 ouch! attached patch fixes this by changing the loop to "while(--i > 0)" it also fixes a typo in the doc ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3288939&group_…

1 0

[ pure-data-Patches-3234958 ] add gui preferences system via conf files
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #3234958, was opened at 2011-03-22 17:11 Message generated for change (Comment added) made by elgusanorojo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3234958&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: feature Status: Pending Resolution: Accepted Priority: 5 Private: No Submitted By: gusano (elgusanorojo) Assigned to: Nobody/Anonymous (nobody) Summary: add gui preferences system via conf files Initial Comment: this patch adds a gui-preferences system, right now for recent files only. recently opened files are written in the user-app-config directory (i.e. ~/.config/pure-data/recentfiles.conf on linux) and read when pd launches. this was tested on linux and osx only (I don't have access to a win32 machine). see the following related threads: http://www.mail-archive.com/pd-dev@iem.at/msg09330.html http://www.mail-archive.com/pd-dev@iem.at/msg09351.html ---------------------------------------------------------------------- Comment By: gusano (elgusanorojo) Date: 2011-04-18 17:32 Message: I forgot to include 2 small fixes in the patch, new one uploaded ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2011-04-18 16:45 Message: thanks... worked that time. ---------------------------------------------------------------------- Comment By: gusano (elgusanorojo) Date: 2011-04-18 12:11 Message: it didn't apply because of some changes in po/Makefile.am since this patch was submitted. I just uploaded an updated patch. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2011-04-18 03:33 Message: I couldn't apply this to 0.43.. (failed on po/Makefile.am - I couldn't figure out why). ---------------------------------------------------------------------- Comment By: gusano (elgusanorojo) Date: 2011-03-29 16:01 Message: I finally found the time to make a new patch: - added support for osx preferences and windows registry - new file is now added to recentfiles if it's saved - better error handling - better doc (pd_guiprefs) - bugfix 3192731 (http://sourceforge.net/tracker/?func=detail&aid=3192731&group_id=55736&atid…) the patch was tested on archlinux, ubuntu10.10 and osx 10.5.8 on windows I could only test the registry stuff in a tclsh prompt, please test ! ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-03-24 05:44 Message: This is looking good, I just have a couple comments: - I think you should manually edit pkgIndex.tcl. the script made a bunch of changes, that are not really relevant and might affect other things. You just need to add a single line for pd_guiprefs.tcl - preferences on Mac OS X are stored in ~/Library/Preferences rather than ~/Library/Application Support/pure-data. Ideally, this patch would also use the terminal tool 'defaults read' and 'defaults write' to create a proper Mac OS X .plist preferences file. Its not hard to do, you can see how Pd currently does it in pd/src/s_file.c. Windows needs to use the registry, that's even easier because Tcl has the built -in 'registry' command. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3234958&group_…

1 0

[ pure-data-Patches-3234958 ] add gui preferences system via conf files
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #3234958, was opened at 2011-03-22 09:11 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3234958&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: feature >Status: Pending >Resolution: Accepted Priority: 5 Private: No Submitted By: gusano (elgusanorojo) Assigned to: Nobody/Anonymous (nobody) Summary: add gui preferences system via conf files Initial Comment: this patch adds a gui-preferences system, right now for recent files only. recently opened files are written in the user-app-config directory (i.e. ~/.config/pure-data/recentfiles.conf on linux) and read when pd launches. this was tested on linux and osx only (I don't have access to a win32 machine). see the following related threads: http://www.mail-archive.com/pd-dev@iem.at/msg09330.html http://www.mail-archive.com/pd-dev@iem.at/msg09351.html ---------------------------------------------------------------------- >Comment By: Miller Puckette (millerpuckette) Date: 2011-04-18 07:45 Message: thanks... worked that time. ---------------------------------------------------------------------- Comment By: gusano (elgusanorojo) Date: 2011-04-18 03:11 Message: it didn't apply because of some changes in po/Makefile.am since this patch was submitted. I just uploaded an updated patch. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2011-04-17 18:33 Message: I couldn't apply this to 0.43.. (failed on po/Makefile.am - I couldn't figure out why). ---------------------------------------------------------------------- Comment By: gusano (elgusanorojo) Date: 2011-03-29 07:01 Message: I finally found the time to make a new patch: - added support for osx preferences and windows registry - new file is now added to recentfiles if it's saved - better error handling - better doc (pd_guiprefs) - bugfix 3192731 (http://sourceforge.net/tracker/?func=detail&aid=3192731&group_id=55736&atid…) the patch was tested on archlinux, ubuntu10.10 and osx 10.5.8 on windows I could only test the registry stuff in a tclsh prompt, please test ! ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-03-23 21:44 Message: This is looking good, I just have a couple comments: - I think you should manually edit pkgIndex.tcl. the script made a bunch of changes, that are not really relevant and might affect other things. You just need to add a single line for pd_guiprefs.tcl - preferences on Mac OS X are stored in ~/Library/Preferences rather than ~/Library/Application Support/pure-data. Ideally, this patch would also use the terminal tool 'defaults read' and 'defaults write' to create a proper Mac OS X .plist preferences file. Its not hard to do, you can see how Pd currently does it in pd/src/s_file.c. Windows needs to use the registry, that's even easier because Tcl has the built -in 'registry' command. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3234958&group_…

1 0

[ pure-data-Patches-3234958 ] add gui preferences system via conf files
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #3234958, was opened at 2011-03-22 17:11 Message generated for change (Comment added) made by elgusanorojo You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3234958&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: feature Status: Open Resolution: None Priority: 5 Private: No Submitted By: gusano (elgusanorojo) Assigned to: Nobody/Anonymous (nobody) Summary: add gui preferences system via conf files Initial Comment: this patch adds a gui-preferences system, right now for recent files only. recently opened files are written in the user-app-config directory (i.e. ~/.config/pure-data/recentfiles.conf on linux) and read when pd launches. this was tested on linux and osx only (I don't have access to a win32 machine). see the following related threads: http://www.mail-archive.com/pd-dev@iem.at/msg09330.html http://www.mail-archive.com/pd-dev@iem.at/msg09351.html ---------------------------------------------------------------------- Comment By: gusano (elgusanorojo) Date: 2011-04-18 12:11 Message: it didn't apply because of some changes in po/Makefile.am since this patch was submitted. I just uploaded an updated patch. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2011-04-18 03:33 Message: I couldn't apply this to 0.43.. (failed on po/Makefile.am - I couldn't figure out why). ---------------------------------------------------------------------- Comment By: gusano (elgusanorojo) Date: 2011-03-29 16:01 Message: I finally found the time to make a new patch: - added support for osx preferences and windows registry - new file is now added to recentfiles if it's saved - better error handling - better doc (pd_guiprefs) - bugfix 3192731 (http://sourceforge.net/tracker/?func=detail&aid=3192731&group_id=55736&atid…) the patch was tested on archlinux, ubuntu10.10 and osx 10.5.8 on windows I could only test the registry stuff in a tclsh prompt, please test ! ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-03-24 05:44 Message: This is looking good, I just have a couple comments: - I think you should manually edit pkgIndex.tcl. the script made a bunch of changes, that are not really relevant and might affect other things. You just need to add a single line for pd_guiprefs.tcl - preferences on Mac OS X are stored in ~/Library/Preferences rather than ~/Library/Application Support/pure-data. Ideally, this patch would also use the terminal tool 'defaults read' and 'defaults write' to create a proper Mac OS X .plist preferences file. Its not hard to do, you can see how Pd currently does it in pd/src/s_file.c. Windows needs to use the registry, that's even easier because Tcl has the built -in 'registry' command. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3234958&group_…

1 0

[ pure-data-Patches-3238078 ] add missing 'int blocksize' to mmio_open_audio() in s_stuf
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #3238078, was opened at 2011-03-23 10:02 Message generated for change (Settings changed) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3238078&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Pending >Resolution: Accepted Priority: 9 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: add missing 'int blocksize' to mmio_open_audio() in s_stuf Initial Comment: The mmio_open_audio() function had a new "blocksize" arg added to it, but the declaration in s_stuff.h was not changed. This patch fixes that. I set the priority high because this bug prevents compilation on Windows using MMIO. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3238078&group_…

1 0

[ pure-data-Patches-3234958 ] add gui preferences system via conf files
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #3234958, was opened at 2011-03-22 09:11 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3234958&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: feature Status: Open Resolution: None Priority: 5 Private: No Submitted By: gusano (elgusanorojo) Assigned to: Nobody/Anonymous (nobody) Summary: add gui preferences system via conf files Initial Comment: this patch adds a gui-preferences system, right now for recent files only. recently opened files are written in the user-app-config directory (i.e. ~/.config/pure-data/recentfiles.conf on linux) and read when pd launches. this was tested on linux and osx only (I don't have access to a win32 machine). see the following related threads: http://www.mail-archive.com/pd-dev@iem.at/msg09330.html http://www.mail-archive.com/pd-dev@iem.at/msg09351.html ---------------------------------------------------------------------- >Comment By: Miller Puckette (millerpuckette) Date: 2011-04-17 18:33 Message: I couldn't apply this to 0.43.. (failed on po/Makefile.am - I couldn't figure out why). ---------------------------------------------------------------------- Comment By: gusano (elgusanorojo) Date: 2011-03-29 07:01 Message: I finally found the time to make a new patch: - added support for osx preferences and windows registry - new file is now added to recentfiles if it's saved - better error handling - better doc (pd_guiprefs) - bugfix 3192731 (http://sourceforge.net/tracker/?func=detail&aid=3192731&group_id=55736&atid…) the patch was tested on archlinux, ubuntu10.10 and osx 10.5.8 on windows I could only test the registry stuff in a tclsh prompt, please test ! ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-03-23 21:44 Message: This is looking good, I just have a couple comments: - I think you should manually edit pkgIndex.tcl. the script made a bunch of changes, that are not really relevant and might affect other things. You just need to add a single line for pd_guiprefs.tcl - preferences on Mac OS X are stored in ~/Library/Preferences rather than ~/Library/Application Support/pure-data. Ideally, this patch would also use the terminal tool 'defaults read' and 'defaults write' to create a proper Mac OS X .plist preferences file. Its not hard to do, you can see how Pd currently does it in pd/src/s_file.c. Windows needs to use the registry, that's even easier because Tcl has the built -in 'registry' command. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3234958&group_…

1 0

[ pure-data-Patches-3222795 ] fully automate the creation of the translation template.pot
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #3222795, was opened at 2011-03-18 07:19 Message generated for change (Comment added) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3222795&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Pending >Resolution: Accepted Priority: 5 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: fully automate the creation of the translation template.pot Initial Comment: The gettext tools can automatically generate a translation template file template.pot from the source code, but xgettext gets confused by the strings that are send from C to Tcl. So I added those strings to some fake Tcl files, and now "make po/template.pot" will automatically generate the updated translation template from the source code. ---------------------------------------------------------------------- >Comment By: Miller Puckette (millerpuckette) Date: 2011-04-17 18:24 Message: No idea what this does... but Hans is the authority on the makefile.am stuff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3222795&group_…

1 0

[ pure-data-Patches-3189135 ] glob_evalfile returns reference *
by SourceForge.net 18 Apr '11

18 Apr '11

Patches item #3189135, was opened at 2011-02-22 03:17 Message generated for change (Settings changed) made by millerpuckette You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3189135&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None >Status: Pending >Resolution: Accepted Priority: 5 Private: No Submitted By: Rich E (reakin) Assigned to: Miller Puckette (millerpuckette) Summary: glob_evalfile returns reference * Initial Comment: glob_evalfile returns a reference to the patch that it opens, which is useful when opening/closing patches with a system other than the messaging (pd open ....) system. We are already using this system in libpd to open and close patches by reference instead of file name, and this also allows us to know more about the patch at instantiation (ex. dollar args). As the method glob_evalfile currently returns void, it has no backwards incompatibility issues. ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2011-04-17 18:21 Message: Looks OK to me - I'll take it unless someone else complains :) ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-02-25 08:27 Message: yeah git format-patch preserves the author, etc. so its quite nice. The code looks good, and the patch looks perfect, thanks for the update! ---------------------------------------------------------------------- Comment By: Rich E (reakin) Date: 2011-02-25 01:40 Message: Okay, new uploaded patch file, this time formatted with git format-patch - I didn't realize that there was a difference between this and using git diff. Please let me know if there is any other issues. ---------------------------------------------------------------------- Comment By: Rich E (reakin) Date: 2011-02-24 04:16 Message: Please look at the updated diff file, I have removed all the tabs and inserted white spaces instead (sorry, its my ide's fault not mine). The brackets around the while statement are preferred, as we want to return x when it is still valid, not assign it a new value at each iteration (at which point the loop ends when x == null). ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-02-23 21:05 Message: Sounds like a reasonable patch, but the diff itself is fully of whitespace changes, so its quite hard to read. A patch should only have relevant changes in it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3189135&group_…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pd-dev April 2011