Patches item #1851193, was opened at 2007-12-15 00:23
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1851193&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
>Group: bugfix
Status: Open
Resolution: None
>Priority: 9
Private: No
Submitted By: Roman Haefeli (reduzent)
Assigned to: Miller Puckette (millerpuckette)
Summary: [symbolatom\ : doesn't allow to type spaces (ascii 32)
Initial Comment:
i would like to read a textfile into an object [textfile] by using the symbolatom as a gui to specify the filename. however, it fails when the filename of the file contains a space.
example patch:
[symbolatom\
|
[read $1(
|
[textfile]
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:32
Message:
I'm elevating the priority since this is a trivial fix and has been in
Pd-extended since 2007.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-03-20 23:16
Message:
Wow, such a simple fix, I wish I thought of trying years ago. This does
make me think that we should have a discussion at PdCon just about spaces
and symbols. I included this change in Pd-extended 0.41. Here's the
commit:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=108…
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2008-04-06 13:42
Message:
Logged In: YES
user_id=564396
Originator: NO
the fix for this is rather trivial (see attached patch)
i'm wondering why spaces have been disabled in the first place...
File Added: spacesymbol.diff
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1851193&group_…
Patches item #1722081, was opened at 2007-05-20 05:27
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1722081&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Luke Iannini (lukeiannini)
Assigned to: Miller Puckette (millerpuckette)
Summary: [Editmode 0( toggles rather than turns off editmode
Initial Comment:
Hallo,
Simple enough... sending [editmode 0( to a subpatch toggles the edit-mode state of the subpatch, rather than turning it off.
[editmode 1( works fine, reliably enabling (and never disabling) editmode.
Ah! That makes me realize the workaround is to send [editmode 1(, then [editmode 0(. Regardless, this should be fixed!
Demonstration is attached (move mouse around to see the cursor change).
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:27
Message:
This has been included in 0.43.0-test1 with commit
dc79a38f5664055a5a8b9eb508917931fdefccd4
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-11 11:23
Message:
Included in pd-gui-rewrite/0.43 branch, should make it into vanilla:
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=129…
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2007-10-01 07:36
Message:
Logged In: YES
user_id=564396
Originator: NO
the attached patch (editmode_toggle.patch) introduces 3 states:
0: turn OFF editmode
1: turn ON editmode
everything else: toggle editmode
the pd-gui (u_main.tk) has also been udated to use "-1" when toggling
editmode.
File Added: editmode_toggle.patch
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2007-10-01 07:33
Message:
Logged In: YES
user_id=564396
Originator: NO
actually this is not really a bug: Pd internally uses "editmode 0" to
toggle between the 2 states (e.g. when you press "Control-E");
so the behaviour you described is intended!
the inffocial "pd-msg" documentation should be updated to reflect this.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1722081&group_…
Patches item #1936157, was opened at 2008-04-06 14:17
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1936157&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: IOhannes m zmlnig (zmoelnig)
>Assigned to: Miller Puckette (millerpuckette)
Summary: make "list" messages be real float/symbol/bang messages
Initial Comment:
in the past there has been some attempts to make "list" messages behave like "float" (or "symbol" or "bang") messages and vice-versa.
the attached patch adds some additional fallbacks to the method dispatcher in inlet_list():
if an object has no real list-method for an inlet but a float-method and it receives a one-element list holding a float, it will call the float-method.
the same for symbols.
if there is no list-method and the object receives an empty "list" message, it will call the objects "bang_method"
this should fix bugs #1890931 and #1749885.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:23
Message:
I'm going to assign this to Miller, and let him make the call on whether to
include it or not rather than include it in Pd-extended.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-04-25 16:26
Message:
I am going to assign this to me for now so that I remember to included it
in the Pd-extended 0.42 branch, unless anyone has any objections. Then
I'll assign it to Miller...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1936157&group_…
Patches item #1944380, was opened at 2008-04-16 17:19
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1944380&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Hans-Christoph Steiner (eighthave)
Summary: fixed help patch for plugin~
Initial Comment:
The plugin~ object was incorrectly using a [print< message. By reading the source, I saw that it should have been using an [info< message. I changed this and added [print] objects so that the output in response to the info messages can be seen. I added attribution of this fix to the file, which you can feel free to remove if it is inappropriate.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:18
Message:
this should be fixed in SVN and Pd-extended 0.42.5
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1944380&group_…
Patches item #1852128, was opened at 2007-12-17 01:21
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852128&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: bugfix
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: compile with -mno-cygwin
Initial Comment:
This allow to compile with cygwin shell, and might not be as clean as it was done by a makefile specialist
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:17
Message:
This patch should have a separate section for Cygwin, not just tacked onto
the WIN32 section. This patch is largely make obsolete by the new Makefile
and library template:
http://pure-data.svn.sourceforge.net/viewvc/pure-data/trunk/externals/templ…
----------------------------------------------------------------------
Comment By: IOhannes m zmlnig (zmoelnig)
Date: 2007-12-19 08:10
Message:
Logged In: YES
user_id=564396
Originator: NO
while the original post is rather cryptic, i guess this is for the
pd-extended build-system (at least, according to the file-description it is
about "externals/Makefile" which is pd-extended only)
i therefore assign it to hans :-)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1852128&group_…
Patches item #2803092, was opened at 2009-06-08 13:49
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2803092&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 8
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: fixes to get 'extra' building under MinGW again
Initial Comment:
There are a couple of tweaks needed to get the new 0.42 'extra' code to build on MinGW.
http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=rev&revision=117…
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 18:12
Message:
most of this patch was already included, the rest I will be submitted as
part of a git patch set, so I am closing this.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 21:20
Message:
You also might consider replacing the #define flog log stuff with the
actual functions. On GNU/Linux and BSD, the float versions are called
logf(), etc.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2803092&group_…
o Pd developers --
After much uncertainty how to proceed, I finally went ahead and 'pushed'
my Pd git repository to sourceforgs -- available at
http://pure-data.git.sourceforge.net/git/gitweb.cgi?p=pure-data/pure-data
or to clone it to your machine (once you have git installed):
git clone \
ssh://YOURNAME@pure-data.git.sourceforge.net/gitroot/pure-data/pure-data
Unlike the svn version, ths git version isn't tested on all platformss. I
_think: what I should do is "tag" the occasional commits that I've tested
semi-thoroughly and also commit those to svn (the traditional place I've
been uploading tested code to). So the svn code will always be clean and
the git code variously clean and dirty depending on phase.
The git code is based on the Hans/IOhannes gui rewrite -- that alone is such
a dramatic improvement that I'm thinking I should just do some audio testing
and tuning now, and then call it 0.43.
cheers
Miller
Patches item #2886889, was opened at 2009-10-27 00:41
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2886889&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 7
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: (0.43) build fixes for Android, clean up for Linux/BSD
Initial Comment:
Android seems to be an odd mix of Linux and BSD. In the process of porting Pd to android, I found a few inconsistencies:
- int32 was being using in UNIX land, when int32_t should be used there (int32 is Windows and IRIX)
- int32_t should come from stdint.h not sys/types.h
- sighandler_t is not defined in Android, but sig_t is defined in Linux, MacOSX, and Android
I checked these on Ubuntu 9.04, Mac OS X 10.5.8, Cygwin, MinGW, OpenBSD, and Android.
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 17:52
Message:
accepted in 0.43.0-test1
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-01-01 21:05
Message:
FYI: this patch has already been included in the pd-gui-rewrite/0.43
branch:
https://pure-data.svn.sourceforge.net/svnroot/pure-data/branches/pd-gui-rew…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2886889&group_…
Patches item #2848888, was opened at 2009-09-02 01:29
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2848888&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
>Status: Closed
>Resolution: Accepted
Priority: 9
Private: No
Submitted By: Hans-Christoph Steiner (eighthave)
Assigned to: Miller Puckette (millerpuckette)
Summary: (0.43) Windows/Cygwin/MinGW build fixes
Initial Comment:
In order to build on Cygwin and MinGW cleanly and with a simple build system, the macro 'MSW' should be replaced with the automatic macro '_WIN32' (the preceeding underscore is important). It should be replaced in all .c and .h files, and can be done using a simple replace, like "sed -i 's|MSW|_WIN32|' *.[ch]". Then the patch attached fixes a couple of minor Cygwin-specific macro tests. Also, once MSW is replaced with _WIN32, then this chunk of code can also be removed from m_pd.h:
/* old name for "MSW" flag -- we have to take it for the sake of many old
"nmakefiles" for externs, which will define NT and not MSW */
#if defined(NT) && !defined(MSW)
#define MSW
#endif
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 17:40
Message:
almost all of this has been accepted into 0.43
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-10-28 13:35
Message:
Ok, these patches are pretty messy in their current form. Miller, let me
know whether you want cleaned up patches, or whether you just want to take
this stuff directly from the pd-gui-rewrite/0.43 branch.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-09-03 16:11
Message:
Wait, there's more! Its a tiny one.ASIO is C++, so Pd should use g++ when
including ASIO, therefore everything needs to build with g++. From what
I've read, when linking C++ into C, then main() needs to be compiled with
g++ and everything needs to be linked using g++.
So, this newest fix is just a one-liner that g++ pointed out in its
strictness. Basically there is a malloc() that isn't cast in
u_pdreceive.c:
http://pure-data.svn.sourceforge.net/viewvc/pure-data/branches/pd-gui-rewri…
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2009-09-02 18:57
Message:
Ok, so now I had to sort out the HAVE_UNISTD_H define, that one was
basically being used as: #ifndef _WIN32, so I put that in instead. MinGW
has unistd.h, so HAVE_UNISTD_H was causing issues. But MinGW is WIN32 API,
so it doesn't have all the UNIXy stuff.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2848888&group_…
Patches item #2977779, was opened at 2010-03-27 16:18
Message generated for change (Comment added) made by mrpeach
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2977779&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Martin Peach (mrpeach)
Summary: fixes for mrpeach/tcpserver.c (pd-extended 0.42.5)
Initial Comment:
fixes:
out-of-order output on tcpserver.c
provides output of IP and socket on disconnect so if one maintains a
database of what client is associated with what socket (e.g. through a
coll), this way it reports it in a way that such an external database
can be updated accordingly.
----------------------------------------------------------------------
>Comment By: Martin Peach (mrpeach)
Date: 2010-07-15 16:37
Message:
It has been applied.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2010-07-15 15:52
Message:
is this still relevant?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2977779&group_…