Pd-dev November 2009

pd-dev@lists.iem.at

19 participants
65 discussions

[ pure-data-Bugs-2838114 ] zexy fwriteln buffer overflow
by SourceForge.net 30 Nov '09

30 Nov '09

Bugs item #2838114, was opened at 2009-08-15 12:33 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2838114&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: externals Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: ClaudiusMaximus (claudiusmaximus) >Assigned to: IOhannes m zmlnig (zmoelnig) Summary: zexy fwriteln buffer overflow Initial Comment: The buffer for the prefix is too small. gcc -I. -DHAVE_CONFIG_H -DZEXY_LIBRARY -DPD -I/usr/src/pd/src -g -O2 -g -Wall -O2 -mms-bitfields -fPIC -mfpmath=sse -msse -g -O2 -g -Wall -O2 -c -o fwriteln.o fwriteln.c In file included from /usr/include/string.h:640, from fwriteln.c:26: In function 'strcpy', inlined from 'fwriteln_new' at fwriteln.c:233: /usr/include/bits/string3.h:106: warning: call to __builtin___strcpy_chk will always overflow destination buffer In function 'strcpy', inlined from 'fwriteln_new' at fwriteln.c:236: /usr/include/bits/string3.h:106: warning: call to __builtin___strcpy_chk will always overflow destination buffer Line 195: char prefix[2]="%"; Line 233: strcpy(prefix,"%-"); Line 236: strcpy(prefix,"%+"); The strcpy will copy an additional '\0' byte which will overflow the buffer. Suggested fix: increase the prefix buffer size ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2838114&group_…

1 0

[ pure-data-Bugs-2905508 ] mrpeach/tcpserver: stops sending after X messages
by SourceForge.net 29 Nov '09

29 Nov '09

Bugs item #2905508, was opened at 2009-11-29 00:20 Message generated for change (Comment added) made by reduzent You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: externals Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Roman Haefeli (reduzent) Assigned to: Martin Peach (mrpeach) Summary: mrpeach/tcpserver: stops sending after X messages Initial Comment: After sending 380 messages to one or more clients, [tcpserver] stops sending any more messages. Though TCP is stream-oriented, the number of (pd) messages sent [tcpserver] is significant and not the number of transmitted bytes. Attached is a patch, that illustrates the problem. BTW: the new threaded version is ~15 times faster than the old select() based. It looks very promising. ---------------------------------------------------------------------- >Comment By: Roman Haefeli (reduzent) Date: 2009-11-29 20:09 Message: Hi Martin Thanks a lot for providing a fix so quickly. Things looks very good. I was putting the tcpserver based netpd-server under the heaviest load i can get, which is limited by the bandwidth of my home internet connection. While constantly sending messages with ~50 kB/s bandwidth up to the server and ~350kB/s receiving from it, all messages come through intact. It is stable also when connecting and disconnecting a lot of clients at the same time, while constantly broadcasting messages. The cpu usage is *much* lower than with the select() based tcpserver; with the bandwidth load mentioned above, it is about 12%, whereas it reached 100% with much less load before. Thanks again for all your work spent on this issue. ---------------------------------------------------------------------- Comment By: Martin Peach (mrpeach) Date: 2009-11-29 17:50 Message: oops, thought I was logged in...anyhow I'll try it on a linux box tomorrow. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-11-29 17:47 Message: It was probably the handles that reached a limit, the threads disappear after the data has been sent but their handles were not being cleaned up. Now the threads are created in the detached state so their handles are freed on exit. On WinXP the handles and threads are fairly constant now. I'll leave the patch running to see if it ever hangs, but t seems to be working OK here. ---------------------------------------------------------------------- Comment By: Roman Haefeli (reduzent) Date: 2009-11-29 14:18 Message: Actually, i couldn't figure out, why it stops working after 380 messages. I'd like to know, whether it hit some max number of threads limit. I also couldn't figure out how to display the number of threads being started by a certain process.I found /proc/sys/kernel/threads-max, which is set to 32491 on my system. However, changing the value doesn't effect the behaviour of the test-patch. ---------------------------------------------------------------------- Comment By: Martin Peach (mrpeach) Date: 2009-11-29 06:03 Message: The threads are supposed to terminate themselves after they have sent their buffer. I don't see a need to use threads apart from sending messages. The rest of [tcpserver] works just fine in one thread. Here on WinXP the patch is still running at 66000+. The system is adding handles at about twice the rate as the threads are being created, but the amount of available memory is not decreasing and the number of threads is staying about the same. I'm not sure if that's a bug. ---------------------------------------------------------------------- Comment By: Roman Haefeli (reduzent) Date: 2009-11-29 00:30 Message: Hm.. from the svn log of revision 12760: "Using pthreads to send each message to each client in its own thread." That probably explains, why it stops working after sending X times 'broadcast 97 59 10' to [tcpserver]. Do i understand right, that literally each pd message opens its own <number of clients> threads? Wouldn't it be sufficient to have one thread per socket? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_…

1 0

[ pure-data-Bugs-2905508 ] mrpeach/tcpserver: stops sending after X messages
by SourceForge.net 29 Nov '09

29 Nov '09

Bugs item #2905508, was opened at 2009-11-28 19:20 Message generated for change (Comment added) made by mrpeach You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: externals Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Roman Haefeli (reduzent) Assigned to: Martin Peach (mrpeach) Summary: mrpeach/tcpserver: stops sending after X messages Initial Comment: After sending 380 messages to one or more clients, [tcpserver] stops sending any more messages. Though TCP is stream-oriented, the number of (pd) messages sent [tcpserver] is significant and not the number of transmitted bytes. Attached is a patch, that illustrates the problem. BTW: the new threaded version is ~15 times faster than the old select() based. It looks very promising. ---------------------------------------------------------------------- Comment By: Martin Peach (mrpeach) Date: 2009-11-29 12:50 Message: oops, thought I was logged in...anyhow I'll try it on a linux box tomorrow. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-11-29 12:47 Message: It was probably the handles that reached a limit, the threads disappear after the data has been sent but their handles were not being cleaned up. Now the threads are created in the detached state so their handles are freed on exit. On WinXP the handles and threads are fairly constant now. I'll leave the patch running to see if it ever hangs, but t seems to be working OK here. ---------------------------------------------------------------------- Comment By: Roman Haefeli (reduzent) Date: 2009-11-29 09:18 Message: Actually, i couldn't figure out, why it stops working after 380 messages. I'd like to know, whether it hit some max number of threads limit. I also couldn't figure out how to display the number of threads being started by a certain process.I found /proc/sys/kernel/threads-max, which is set to 32491 on my system. However, changing the value doesn't effect the behaviour of the test-patch. ---------------------------------------------------------------------- Comment By: Martin Peach (mrpeach) Date: 2009-11-29 01:03 Message: The threads are supposed to terminate themselves after they have sent their buffer. I don't see a need to use threads apart from sending messages. The rest of [tcpserver] works just fine in one thread. Here on WinXP the patch is still running at 66000+. The system is adding handles at about twice the rate as the threads are being created, but the amount of available memory is not decreasing and the number of threads is staying about the same. I'm not sure if that's a bug. ---------------------------------------------------------------------- Comment By: Roman Haefeli (reduzent) Date: 2009-11-28 19:30 Message: Hm.. from the svn log of revision 12760: "Using pthreads to send each message to each client in its own thread." That probably explains, why it stops working after sending X times 'broadcast 97 59 10' to [tcpserver]. Do i understand right, that literally each pd message opens its own <number of clients> threads? Wouldn't it be sufficient to have one thread per socket? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_…

1 0

[ pure-data-Bugs-2905508 ] mrpeach/tcpserver: stops sending after X messages
by SourceForge.net 29 Nov '09

29 Nov '09

Bugs item #2905508, was opened at 2009-11-29 00:20 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: externals Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Roman Haefeli (reduzent) Assigned to: Martin Peach (mrpeach) Summary: mrpeach/tcpserver: stops sending after X messages Initial Comment: After sending 380 messages to one or more clients, [tcpserver] stops sending any more messages. Though TCP is stream-oriented, the number of (pd) messages sent [tcpserver] is significant and not the number of transmitted bytes. Attached is a patch, that illustrates the problem. BTW: the new threaded version is ~15 times faster than the old select() based. It looks very promising. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-11-29 17:47 Message: It was probably the handles that reached a limit, the threads disappear after the data has been sent but their handles were not being cleaned up. Now the threads are created in the detached state so their handles are freed on exit. On WinXP the handles and threads are fairly constant now. I'll leave the patch running to see if it ever hangs, but t seems to be working OK here. ---------------------------------------------------------------------- Comment By: Roman Haefeli (reduzent) Date: 2009-11-29 14:18 Message: Actually, i couldn't figure out, why it stops working after 380 messages. I'd like to know, whether it hit some max number of threads limit. I also couldn't figure out how to display the number of threads being started by a certain process.I found /proc/sys/kernel/threads-max, which is set to 32491 on my system. However, changing the value doesn't effect the behaviour of the test-patch. ---------------------------------------------------------------------- Comment By: Martin Peach (mrpeach) Date: 2009-11-29 06:03 Message: The threads are supposed to terminate themselves after they have sent their buffer. I don't see a need to use threads apart from sending messages. The rest of [tcpserver] works just fine in one thread. Here on WinXP the patch is still running at 66000+. The system is adding handles at about twice the rate as the threads are being created, but the amount of available memory is not decreasing and the number of threads is staying about the same. I'm not sure if that's a bug. ---------------------------------------------------------------------- Comment By: Roman Haefeli (reduzent) Date: 2009-11-29 00:30 Message: Hm.. from the svn log of revision 12760: "Using pthreads to send each message to each client in its own thread." That probably explains, why it stops working after sending X times 'broadcast 97 59 10' to [tcpserver]. Do i understand right, that literally each pd message opens its own <number of clients> threads? Wouldn't it be sufficient to have one thread per socket? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_…

1 0

[ pure-data-Bugs-2905508 ] mrpeach/tcpserver: stops sending after X messages
by SourceForge.net 29 Nov '09

29 Nov '09

1 0

[ pure-data-Bugs-2905508 ] mrpeach/tcpserver: stops sending after X messages
by SourceForge.net 29 Nov '09

29 Nov '09

1 0

[ pure-data-Bugs-2905508 ] mrpeach/tcpserver: stops sending after X messages
by SourceForge.net 29 Nov '09

29 Nov '09

1 0

[ pure-data-Bugs-2905508 ] mrpeach/tcpserver: stops sending after X messages
by SourceForge.net 29 Nov '09

29 Nov '09

Bugs item #2905508, was opened at 2009-11-29 00:20 Message generated for change (Settings changed) made by reduzent You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: externals Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Roman Haefeli (reduzent) >Assigned to: Martin Peach (mrpeach) Summary: mrpeach/tcpserver: stops sending after X messages Initial Comment: After sending 380 messages to one or more clients, [tcpserver] stops sending any more messages. Though TCP is stream-oriented, the number of (pd) messages sent [tcpserver] is significant and not the number of transmitted bytes. Attached is a patch, that illustrates the problem. BTW: the new threaded version is ~15 times faster than the old select() based. It looks very promising. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_…

1 0

[ pure-data-Bugs-2905508 ] mrpeach/tcpserver: stops sending after X messages
by SourceForge.net 29 Nov '09

29 Nov '09

Bugs item #2905508, was opened at 2009-11-29 00:20 Message generated for change (Tracker Item Submitted) made by reduzent You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: externals Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Roman Haefeli (reduzent) Assigned to: Nobody/Anonymous (nobody) Summary: mrpeach/tcpserver: stops sending after X messages Initial Comment: After sending 380 messages to one or more clients, [tcpserver] stops sending any more messages. Though TCP is stream-oriented, the number of (pd) messages sent [tcpserver] is significant and not the number of transmitted bytes. Attached is a patch, that illustrates the problem. BTW: the new threaded version is ~15 times faster than the old select() based. It looks very promising. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905508&group_…

1 0

[ pure-data-Bugs-2905413 ] mrpeach/tcpserver: messages to clients are doubled
by SourceForge.net 28 Nov '09

28 Nov '09

Bugs item #2905413, was opened at 2009-11-28 13:15 Message generated for change (Comment added) made by mrpeach You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905413&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: externals Group: None >Status: Pending >Resolution: Fixed Priority: 5 Private: No Submitted By: Roman Haefeli (reduzent) Assigned to: Martin Peach (mrpeach) Summary: mrpeach/tcpserver: messages to clients are doubled Initial Comment: hello martin I was told, that [tcpserver] was updated to use threading now. so i wanted to test the new version. on my machine, it is not working correctly yet. messages sent from [tcpserver] are doubled for some reason. when sending this message with [tcpserver] (it doesn't matter, whether i use the 'send <socketnumber>' or the 'broadcast' method): 97 98 99 100 101 102 103 104 105 i get this on the client side: 97 98 99 100 101 102 103 104 105 97 98 99 100 101 102 103 104 105 sometimes even this: 97 97 98 99 100 101 102 103 104 105 98 99 100 101 102 103 104 105 this is with [tcpserver] compiled from svn checkout from today on pd-0.42.5 on ubuntu 9.10. ---------------------------------------------------------------------- >Comment By: Martin Peach (mrpeach) Date: 2009-11-28 16:42 Message: Oops, I hadn't commented out the original unthreaded call to send, so it was doing both :( Should work now, at least it does here. Also I added threaded send for files. Thanks for testing! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478070&aid=2905413&group_…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pd-dev November 2009