Patches item #1943614, was opened at 2008-04-16 06:25
Message generated for change (Comment added) made by jleben
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1943614&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jakob Leben (jleben)
Assigned to: Nobody/Anonymous (nobody)
>Summary: speed up 'graph on parent'
Initial Comment:
Here is the update of my patch filed as 1943301 (move instead of draw when 'graphed on parent') - now made with diff -uwB ;)
I fixed both of the bugs mentioned when I posted the first version of this patch. I noticed that one of them, namely the name of garray missing when array is created was a general bug and not produced by my code. This is now solved also, for the good of the pd community!
I also added iemgui_graph function which now all iemgui objects call as their graph_fn function and it in turn calls object's x_gui.x_draw function. This allows for graph_displace to make generic calls to graph_fn functions of all of it's children.
I would also like to point out that this patch only offers the possibility to use Tk command move for moving graphics of objects which are 'graphed on parent'. To add graph_fn functions to all the pd-vanilla objects I simply copied the code they use to draw themselves when being displaced, and currently many of them actually redraw themselves instead of just move. I paid attention that garray's graphics are really moved though, because to speed up array drawing was the main objective of writing this patch.
One problem I wish to point at is: if an object uses iemgui_displace function (and it holds the same now for new iemgui_graph function) it actually loses possibility to easily use Tk move command, because iemgui functions don't pass the dx and dy arguments to local object's functions they call for drawing. Thus using iemgui_displace and iemgui_graph makes it even less convenient and effective. I think iemgui functions should do more to make writing of gui externals easy.
----------------------------------------------------------------------
>Comment By: Jakob Leben (jleben)
Date: 2008-04-16 20:17
Message:
Logged In: YES
user_id=2064182
Originator: YES
NEW FIXES:
- displacing a graph on parent when it has it's window open moves
graphical content inside this window.
- displacing nested graphs on parent doesn't work (crash)
I realized that there IS quite a lot of externals that use widget
behaviors, so I also made another patch witch only fixes slow displacing of
arrays and doesn't bring new widgetbehavior. This one can safely be used
with pd-extended.
File Added: pd-0.41-4-leben.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1943614&group_…
Bugs item #1912772, was opened at 2008-03-12 16:05
Message generated for change (Settings changed) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1912772&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pd-extended
Group: None
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Martin Peach (mrpeach)
Assigned to: Hans-Christoph Steiner (eighthave)
Summary: zexy dlls don't load from Pd-0.40.3 windowsxp
Initial Comment:
zexy dlls from the nightly autobuilds don't load but abstractions do.
Zexy's README.txt says:
configure tries to set the CFLAGS to "-g -O2" if the compiler accepts this; however, this optimization sometimes generates binaries that cannot be loaded by pd; it seems that disabling the "unit-at-a-time" optimization (which gets enabled by "-O2") is the cause of this problem, turning it off might help
This seems to be the case here. The log from 2008-03-12_05.54.05_mingw32_nt-5.1_windowsxp-i386_pd-extended_run-automated-builder.txt has:
gcc -I. -DHAVE_CONFIG_H -DPD -I/home/pd/auto-build/pd-extended/pd/src -g -O2 -mms-bitfields -fPIC -mfpmath=sse -msse -c -o 0x260x260x7e.o 0x260x260x7e.c
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-04-16 19:26
Message:
Logged In: YES
user_id=564396
Originator: NO
i think this has been fixed now in CVS
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-04-11 17:23
Message:
Logged In: YES
user_id=564396
Originator: NO
the problem seems to be the linker-flag "-export_dynamic"; without this
flag, externals load just fine.
hmm, i have to think about this...
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-04-10 11:39
Message:
Logged In: YES
user_id=564396
Originator: NO
weird: when i manually build a zexy-object on the buildform machine (XP),
they work fine (with exactly the same flags as i see in the autobuild-logs)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1912772&group_…
Bugs item #1944125, was opened at 2008-04-16 15:24
Message generated for change (Settings changed) made by xovo
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1944125&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
>Assigned to: Winfried Ritsch (ritsch)
Summary: comport: stop bit settings
Initial Comment:
It seems that the comport object doesn't handle stop bit settings correctly (at least under Windows). I have frequent crashes with keyspan drivers (which seem to be buggy too) because of that.
x->dcb.StopBits has three possible settings
0 for 1 stop bit, 1 for 1.5 bits, 2 for 2 bits
There seems to be a mismatch between the set_serial function, with
x->stop_bits = x->dcb.StopBits;
and the set_stopflag function, where there's only a a check whether nr == 1.
A quick and dirty fix that works for me is to set (in set_serial):
x->stop_bits = (x->dcb.StopBits)?1:0;
but that's no real solution.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1944125&group_…
Bugs item #1944125, was opened at 2008-04-16 15:24
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1944125&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: externals
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Nobody/Anonymous (nobody)
Summary: comport: stop bit settings
Initial Comment:
It seems that the comport object doesn't handle stop bit settings correctly (at least under Windows). I have frequent crashes with keyspan drivers (which seem to be buggy too) because of that.
x->dcb.StopBits has three possible settings
0 for 1 stop bit, 1 for 1.5 bits, 2 for 2 bits
There seems to be a mismatch between the set_serial function, with
x->stop_bits = x->dcb.StopBits;
and the set_stopflag function, where there's only a a check whether nr == 1.
A quick and dirty fix that works for me is to set (in set_serial):
x->stop_bits = (x->dcb.StopBits)?1:0;
but that's no real solution.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1944125&group_…
Bugs item #1942204, was opened at 2008-04-14 17:49
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1942204&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pdpedia
Group: None
>Status: Open
>Resolution: None
Priority: 7
Private: No
Submitted By: oli44 (oli44)
Assigned to: Nobody/Anonymous (nobody)
Summary: pdpedia Captcha
Initial Comment:
Feature request:
is it possible to install a captcha system to avoid pdpedia being spammed so outrageously ?
maybe useful link : http://wiki.seds.org/index.php/MediaWiki:Captcha
----------------------------------------------------------------------
>Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-04-16 11:00
Message:
Logged In: YES
user_id=564396
Originator: NO
i checked the "recent changes" log now, and i see that the spam is back
again :(
to whom should pdpedia related bugs be assigned?
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 19:23
Message:
Logged In: YES
user_id=27104
Originator: NO
Any admin can easily delete those junk posts with the 'delete' tab and
also protect problem pages. A captcha might help, I haven't seen one for
mediawiki before.
Check the "recent changes" log now, and you'll see the spam is gone. :)
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-04-15 09:15
Message:
Logged In: YES
user_id=564396
Originator: NO
i agree that pdpedia has lost lots of it's initial charme just because of
this: according to the "recent changes" page, of the last 376 changes 361
were garbage.
luckily most of these garbage changes are targeted on few pages
(Template:vanilla has 257 changes; Template:jmmmp has 99 changes)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1942204&group_…
Bugs item #1942204, was opened at 2008-04-14 11:49
Message generated for change (Settings changed) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1942204&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: pdpedia
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 7
Private: No
Submitted By: oli44 (oli44)
Assigned to: Nobody/Anonymous (nobody)
Summary: pdpedia Captcha
Initial Comment:
Feature request:
is it possible to install a captcha system to avoid pdpedia being spammed so outrageously ?
maybe useful link : http://wiki.seds.org/index.php/MediaWiki:Captcha
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 13:23
Message:
Logged In: YES
user_id=27104
Originator: NO
Any admin can easily delete those junk posts with the 'delete' tab and
also protect problem pages. A captcha might help, I haven't seen one for
mediawiki before.
Check the "recent changes" log now, and you'll see the spam is gone. :)
----------------------------------------------------------------------
Comment By: IOhannes m zmölnig (zmoelnig)
Date: 2008-04-15 03:15
Message:
Logged In: YES
user_id=564396
Originator: NO
i agree that pdpedia has lost lots of it's initial charme just because of
this: according to the "recent changes" page, of the last 376 changes 361
were garbage.
luckily most of these garbage changes are targeted on few pages
(Template:vanilla has 257 changes; Template:jmmmp has 99 changes)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478070&aid=1942204&group_…
Patches item #1943614, was opened at 2008-04-16 06:25
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1943614&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata-dev
Group: feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jakob Leben (jleben)
Assigned to: Nobody/Anonymous (nobody)
Summary: patch 1943301 updated
Initial Comment:
Here is the update of my patch filed as 1943301 (move instead of draw when 'graphed on parent') - now made with diff -uwB ;)
I fixed both of the bugs mentioned when I posted the first version of this patch. I noticed that one of them, namely the name of garray missing when array is created was a general bug and not produced by my code. This is now solved also, for the good of the pd community!
I also added iemgui_graph function which now all iemgui objects call as their graph_fn function and it in turn calls object's x_gui.x_draw function. This allows for graph_displace to make generic calls to graph_fn functions of all of it's children.
I would also like to point out that this patch only offers the possibility to use Tk command move for moving graphics of objects which are 'graphed on parent'. To add graph_fn functions to all the pd-vanilla objects I simply copied the code they use to draw themselves when being displaced, and currently many of them actually redraw themselves instead of just move. I paid attention that garray's graphics are really moved though, because to speed up array drawing was the main objective of writing this patch.
One problem I wish to point at is: if an object uses iemgui_displace function (and it holds the same now for new iemgui_graph function) it actually loses possibility to easily use Tk move command, because iemgui functions don't pass the dx and dy arguments to local object's functions they call for drawing. Thus using iemgui_displace and iemgui_graph makes it even less convenient and effective. I think iemgui functions should do more to make writing of gui externals easy.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1943614&group_…
Patches item #1930681, was opened at 2008-03-31 19:44
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930681&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Miller Puckette (millerpuckette)
Summary: 0.41-4 s_path.c fixes
Initial Comment:
Two fixes for buffer overrun (buf[1000]=0 later) and rc file args:
--- s_path.ori.c 2008-04-01 01:37:03.000000000 +0200
+++ s_path.c 2008-04-01 01:38:02.000000000 +0200
@@ -379,7 +379,7 @@
int rcargc;
char* rcargv[NUMARGS];
char* buffer;
- char fname[MAXPDSTRING], buf[1000], *home = getenv("HOME");
+ char fname[MAXPDSTRING], buf[1001], *home = getenv("HOME");
int retval = 1; /* that's what we will return at the end; for now, let's think it'll be an error */
/* initialize rc-arg-array so we can safely clean up at the end */
@@ -423,7 +423,7 @@
fclose(file);
if (sys_verbose)
{
- if (rcargv)
+ if (rcargc)
{
post("startup args from RC file:");
for (i = 1; i < rcargc; i++)
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 19:59
Message:
Logged In: YES
user_id=27104
Originator: NO
checked into branches/pd-extended/0.40
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930681&group_…
Patches item #1930769, was opened at 2008-03-31 22:09
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930769&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata
Group: bugfix
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Miller Puckette (millerpuckette)
Summary: 0.41-4 fix memory leak with array sinesum/cosinesum
Initial Comment:
svecs are allocated twice....
--- ../src.ori/g_array.c 2008-03-15 01:03:00.000000000 +0100
+++ g_array.c 2008-04-01 04:05:50.000000000 +0200
@@ -1221,7 +1221,7 @@
static void garray_sinesum(t_garray *x, t_symbol *s, int argc, t_atom *argv)
{
- t_float *svec = (t_float *)t_getbytes(sizeof(t_float) * argc);
+ t_float *svec;
int npoints, i;
if (argc < 2)
{
@@ -1244,7 +1244,7 @@
static void garray_cosinesum(t_garray *x, t_symbol *s, int argc, t_atom *argv)
{
- t_float *svec = (t_float *)t_getbytes(sizeof(t_float) * argc);
+ t_float *svec;
int npoints, i;
if (argc < 2)
{
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 19:51
Message:
Logged In: YES
user_id=27104
Originator: NO
checked this into branches/pd-extended/0.40
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930769&group_…
Patches item #1930733, was opened at 2008-03-31 21:02
Message generated for change (Comment added) made by eighthave
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930733&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: puredata
Group: bugfix
Status: Open
Resolution: None
>Priority: 7
Private: No
Submitted By: Thomas Grill (xovo)
Assigned to: Miller Puckette (millerpuckette)
Summary: 0.41-4: prevent buffer overrun in m_class.c
Initial Comment:
the array only has MAXPDARG elements.......
--- m_class.ori.c 2008-04-01 03:00:09.000000000 +0200
+++ m_class.c 2008-04-01 03:00:12.000000000 +0200
@@ -763,7 +763,7 @@
va_start(ap, fmt);
while (1)
{
- if (nargs > MAXPDARG)
+ if (nargs >= MAXPDARG)
{
pd_error(x, "pd_vmess: only %d allowed", MAXPDARG);
break;
----------------------------------------------------------------------
>Comment By: Hans-Christoph Steiner (eighthave)
Date: 2008-04-15 19:42
Message:
Logged In: YES
user_id=27104
Originator: NO
checked into branches/pd-extended/0.40
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1930733&group_…