Thanks for the info. I can confirm the droidparty [touch] abstraction works again with that change. Should be a simple enough change to fix things.
As I recall, that change was for a good reason but too bad that subtly was perhaps lost in communication. Luckily it's an easy fix!
On Mar 2, 2018, at 12:00 PM, pd-list-request@lists.iem.at wrote:
From: oliver <oliver@klingt.org mailto:oliver@klingt.org> To: Pd-List <pd-list@mail.iem.at mailto:pd-list@mail.iem.at> Subject: Re: [PD] droidparty's [touch] on 0.48-1 and "grid" like object in vanilla Message-ID: <a7c2267f-e153-f5c6-4233-1c89fe176fec@klingt.org mailto:a7c2267f-e153-f5c6-4233-1c89fe176fec@klingt.org> Content-Type: text/plain; charset=UTF-8; format=flowed
My hunch is Miller or somebody changed something with the unsupported donecanvasdialog messages that those droidparty abstractions are (ab)using, but I do not have evidence for this yet.
indeed, for what i know, "donecanvasdialog" changed with 0.48 ! (there has been a post on this list by christof ressi some months ago) https://www.mail-archive.com/pd-list@lists.iem.at/msg12504.html https://www.mail-archive.com/pd-list@lists.iem.at/msg12504.html
the third argument (the one that represents the "graph on parent" and "hide object names and arguments" checkboxes) has changed its counting method.
what used to be "2" in earlier PD versions (both checkboxes ticked) must now say "3":
so until PD 0.47 it was: donecanvasdialog 1 -1 2 0 -1 1 1 120 60 10 10, dirty 0
from PD 0.48 on it's: donecanvasdialog 1 -1 3 0 -1 1 1 120 60 10 10, dirty 0
that broke my GOP patches too, but i already updated them all accordingly. not too much work ...
but i really think this should be mentioned in capital letters in the release notes for PD 0.48, since i'm sure many people "exploited" this feature to build their customized GUIs
best
oliver
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
Here's a copy of touch which works again and I added inlets & outlets. I can probably make a PR later with fixes to the abstractions, but just sending this along for now.
On Mar 2, 2018, at 2:02 PM, Dan Wilcox danomatika@gmail.com wrote:
Thanks for the info. I can confirm the droidparty [touch] abstraction works again with that change. Should be a simple enough change to fix things.
As I recall, that change was for a good reason but too bad that subtly was perhaps lost in communication. Luckily it's an easy fix!
On Mar 2, 2018, at 12:00 PM, pd-list-request@lists.iem.at mailto:pd-list-request@lists.iem.at wrote:
From: oliver <oliver@klingt.org mailto:oliver@klingt.org> To: Pd-List <pd-list@mail.iem.at mailto:pd-list@mail.iem.at> Subject: Re: [PD] droidparty's [touch] on 0.48-1 and "grid" like object in vanilla Message-ID: <a7c2267f-e153-f5c6-4233-1c89fe176fec@klingt.org mailto:a7c2267f-e153-f5c6-4233-1c89fe176fec@klingt.org> Content-Type: text/plain; charset=UTF-8; format=flowed
My hunch is Miller or somebody changed something with the unsupported donecanvasdialog messages that those droidparty abstractions are (ab)using, but I do not have evidence for this yet.
indeed, for what i know, "donecanvasdialog" changed with 0.48 ! (there has been a post on this list by christof ressi some months ago) https://www.mail-archive.com/pd-list@lists.iem.at/msg12504.html https://www.mail-archive.com/pd-list@lists.iem.at/msg12504.html
the third argument (the one that represents the "graph on parent" and "hide object names and arguments" checkboxes) has changed its counting method.
what used to be "2" in earlier PD versions (both checkboxes ticked) must now say "3":
so until PD 0.47 it was: donecanvasdialog 1 -1 2 0 -1 1 1 120 60 10 10, dirty 0
from PD 0.48 on it's: donecanvasdialog 1 -1 3 0 -1 1 1 120 60 10 10, dirty 0
that broke my GOP patches too, but i already updated them all accordingly. not too much work ...
but i really think this should be mentioned in capital letters in the release notes for PD 0.48, since i'm sure many people "exploited" this feature to build their customized GUIs
best
oliver
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
Ok, I made the PR.
On Mar 2, 2018, at 2:21 PM, Dan Wilcox danomatika@gmail.com wrote:
Here's a copy of touch which works again and I added inlets & outlets. I can probably make a PR later with fixes to the abstractions, but just sending this along for now.
<touch.pd>
On Mar 2, 2018, at 2:02 PM, Dan Wilcox <danomatika@gmail.com mailto:danomatika@gmail.com> wrote:
Thanks for the info. I can confirm the droidparty [touch] abstraction works again with that change. Should be a simple enough change to fix things.
As I recall, that change was for a good reason but too bad that subtly was perhaps lost in communication. Luckily it's an easy fix!
On Mar 2, 2018, at 12:00 PM, pd-list-request@lists.iem.at mailto:pd-list-request@lists.iem.at wrote:
From: oliver <oliver@klingt.org mailto:oliver@klingt.org> To: Pd-List <pd-list@mail.iem.at mailto:pd-list@mail.iem.at> Subject: Re: [PD] droidparty's [touch] on 0.48-1 and "grid" like object in vanilla Message-ID: <a7c2267f-e153-f5c6-4233-1c89fe176fec@klingt.org mailto:a7c2267f-e153-f5c6-4233-1c89fe176fec@klingt.org> Content-Type: text/plain; charset=UTF-8; format=flowed
My hunch is Miller or somebody changed something with the unsupported donecanvasdialog messages that those droidparty abstractions are (ab)using, but I do not have evidence for this yet.
indeed, for what i know, "donecanvasdialog" changed with 0.48 ! (there has been a post on this list by christof ressi some months ago) https://www.mail-archive.com/pd-list@lists.iem.at/msg12504.html https://www.mail-archive.com/pd-list@lists.iem.at/msg12504.html
the third argument (the one that represents the "graph on parent" and "hide object names and arguments" checkboxes) has changed its counting method.
what used to be "2" in earlier PD versions (both checkboxes ticked) must now say "3":
so until PD 0.47 it was: donecanvasdialog 1 -1 2 0 -1 1 1 120 60 10 10, dirty 0
from PD 0.48 on it's: donecanvasdialog 1 -1 3 0 -1 1 1 120 60 10 10, dirty 0
that broke my GOP patches too, but i already updated them all accordingly. not too much work ...
but i really think this should be mentioned in capital letters in the release notes for PD 0.48, since i'm sure many people "exploited" this feature to build their customized GUIs
best
oliver
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
Hi,
Merged and updated on the website. Thanks!
Chris.
On 02/03/18 21:55, Dan Wilcox wrote:
Ok, I made the PR.
-
Chris McCormick -
Dan Wilcox