On Oct 26, 2011, at 7:59 PM, Ivica Ico Bukvic wrote:
-----Original Message----- From: Hans-Christoph Steiner [mailto:hans@at.or.at] Sent: Wednesday, October 26, 2011 3:19 PM To: Ivica Ico Bukvic Cc: 'Roman Haefeli'; pd-list@iem.at Subject: Re: [PD] New versions of pd-l2ork now available on git
On Oct 26, 2011, at 2:49 PM, Ivica Ico Bukvic wrote:
I'd love to be able to include bugfixes from pd-l2ork. I looked thru the code and I can't really find what changes belong to what Changelog items. Can you point me towards the code related to these
Changelog
items, and expand on what they do, if you can? Then I can work on including them in Pd-extended:
*Implemented universal copy/paste *Fixed gop redrawing issue when passed coords message via script *finally discovered the root of all double-entry bugs (fingers crossed) and reverted all other previous workarounds for this problem. *fixed bug where patch cords were not getting erased (due to fundamental fixes in the previous patch how the things are being destructed, this has resulted in this bug being "hidden" until now).
Many of the older pre-git day bugs can be only traced by diff-ing our extensive snapshot repository available here:
http://l2ork.music.vt.edu/data/pd/
This is in part why we've set up a git. To make this transition easier for other branches...
Hope this helps!
Best wishes,
Ico
One thing that you could do that would make the history much easier to browse is to start your git repo from the pure-data.git from Miller, then untar each pd_l2ork release on top and check each release in, then add the current contents of your git on top of that.
I can do that for you, if that would be helpful. It would only be worthwhile if this then replaces the contents of your current git repo.
If you think this would yield favorable results then I'd say let's go for it. My concern is that in the process of learning the pd code which has a relatively steep learning curve I ended up a good chunk of comments and reformatted some of the code to make things more legible for me (which does not mean it would also be legible for others). I also had to backtrack some of the changes and temporary hacks until I discovered the root of the problem (e.g. double-entry bug which has been entirely solved in pd-l2ork, or the gop redrawing bugs which have been also solved, and most recently enabling and immediately disabling gop that crashes any pd but pd-l2ork). One last roadblock is that the Changelog was not date stamped right from the outset so some of the earlier patches may not be easily decipherable but I can assist with those to the best of my ability.
So, please let me know if you wish to proceed and you'll have my full support.
It looks like it'll take overnight to download all of the pd-l2ork-dev tarballs. So should be able to have this done tomorrow. You still up for swapping this in as your git repo?
.hc
If you are not part of the solution, you are part of the problem.