[ pure-data-Patches-1309457 ] proper initialization and fix some memleaks - Pd-dev

10 Oct 2005


      Patches item #1309457, was opened at 2005-09-30 14:48
Message generated for change (Comment added) made by zmoelnig
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1309457...
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: puredata
Group: bugfix
...
Status: Closed
Resolution: Fixed
Priority: 5
Submitted By: IOhannes m zmÃ¶lnig (zmoelnig)
Assigned to: Miller Puckette (millerpuckette)
Summary: proper initialization and fix some memleaks
Initial Comment:
running pd with profilers like valgrind show some
memory leaks and that several values don't get properly
initialized.
attached is a patch that
a) fixes the use of unitialized values in s_file.c
(thanks to matju) due to improper bracketing
b) fixes some tiny memory leaks (they are not really
crucial, being in the pdsettings-loader which is only
called once)
TODO: do more profiling (currently i just start pd and
quit it....) to find more memory leaks and fix them
----------------------------------------------------------------------
...
Comment By: IOhannes m zmÃ¶lnig (zmoelnig)
Date: 2005-10-10 13:33
Message:
Logged In: YES 
user_id=564396
so i think miller kind of accepted this....
----------------------------------------------------------------------
Comment By: Miller Puckette (millerpuckette)
Date: 2005-10-08 21:13
Message:
Logged In: YES 
user_id=313747
I took the Mathieu bugfixes and the changes to s_path.c ...
as to explicitly
freeing all mallocs, this needs a more general mechanism. 
The sys_cleanup
mechanism would be cleaner if called once from s_entry.c --
but now
I see that someone should get in and close all the
audio/midi devices
too (this seems not to happen currently if we "quit"
cleanly, only if
we quit via glob_quit() -- and if via glob_quit, we never
get to sys_cleanup.
I now think this all just needs a rewrite.
----------------------------------------------------------------------
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1309457...