Patches item #2584887, was opened at 2009-02-10 07:12 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2584887...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Frank Barknecht (fbar) Assigned to: Miller Puckette (millerpuckette) Summary: bonk ignores relative paths when reading templates

Initial Comment: bonk~ can not open previously stored attack templates when only a relative path is supplied to the "read templates.txt" message.

bonk~ also ignores any [declare] declarations when searching for template files and only works with absolute paths or templates in the working directory PPd was started from.

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)

Date: 2009-02-15 23:29

Message: one detail: MAXPDSTRING is longer than FILENAME_MAX on Windows, so to prevent crasher bugs, any time a file path is stored, FILENAME_MAX should be used instead of MAXPDSTRING.

----------------------------------------------------------------------

Comment By: Frank Barknecht (fbar) Date: 2009-02-10 11:07

Message: Okay, attached is a patch that changes the "read" and "write" messages to use canvas-relative paths. Tested only briefly, but seems to work. Diff against current SVN HEAD. File Added: bonk~.c.diff

----------------------------------------------------------------------

Comment By: Frank Barknecht (fbar) Date: 2009-02-10 07:19

Message: bonk~ should probably use the canvas_open() method to open files instead of a plain fdopen()

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=2584887...