Patches item #3048061, was opened at 2010-08-18 16:24 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3048061...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix

Status: Closed Resolution: Accepted

Priority: 7 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: make text_ypix() run only if visible, fixing GOP crashes

Initial Comment: So I am trying to track down some intermittent crashes related to GOP. The actual crash happens when hslider_draw_update() is called with a NULL glist as its second argument. Its intermittent and not easy to reproduce, but I have seen it about 20 times with the exact same stacktrace.

Here's the backtrace that I am getting: 0 pd 0x0001668f graph_graphrect + 15 (g_graph.c:619) 1 pd 0x00016a77 glist_ytopixels + 128 (g_graph.c:594) 2 pd 0x00016b71 text_ypix + 109 (g_graph.c:636) 3 pd 0x0004153e hslider_draw_update + 43 (g_hslider.c:40) 4 pd 0x00062769 sys_pollgui + 179 (s_inter.c:764) 5 pd 0x0005edd8 m_mainloop + 814 (m_sched.c:493) 6 pd 0x000618bf sys_main + 2909 (s_main.c:304) 7 pd 0x00002622 _start + 216 8 pd 0x00002549 start + 41

Since the crash here is related to hslider_draw_update() calling text_ypix(), and the rest of the GUI objects don't call text_ypix()/text_xpix() unless visible, I think its a good idea for hslider to do the same.

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)

Date: 2010-08-31 23:31

Message: accepted with git commit 1bbc14d7425dca98684755b413963c72658c366d

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3048061...