Hallo, IOhannes m zmoelnig hat gesagt: // IOhannes m zmoelnig wrote:
imo, it is bad by design to use a local (dead) copy of a header-file when there is living one next door.
I believe this is a leftover from the time, when there wasn't an "official" header in the CVS, because "devel" was HEAD.
It should be changed, shouldn't it? And this topic maybe should go to pd-dev as well.
Ciao
Frank Barknecht wrote:
It should be changed, shouldn't it? And this topic maybe should go to pd-dev as well.
good idea!
since i seldom use the build-system i just tried it out now.
one big question for me is: why is fiddle~ (and friends) in there ? since i did not think that they should be duplicated in the externals-section of the CVS, i never checked them out.
this breaks the build-system (without a single typo...)
mfg.asd.r IOhannes
On Apr 12, 2005, at 7:48 AM, IOhannes m zmoelnig wrote:
Frank Barknecht wrote:
Hallo, It should be changed, shouldn't it?
since i am the fastest typer i have done so. all "./include"-files are linked to the current versions via h-includes.
Actually, the complete headers need to be there. externals/build/include is mostly there for building the debian package. All of the source code for building the externals package needs to be included within the 'externals' directory in order for the Debian auto-builders to build properly.
The other option would be to make a debian source package for Pd, then we could get rid of externals/build/include.
I updated the headers with the files from pd-0.38-4 and added a README since you aren't the first to make this mistake. (I made this mistake too, I should have written the README then... oh well... ).
Also, I changed the INCLUDES in linux/makefile, win/makefile, and darwin/makefile so that it'll look for the headers in the pd source (according to the standard CVS dev layout) before looking in externals/build/include.
From this: INCLUDES = -I. -I.. -I../include
to this: INCLUDES = -I. -I.. -I../../../pd/src -I../include
.hc ________________________________________________________________________ ____
Man has survived hitherto because he was too ignorant to know how to realize his wishes. Now that he can realize them, he must either change them, or perish. -William Carlos Williams
Hans-Christoph Steiner wrote:
On Apr 12, 2005, at 7:48 AM, IOhannes m zmoelnig wrote:
Actually, the complete headers need to be there.
oh ;-)
externals/build/include is mostly there for building the debian package. All of the source code for building the externals package needs to be included within the 'externals' directory in order for the Debian auto-builders to build properly.
i still think that it is stupid to have to maintain 2 separate (but hopefully identical) versions of 1 file in a repository. this is error-prone.
if a build system depends on this behaviour, than (imo) there should be a script (since we are talking about debian we can use standard bash-scripts or whatever) that makes a local copy of the files from (say) pd/src to externals/build/include so the duplication should be on the client machine (because it depends on it) and not on the server (for convenience reasons)
The other option would be to make a debian source package for Pd, then we could get rid of externals/build/include.
since this sounds perfect to me, i understand even less why it is handled like it is (but i don't have too much time too)
I updated the headers with the files from pd-0.38-4 and added a README since you aren't the first to make this mistake. (I made this mistake too, I should have written the README then... oh well... ).
right,thanks
Also, I changed the INCLUDES in linux/makefile, win/makefile, and darwin/makefile so that it'll look for the headers in the pd source (according to the standard CVS dev layout) before looking in externals/build/include.
From this: INCLUDES = -I. -I.. -I../include
to this: INCLUDES = -I. -I.. -I../../../pd/src -I../include
but i guess this cannot handle things like creb's extlib_util.h and zexy.h; (but they can probably handled withthe h-includes (?))
mfg.cw.ser IOhannes
-
Frank Barknecht -
Hans-Christoph Steiner -
IOhannes m zmoelnig