Patches item #1242495, was opened at 2005-07-21 14:07 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1242495...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: changing properties doesn't set "modified" status

Initial Comment:

When you change the properties of an object, it does not set the "dirty" or "modified" flag on the patch. Therefore, Pd does not prompt to save if that patch is closed and those changes are lost.

To see this bug in action, make a new patch, and place a GUI bang object on the canvas (i.e. [bng]), then save the file. Now, open the properties dialog of that bang and change the color of it and it OK. When you close the patch, it does not prompt you to save your changes.

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave)

Date: 2010-07-29 22:50

Message: git commit 9f945f0121c99d2fac419475c764c4163f8c8f67

----------------------------------------------------------------------

Comment By: Hans-Christoph Steiner (eighthave) Date: 2008-04-28 11:34

Message: Logged In: YES user_id=27104 Originator: YES

Attached is a patch that fixes this for all canvas-related properties panels (i.e. NOT the audio/midi/path/startup pref panels). This should work for adding and deleting cords, and properties panels for: canvas, arrays, iemguis, and atom boxes.

The only downside is that with the properties panels, there is no checking whether there has actually be any change. I just sets the dirty flag if the user clicks on OK or Apply. File Added: cords_and_properties_set_dirty-0.41.4.patch

----------------------------------------------------------------------

Comment By: Matteo Sisti Sette (sistisette) Date: 2007-05-27 11:08

Message: Logged In: YES user_id=1709568 Originator: NO

Not only changing properties of an object.

Also deleting an existing connection does not set the modified flag!

To see the bug in action: Make a new patch, create any two objects and connect them in any way (any inlet of one to any outlet of the other), then save the file. Now, click on the wire connection and delete it, without moving the objects. When you close the patch, it does not prompt you to save your changes.

This is true both for control and signal connections.

At least Windows XP, version 0.40-2

Should I post this as a separate bug?

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1242495...