Howdy all,
I noticed today that g_all_guis.h does not have #if/#def include guards. Is this an oversight or is there some reason?
-------- Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com/ robotcowboy.com http://robotcowboy.com/
I am pretty sure this is an oversight. The header contains struct declarations, so it must be guarded and #defines, so it must be guarded.
On 11.08.2020 11:39, Dan Wilcox wrote:
Howdy all,
I noticed today that g_all_guis.h does not have #if/#def include guards. Is this an oversight or is there some reason?
Dan Wilcox @danomatika http://twitter.com/danomatika danomatika.com http://danomatika.com robotcowboy.com http://robotcowboy.com
Pd-dev mailing list Pd-dev@lists.iem.at https://lists.puredata.info/listinfo/pd-dev
I originally didn't put "include guards" in any Pd source files as they were never necessary (and I always thought that, when possible, it's better to do all your including yourself instead of letting files defensively include stuff). But this is clearly not workable once things get to a certain level of lib-calling-lib-calling-lib complexity, so I guess it's time to stick them in. The others all got fixed by one PR or another. I'll go on and fix this one.
cheers M On Tue, Aug 11, 2020 at 11:53:01AM +0200, Christof Ressi wrote:
I am pretty sure this is an oversight. The header contains struct declarations, so it must be guarded and #defines, so it must be guarded.
On 11.08.2020 11:39, Dan Wilcox wrote:
Howdy all,
I noticed today that g_all_guis.h does not have #if/#def include guards. Is this an oversight or is there some reason?
Dan Wilcox @danomatika <https://urldefense.com/v3/__http://twitter.com/danomatika__;!!Mih3wA!QEH0Dvc... > danomatika.com <https://urldefense.com/v3/__http://danomatika.com__;!!Mih3wA!QEH0DvcmOi6V-n_... > robotcowboy.com <https://urldefense.com/v3/__http://robotcowboy.com__;!!Mih3wA!QEH0DvcmOi6V-n... >
Pd-dev mailing list Pd-dev@lists.iem.at https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!...
Pd-dev mailing list Pd-dev@lists.iem.at https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!...
Followup... it looks like include files that are there for Pd internal use aren't guarded (s.stuff.h for example). This makes me wonder - is there any reason one would include g_all_guis.h outside of teh context of Pd itself?
cheers M
On Tue, Aug 11, 2020 at 11:39:38AM +0200, Dan Wilcox wrote:
Howdy all,
I noticed today that g_all_guis.h does not have #if/#def include guards. Is this an oversight or is there some reason?
Dan Wilcox @danomatika <https://urldefense.com/v3/__http://twitter.com/danomatika__;!!Mih3wA!ULqJSOP... > danomatika.com <https://urldefense.com/v3/__http://danomatika.com/__;!!Mih3wA!ULqJSOPbxFvrQ3... > robotcowboy.com <https://urldefense.com/v3/__http://robotcowboy.com/__;!!Mih3wA!ULqJSOPbxFvrQ... >
Pd-dev mailing list Pd-dev@lists.iem.at https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!...
It seems some externals use g_all_guis.h, I've seen it but can't remember where - I'll try to guess mknob and flatgui/knob use it?
Em sex., 14 de ago. de 2020 às 19:55, Miller Puckette via Pd-dev < pd-dev@lists.iem.at> escreveu:
Followup... it looks like include files that are there for Pd internal use aren't guarded (s.stuff.h for example). This makes me wonder - is there any reason one would include g_all_guis.h outside of teh context of Pd itself?
cheers M
On Tue, Aug 11, 2020 at 11:39:38AM +0200, Dan Wilcox wrote:
Howdy all,
I noticed today that g_all_guis.h does not have #if/#def include guards.
Is this an oversight or is there some reason?
Dan Wilcox @danomatika <
https://urldefense.com/v3/__http://twitter.com/danomatika__;!!Mih3wA!ULqJSOP...
danomatika.com <
https://urldefense.com/v3/__http://danomatika.com/__;!!Mih3wA!ULqJSOPbxFvrQ3...
robotcowboy.com <
https://urldefense.com/v3/__http://robotcowboy.com/__;!!Mih3wA!ULqJSOPbxFvrQ...
Pd-dev mailing list Pd-dev@lists.iem.at
https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!...
Pd-dev mailing list Pd-dev@lists.iem.at https://lists.puredata.info/listinfo/pd-dev
hmm... that's a good enough reason I guess :)
M On Fri, Aug 14, 2020 at 08:00:36PM -0300, Alexandre Torres Porres wrote:
It seems some externals use g_all_guis.h, I've seen it but can't remember where - I'll try to guess mknob and flatgui/knob use it?
Em sex., 14 de ago. de 2020 ??s 19:55, Miller Puckette via Pd-dev < pd-dev@lists.iem.at> escreveu:
Followup... it looks like include files that are there for Pd internal use aren't guarded (s.stuff.h for example). This makes me wonder - is there any reason one would include g_all_guis.h outside of teh context of Pd itself?
cheers M
On Tue, Aug 11, 2020 at 11:39:38AM +0200, Dan Wilcox wrote:
Howdy all,
I noticed today that g_all_guis.h does not have #if/#def include guards.
Is this an oversight or is there some reason?
Dan Wilcox @danomatika <
https://urldefense.com/v3/__http://twitter.com/danomatika__;!!Mih3wA!ULqJSOP...
danomatika.com <
https://urldefense.com/v3/__http://danomatika.com/__;!!Mih3wA!ULqJSOPbxFvrQ3...
robotcowboy.com <
https://urldefense.com/v3/__http://robotcowboy.com/__;!!Mih3wA!ULqJSOPbxFvrQ...
Pd-dev mailing list Pd-dev@lists.iem.at
https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!...
Pd-dev mailing list Pd-dev@lists.iem.at https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!...
-
Alexandre Torres Porres -
Christof Ressi -
Dan Wilcox -
Miller Puckette