Patches item #1370034, was opened at 2005-11-30 08:25 Message generated for change (Comment added) made by matju You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1370034...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata-dev Group: wishlist Status: Pending Resolution: None Priority: 5 Private: No Submitted By: Thomas Grill (xovo) Assigned to: Nobody/Anonymous (nobody) Summary: Matju's beautifications (untested)
Initial Comment: Hey all, here's Matju's changes to the devel_0_39 codebase.
There's a bug inside m_class.c, function pd_typedmess, where the break is missing at the end of the A_DEFSYM case, just before default.
greetings, Thomas
----------------------------------------------------------------------
Comment By: Mathieu Bouchard (matju) Date: 2006-10-26 09:47
Message: Logged In: YES user_id=801174
Those changes were rejected from devel_0_39 ("uncommitted" aka reverted) on the grounds that it would make it more difficult to make devel_0_40 (that is, merge miller's 0.40 into devel_0_39), supposing that Miller would reject those changes, and that those changes are merely "cosmetic".
In releasing pd 0.40 as it is released, Miller demonstrates zero interest in something as simple and useful as removing unused variables.
That's why I didn't push that patch any further.
----------------------------------------------------------------------
Comment By: Hans-Christoph Steiner (eighthave) Date: 2006-10-17 01:38
Message: Logged In: YES user_id=27104
this has been here for a long while with no activity, so I am setting it to Pending. It'll be automatically set to closed after a while if no one tends to it.
----------------------------------------------------------------------
Comment By: Thomas Grill (xovo) Date: 2005-11-30 08:55
Message: Logged In: YES user_id=350252
there are also changes to extra. see the matju-extra.patch
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=1370034...
On Thu, 26 Oct 2006, IOhannes m zmölnig wrote:
SourceForge.net wrote:
In releasing pd 0.40 as it is released, Miller demonstrates zero interest in something as simple and useful as removing unused variables.
most likely, because you forgot to add the actual patch. see attached file.
I know that I goofed on this one by "forgetting" to attach the actual patch (that is, I had to tell it twice and I only told it once, in sourceforge's interface).
But I'm not talking about Miller's interest in integrating the patch, I'm talking about his interest in removing unused variables.
Anyway I don't want to talk about this, I should've kept my mouth shut.
_ _ __ ___ _____ ________ _____________ _____________________ ... | Mathieu Bouchard - tél:+1.514.383.3801 - http://artengine.ca/matju | Freelance Digital Arts Engineer, Montréal QC Canada
-
IOhannes m zmölnig -
Mathieu Bouchard -
SourceForge.net