Sure, we're working on that, Ben is, actually.
But let me be clear to all in here, the "# stuff" is not a feature
@Alex: Could you pull out the minimum changes you think would improve the color support as it is while leaving other things (features)
Sure, we're working on that, Ben is, actually.
But let me be clear to all in here, the "# stuff" is not a "feature". On the contrary. The idea is to restrict the functionality and only use a hexcolor format. This would be easier on the Pd side cause we can check the format for invalid requests and prevent tcl/tk errors. This would also be easy/better for Pd forks like Pd-L@ork and PlugData that don't use tcl/tk, and also for iemguis. In order for not to mess with this and leave as is, unrestricted, I'm not sure it's possible to prevent those tcl/tk errors, and we'd have to add functionality to iemguis so they also take any symbols for colors.
for later, ie. fix things but leave IEM guis as is? I think handling console and other things is best left separately.
I guess we can make a PR with all these requests, with the color restriction for last. The iemguis could be separate and this one should be considered first. If it's taken as it is, then I think it'd also be a no-brainer grabbing the iemguis loading Pd colors as the default. Handling those others separately as well also seems cool.
cheers
I think most of what's in the color fix PR should be considered, except maybe the # stuff for now.
Yeah, I guess this is the "biggest" one and more controversial, and it's tied to the iemguis issue. It should require a better discussion. I edited the first comment/description and improved the clarity a bit. I think they're all no-brainers and easy to incorporate. But dealing with the iemguis is still not ready and tricky. If you all want symbol, I can also try to let iemguis take color names like "black", "magenta" and "mistyrose".
Now, even though this takes care of most issues, there are still a couple more I wanted to add. At least one seems quite important, and it was brought up by you Dan, the ability to also set the blinking text edit marker. But that might be out of my scope... I'd also like to see Pd's console window take Pd's colors, but that seems even more tricky to me.
cheers
Introducing colors will be great and remove a sore spot for many and the things addressed in the PR really refine these changes IMO:
enohp ym morf tnes
-----------
Dan Wilcox
There is too much stuff in there for me to check it carefully... I'd have to put out a new test release and wait a few more weeks. What are the urgently needed fixes? (patch cords of course.)
There are plenty of other color _features_ we should have but I want to just deal with the things that are truly needed :)
cheers
M