Yes, definitely!


I didn't mean in merging right now. It's an idea for the future. That's why i'm starting this discussion now. To be prepared and take considerations regarding that goal during development and for devs to share their ideas on the subject.

Right know the plugin overwrites the pdtk_text_editing proc in pdtk_text.tcl and the script is only triggered when the user presses the Tab key. I'm not 100% about limitations and implications of this. For ex:


- what if other plugin by any change also overwrites pdtk_text_editing? (unlikely but possible)
- it would be nice that after writing "[send" the auto complete plugin allowed seraching among send/receive names. Such thing was intended by Yvan but in his implementation he could only detect when those names were created. But the user might just delete all [s][r] objects with those names, rename all of them or just close their containing patch. This way the names would still appear as suggestions despite not existing anymore. The names would also be lost between pd sessions. That's why right know i just disabled this feature. So i think i direct communication with pd would be the best way to do this. Would this be possible without integration with PD?

It's all on an early stage but just some updates on the current state of testing: 

-We've been testing the plugin and it reportedly worked in all win 7 machines we've used.
-Worked in some linux machines but we found minor problems in others.
-(Sierra/Yosemite) The listbox popup doesn't show on OS X right know but the rest of the plugin is working (the user can press up/down and type enter to get a random object, which tells us the underlying code is working)


We need more tests in all platforms! Running PD in RPI is more advanced so i guess it will be easier to find people to test it in the mailing lists :)

Cheers,

Henri.



De: Dan Wilcox <danomatika@gmail.com>
Enviado: domingo, 10 de junho de 2018 15:58
Para: Henri Augusto Bisognini; Alexandre Torres Porres
Cc: pd-dev
Assunto: Re: [PD-dev] PD AutoComplete Plugin
 
Technically, you can distribute GPL parts as long as they can be freely upgraded/replaced by the user. Since the part in question is a plugin script and not compiled into the Pd binary, it's my understanding that it doesn't infringe upon the library aspect of the GPL and the Pd source is already open.

The other aspect is more organizational: how/when do we integrate new things into the pd "core" and keep it maintainable. There is a conscious decision not to put *everything* into to core but some things may make sense. However I'd suggest *lots* of testing and built-in extensibility before making a formal proposal for it to be adopted. For instance, does this plugin impact GUI performance when patching on slow machines ie. RPI? I don't know, but it would be good to find out before adding something that would then be *expected* to work well.

On Jun 10, 2018, at 12:00 PM, pd-dev-request@lists.iem.at wrote:

From: Alexandre Torres Porres <porres@gmail.com>
To: Henri Augusto Bisognini <msndohenri@hotmail.com>
Cc: "pd-dev@lists.iem.at" <pd-dev@lists.iem.at>
Subject: Re: [PD-dev] PD AutoComplete Plugin
Message-ID:
<CAEAsFmh28zEgiyng92E8SC6XUFfnZLBwOLgXESte4iSrTT2o-A@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

OMG, this HAS to be part of the vanilla distribution!

I'll definitely test it and check it out.

I don't know much about licenses, there wouldn't be a problem to include a
GPL tcl code into Vanilla, right? Or would it help if it were BSD?

cheers