On Mon, Feb 27, 2017 at 4:28 AM, Roman Haefeli <reduzent@gmail.com> wrote:

...

I see you fixed even more for Windows than what I did. I would like to
integrate your changes, but there are some questions left. The svn log
suggests that you applied some changes specifically for Windows 10. In
the diff, I see you wrapped some lines of code in:

#ifdef _MSC_VER

If I understand correctly, those lines are only used when compiling
with Microsoft Visual Studio and mingw wouldn't use those lines. I'm
compiling with mingw and would like the result to work will in Windows
10, too. Now, my question is: Should the code you put in between
'#ifdef _MSC_VER' always be used when targeting Windows, regardless of
the compiler or is that code really specific for MSVC?

It's used to specify the use of sprintf_s() and strncpy_s(), the safer versions of sprintf() and strncpy(). If your compiler knows about these functions it would be better to use them, but not essential.

Martin