Pd-dev May 2011

pd-dev@lists.iem.at

13 participants
63 discussions

[ pure-data-Patches-3222795 ] fully automate the creation of the translation template.pot
by SourceForge.net 02 May '11

02 May '11

Patches item #3222795, was opened at 2011-03-18 14:19 Message generated for change (Settings changed) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3222795&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Hans-Christoph Steiner (eighthave) Assigned to: Miller Puckette (millerpuckette) Summary: fully automate the creation of the translation template.pot Initial Comment: The gettext tools can automatically generate a translation template file template.pot from the source code, but xgettext gets confused by the strings that are send from C to Tcl. So I added those strings to some fake Tcl files, and now "make po/template.pot" will automatically generate the updated translation template from the source code. ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2011-05-02 02:20 Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2011-04-18 01:24 Message: No idea what this does... but Hans is the authority on the makefile.am stuff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3222795&group_…

1 0

[ pure-data-Patches-3189135 ] glob_evalfile returns reference *
by SourceForge.net 02 May '11

02 May '11

Patches item #3189135, was opened at 2011-02-22 11:17 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3189135&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: None >Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Rich E (reakin) Assigned to: Miller Puckette (millerpuckette) Summary: glob_evalfile returns reference * Initial Comment: glob_evalfile returns a reference to the patch that it opens, which is useful when opening/closing patches with a system other than the messaging (pd open ....) system. We are already using this system in libpd to open and close patches by reference instead of file name, and this also allows us to know more about the patch at instantiation (ex. dollar args). As the method glob_evalfile currently returns void, it has no backwards incompatibility issues. ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2011-05-02 02:20 Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Miller Puckette (millerpuckette) Date: 2011-04-18 01:21 Message: Looks OK to me - I'll take it unless someone else complains :) ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-02-25 16:27 Message: yeah git format-patch preserves the author, etc. so its quite nice. The code looks good, and the patch looks perfect, thanks for the update! ---------------------------------------------------------------------- Comment By: Rich E (reakin) Date: 2011-02-25 09:40 Message: Okay, new uploaded patch file, this time formatted with git format-patch - I didn't realize that there was a difference between this and using git diff. Please let me know if there is any other issues. ---------------------------------------------------------------------- Comment By: Rich E (reakin) Date: 2011-02-24 12:16 Message: Please look at the updated diff file, I have removed all the tabs and inserted white spaces instead (sorry, its my ide's fault not mine). The brackets around the while statement are preferred, as we want to return x when it is still valid, not assign it a new value at each iteration (at which point the loop ends when x == null). ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-02-24 05:05 Message: Sounds like a reasonable patch, but the diff itself is fully of whitespace changes, so its quite hard to read. A patch should only have relevant changes in it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3189135&group_…

1 0

[ pure-data-Patches-3289212 ] Move text drawing routine to tcl
by SourceForge.net 01 May '11

01 May '11

Patches item #3289212, was opened at 2011-04-18 23:39 Message generated for change (Comment added) made by eighthave You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3289212&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix Status: Open Resolution: None Priority: 5 Private: No Submitted By: Kan-Ru Chen (kanru) Assigned to: Nobody/Anonymous (nobody) Summary: Move text drawing routine to tcl Initial Comment: It's best let tcl to figure out how to draw text and the border box. This should fix non-latin text drawing like Chinese. ---------------------------------------------------------------------- >Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-05-01 00:20 Message: In the long run, this patch is the right approach. But it'll take some major overhaul of the guts to get there. Basically, currently the core C 'pd' process receives the mouse motion from the Tcl 'pd-gui' process, and then 'pd' determines when something like an object or slider is clicked. That means with the current code, if Tcl sizes the boxes, then Pd will still think they are the original size. The current box width is determined by using the width of the latin capital M. It seems that chinese characters are much wider than a latin capital M. I attached an image that shows what happens if the current Pd code uses a chinese character as the baseline for the character width. Basically, chinese characters fit, but latin characters become oddly small. If you want to try this yourself, check out tcl/pd-gui.tcl, in the proc fit_font_into_metrics: while {[font measure $myfont M] > $width || \ ---------------------------------------------------------------------- Comment By: Kan-Ru Chen (kanru) Date: 2011-04-19 03:03 Message: As for the bug with the Chinese text not fitting in the boxes, my guess is that its related to the UTF-8 code, something like each chinese character is made up of multiple bytes, and some piece of code is still measuring one character equals one Right, currently `text_getrect' count the bytes in the string as the column numbers. After this patch the only reference to `text_getrect' is `gatom_getwherelabel'. I'm not familiar with pd enough so I left this untouched. ---------------------------------------------------------------------- Comment By: Hans-Christoph Steiner (eighthave) Date: 2011-04-19 00:35 Message: This patch is definitely the right approach going forward (instead of generating Tcl commands on the C-side, calling Tcl procs from C). Part of the problem though is that the mouse tracking is still handled on the C-side, and this patch makes the boxes smaller than the original size. Therefore if you clikc just above or below the box, Pd still uses the old measurements (now in pd-gui.tcl) as the basis for determining what was clicked on, and you'll get the menu for that object that was just below where the mouse clicked rather than the menu for the canvas that was just clicked. I think this patch could be useful now if it used the box measurements in pd-gui.tcl, and then fit the font into them. As for the bug with the Chinese text not fitting in the boxes, my guess is that its related to the UTF-8 code, something like each chinese character is made up of multiple bytes, and some piece of code is still measuring one character equals one byte. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3289212&group_…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pd-dev May 2011